Age | Commit message (Collapse) | Author |
|
session names for adhoc.
Bug was caused by using incorrect (unlocalized) name of session as argument for some methods after the session name was localized in constructor.
- Used correct (localized) session name instead.
|
|
- Moved the "no session" string to XML and used it in code instead of hardcode.
- Conference string turned out to be already translated, but the way translation was happening ad-hoc chat log files on disk
would get localized names, and thus be inconsistent (and that would create problems with browsing them later).
It didn't happen already just because this string wasn't translated in other locales somewhy.
So moved localization of session name after the the creation of log file.
Also changed value of string according to Eli's comment in ticket.
|
|
--HG--
branch : product-engine
|
|
back-out the back-out for this branch. yay.
|
|
Backing out this merge that I pushed (prematurely) to the wrong place.
|
|
|
|
the long timestamp displayed in IM when user is offline)
- Created a string with a time stamp parameter and added it to the strings.xml
Reviewed by Vadim Savchuk at https://codereview.productengine.com/secondlife/r/872/
--HG--
branch : product-engine
|
|
in Recent Tab.
Used previously commented code which adds only online paricipants instead of current code that added all.
Reviewed by Vadim Savchuk at https://codereview.productengine.com/secondlife/r/860/
--HG--
branch : product-engine
|
|
|
|
|
|
|
|
|
|
|
|
|
|
string for incoming ad-hoc chats.
Added a new string "conference-title-incoming" to strings.xml
For now the "Conference" word is localized wherever this session name is shown:
* IM window title
* Voice notifications
Further Localization is out of scope of this ticket and will be done in a separate localization cycle.
Reviewed by Vadim Savchuk at https://codereview.productengine.com/secondlife/r/816/
--HG--
branch : product-engine
|
|
|
|
|
|
of incoming ad-hoc chat.
REASON: it was implemented in EXT-5694 to add all ad-hoc participants when user send a message to session created himself.
Participants IDs are known in this case.
But in case of incoming ad-hoc chat those IDs are not known. Container used to get IDs contains only Ad-hoc Session ID.
So, (???) is expected in this case in Recent People Panel.
FIX: disabling adding of items into Recent People list in case of incoming ad-hoc chat.
Note: participants will be added to the list once they send a message to chat.
Reviewed by Vadim Savchuk at https://codereview.productengine.com/secondlife/r/724/
--HG--
branch : product-engine
|
|
|
|
Reviewed by Vadim Savchuk at https://codereview.productengine.com/secondlife/r/675/
--HG--
branch : product-engine
|
|
Reviewed by Mike Antipov at https://codereview.productengine.com/secondlife/r/658/
--HG--
branch : product-engine
|
|
|
|
logging of 'item shared' message instead of spawning IM session and add message to it.
Details:
1 Corrected 'ItemsShared' notification message.
2 Avoided spawning session on item shared event.
3 Provided logging of item shared message.
4 Provided logging of 'IMSystemMessageTip' notification without opened related IM session.
reviewed by Mike Antipov at https://codereview.productengine.com/secondlife/r/612/
--HG--
branch : product-engine
|
|
Switch to new serialization format, change filename so old viewers
don't get confused if the user switches back. Reviewed with Richard
|
|
|
|
Wasn't updating window title with correct name. Also fixed
outgoing call dialog. Reviewed with Simon.
|
|
Fixed to use Display Name (Username), fixed icon placement,
also fixed notifications system well names. Reviewed with Leyla.
|
|
- Changed group invite string from "has joined a Voice Chat call with the group [GROUP]" to "just joined '[GROUP]' voice channel."
- Added special string for group invite question saying "Would you like to leave [CURRENT_CHAT] and join the call with '[GROUP]'"?
- Hooked up this string in code.
Reviewed by Vadim Savchuk at https://codereview.productengine.com/secondlife/r/458/
--HG--
branch : product-engine
|
|
Had to change the chat log file format to include agent_id.
Code will load viewer 2.0 logs, but viewer 2.0 will just discard
data from 2.1 logs, which seems OK. Reviewed with Leyla.
|
|
Discussed with Leyla/Richard
|
|
Reviewed with Leyla
|
|
|
|
Product made a late-breaking request to change the name of this
field. The wire protocol for People API has not yet changed.
|
|
Reviewed by Richard Nelson and Mike Antipov at https://codereview.productengine.com/secondlife/r/363/
--HG--
branch : product-engine
|
|
(Last commit was actually for outbound). Reviewed with Leyla
|
|
|
|
|
|
|
|
|
|
- Removed string fragmentation by changing concatenation of name and action to whole-sentence strings.
Reviewed by Mike Antipov at https://codereview.productengine.com/secondlife/r/328
--HG--
branch : product-engine
|
|
is shown while connecting to ad-hoc voice chat).
Bug consisted of two problems- showing empty outgoing call floater and corrupted text in outgoing call floater. First was ad-hoc and group call specific and was caused by not showing appropriate text for STATE_READY voice channel state. Second was caused by too small space between "Connecting to..." and "Leaving..." textboxes, which enden in their collision for long names.
- First problem was fixed by adding STATE_READY case into appropriate switch where textboxes are made visible.
- Second was solved by placing "Leaving..." textbox lower
Reviewed by Vadim Sachuk at https://codereview.productengine.com/secondlife/r/310/
--HG--
branch : product-engine
|
|
|
|
after moderator left group call)
Reason: session's Speaker Manager was not updated when voice call ended. Speakers had incorrect voice related state.
Fix: update speakers' state when voice call is finished.
Also VCP now uses LLIMMgr::endCall to perform "Leave Call" action.
Reviewed by Vadim Savchuk at https://codereview.productengine.com/secondlife/r/276/
--HG--
branch : product-engine
|
|
|
|
|
|
sessions)
The reason: LLCallDialogManager did not disconnect from "voice channel state changed" signal on channel in previous session.
Thus when old channel changes state from STATE_HUNG_UP to STATE_CALL_STARTED there is invalid pointer to session in connected LLCallDialogManager::onVoiceChannelStateChanged callback before current voice channel is changed and pointer to session becames valid.
Fix: add storing of connection to signal in voice channel from previous session and disconnect it before connecting to channel in current session.
Reviewed by Vadim Savchuk at https://codereview.productengine.com/secondlife/r/244/
--HG--
branch : product-engine
|
|
DEV-48903 - malformed names in p2p dialogs for Diamondware
In the merge there were some changes that didn't get propagated that resulted in some failures with
respect to diamondware name processing. THe determination as to whether a p2p session was with
an avatar or with an alcatel (pbx) wasn't propagated into the diamondware code.
I fixed that by merging the changes to the vivox module with respect to that into the diamondware module.
Also, the acceptance dialog was vanishing too quickly as the determination as to whether there was still
a p2p invite pending was not updated when the calling code was updated.
The calling code initially was changed to look into vivox state which isn't really valid. that was changed in
the 'trunk' to another mechanism, but that still assumed visibility into the voice code.
I fixed that by creating an API call to ask whether a call was pending.
CR: Karina
|
|
|
|
because connection problem).
- Added additional check for client's voice working properly before inviting to session.
Reviewed by Vadim Savchuk at https://codereview.productengine.com/secondlife/r/228/
--HG--
branch : product-engine
|
|
call").
- Removed names from strings containing info about other user joining or ending the call to make them more general. See comment to JIRA ticket for more info.
Reviewed by Vadim Savchuk at https://codereview.productengine.com/secondlife/r/210/
--HG--
branch : product-engine
|