Age | Commit message (Collapse) | Author |
|
Reviewer: Richard Linden
- Minor fixes from code review
- Continue stubbing out ban_reason, or implement it (depending on how quickly
I can do it, though stubbing out ban_reason will be sufficient, which it is now)
- Fixed an issue where a ban list string in the actions tab wasn't showing up
properly
|
|
|
|
|
|
- Code cleanup
|
|
- Added refresh button to ban list panel
- Added an additional signal to LLNameListCtrl to indicate when the entire name
cache is complete.
|
|
- Changed PUT and DEL to POST which accepts an enum for a create or delete
|
|
- Lots of crap isn't working as intended yet.
|
|
replace llinfos, lldebugs, etc with new LL_INFOS(), LL_DEBUGS(), etc.
|
|
|
|
|
|
dependencies
|
|
|
|
|
|
changes to common libraries from the server codebase:
* Additional error checking in http handlers.
* Uniform log spam for http errors.
* Switch to using constants for http heads and status codes.
* Fixed bugs in incorrectly checking if parsing LLSD xml resulted in an error.
* Reduced spam regarding LLSD parsing errors in the default completedRaw http handler. It should not longer be necessary to short-circuit completedRaw to avoid spam.
* Ported over a few bug fixes from the server code.
* Switch mode http status codes to use S32 instead of U32.
* Ported LLSD::asStringRef from server code; avoids copying strings all over the place.
* Ported server change to LLSD::asBinary; this always returns a reference now instead of copying the entire binary blob.
* Ported server pretty notation format (and pretty binary format) to llsd serialization.
* The new LLCurl::Responder API no longer has two error handlers to choose from. Overriding the following methods have been deprecated:
** error - use httpFailure
** errorWithContent - use httpFailure
** result - use httpSuccess
** completed - use httpCompleted
** completedHeader - no longer necessary; call getResponseHeaders() from a completion method to obtain these headers.
* In order to 'catch' a completed http request, override one of these methods:
** httpSuccess - Called for any 2xx status code.
** httpFailure - Called for any non-2xx status code.
** httpComplete - Called for all status codes. Default implementation is to call either httpSuccess or httpFailure.
* It is recommended to keep these methods protected/private in order to avoid triggering of these methods without using a 'push' method (see below).
* Uniform error handling should followed whenever possible by calling a variant of this during httpFailure:
** llwarns << dumpResponse() << llendl;
* Be sure to include LOG_CLASS(your_class_name) in your class in order for the log entry to give more context.
* In order to 'push' a result into the responder, you should no longer call error, errorWithContent, result, or completed.
* Nor should you directly call httpSuccess/Failure/Completed (unless passing a message up to a parent class).
* Instead, you can set the internal content of a responder and trigger a corresponding method using the following methods:
** successResult - Sets results and calls httpSuccess
** failureResult - Sets results and calls httpFailure
** completedResult - Sets results and calls httpCompleted
* To obtain information about a the response from a reponder method, use the following getters:
** getStatus - HTTP status code
** getReason - Reason string
** getContent - Content (Parsed body LLSD)
** getResponseHeaders - Response Headers (LLSD map)
** getHTTPMethod - HTTP method of the request
** getURL - URL of the request
* It is still possible to override completeRaw if you want to manipulate data directly out of LLPumpIO.
* See indra/llmessage/llcurl.h for more information.
|
|
http error handlers to understand LLSD error responses. Fleshing out most http error handler message spam.
|
|
loading group members
* Fix one race condition that could dereference a dangling pointer.
reviewed with Simon and Baker.
|
|
doesn't support the new GroupMemberData capabaility
- Fixed a potential null pointer crash.
Thanks to Ansariel from Firestorm for these!
Reviewer: Myself
|
|
|
|
|
|
- Reduced the timeout to 5 minutes, down from 10 minutes.
- Provided output for GroupMemberResponder error
- Removed commented calls to sendGroupMembersRequest
- Reordered calls to sendCapGroupMembersRequest so it's called last
|
|
|
|
- Changed level of output logs
- Cleaned up comments
|
|
|
|
|
|
* increased max groups to 20
* changed cache to LRU instead of 'delete half when overfull'
reviewed with Baker
|
|
This change is not guaranteed to fix this issue as the issue
is difficult to repro, but there was a sketchy case
group member responses come back from the simulator in message
packets. For very large numbers of members, there may be a
large number of packets received. The member data is placed
in a structure of type LLGroupMgrGroupData, based on the group
id.
The problem is, if the user refreshes the group before the entire
contents of the previous request comes back, response packets from
the previous request will be intermingled with the responses from
the refresh.
Both the request call and the response handler would create the
group data structure, if the structure wasn't already there. There
may be a case where a response from the previous request causes
creation of the group data, populating it with the contents of the
response, and the responses from the second request would use that
group data structure.
Also, cleaned up some comments and variable names to be consistent
|
|
|
|
|
|
|
|
status.
Reviewed by Mike Antipov at https://codereview.productengine.com/secondlife/r/792/
--HG--
branch : product-engine
|
|
Superficial cleanup to change all typedef std::vector<LLUUID> to use a common typedef uuid_vec_t instead.
|
|
roles need to be localized
reviwed https://codereview.productengine.com/secondlife/r/22/
--HG--
branch : product-engine
|
|
* Removed the excessive zeroes from day format.
* Fixed padding with spaces instead of zeroes on Linux.
--HG--
branch : product-engine
|
|
of date
--HG--
branch : product-engine
|
|
--HG--
branch : product-engine
|
|
- Removed warnings used to deal with fixed EXT-4778
- Replaced (*it) with ejected_member_id where it wasn't to make code more clear
--HG--
branch : product-engine
|
|
LLGroupMgr::sendGroupMemberEjects [secondlife-bin llgroupmgr.cpp:1708])
- Replaced usage of map iterator (which later became invalid and this caused crash) with pointer to data.
--HG--
branch : product-engine
|
|
|
|
Checker: MISSING_BREAK
Function: LLGroupMgrGroupData::sendRoleChanges()
File: /indra/newview/llgroupmgr.cpp
not a bug.
|
|
- Deleted unnecessary parameters (UIButtonImageTopPadding, UIButtonImageBottomPadding) from settings.xml and their usage in LLTabContainer
- Deleted triggers (LLIMFloaterContainer::processProperties and LLIMFloaterContainer::changed) due to LLIMFloaterContainer no more Observer
- Renamed class LLParticularGroupMgrObserver to LLParticularGroupObserver as the last one's name is more self explanatory
--HG--
branch : product-engine
|
|
--HG--
branch : product-engine
|
|
--HG--
branch : product-engine
|
|
multifloater tabs)
--HG--
branch : product-engine
|
|
refreshed only after restarting Viewer
--HG--
branch : product-engine
|
|
Cuts number of includes of llnotifications.h from 300+ to 40.
|
|
Fixed includes of llmenugl.h / llnotifications.h
Note: Clipping is incorrect, I think due to line editor bug.
|
|
This checkin deletes all of the code associated with the old XUI-based
search interface, including LLFloaterDirectory, LLPanelDir*, a global
variable event hack, and the associated XUI file. The new web-based
search interface, LLFloaterSearch, is the way of the future.
Deleted 19 files and 5,838 lines of code.
|
|
floater, and anywhere secondlife:///app/group URLs appear. Reviewed with Leyla.
|
|
https://svn.aws.productengine.com/secondlife/export-from-ll/viewer-2-0@1471 https://svn.aws.productengine.com/secondlife/pe/stable-1@1476 -> viewer-2.0.0-3
EXT-65 EXT-270 EXT-359 EXT-361 EXT-367 EXT-367 EXT-368 EXT-455 EXT-468 EXT-530 EXT-539 EXT-540 EXT-542 EXT-545 EXT-555 EXT-557 EXT-558 EXT-559 EXT-559 EXT-560 EXT-561 EXT-562 EXT-563 EXT-564 EXT-566 EXT-568 EXT-569 EXT-570 EXT-571 EXT-581 EXT-590 EXT-594 EXT-596 EXT-597 EXT-601 EXT-602 EXT-603 EXT-613 EXT-620 EXT-624 EXT-628 EXT-630 EXT-631 EXT-632 EXT-639 EXT-640 EXT-641 EXT-642 EXT-662 EXT-671 EXT-672 EXT-676 EXT-682 EXT-692 EXT-703 EXT-717
|
|
https://svn.aws.productengine.com/secondlife/pe/stable-1@1297 -> viewer-2-0
Fixes:
EXT 208 EXT 366 EXT-211 EXT-245 EXT-246 EXT-278 EXT-279 EXT-280 EXT-298 EXT-301 EXT-304 EXT-311 EXT-317 EXT-318 EXT-319 EXT-339 EXT-343 EXT-344 EXT-346 EXT-349 EXT-350 EXT-351 EXT-354 EXT-355 EXT-358 EXT-360 EXT-362 EXT-369 EXT-372 EXT-374 EXT-381 EXT-382 EXT-383 EXT-395 EXT-396 EXT-412
Other changes:
Movement & Caemra controls work
Profile and Me panel refactoring
Notification refactoring
|