Age | Commit message (Collapse) | Author | |
---|---|---|---|
2020-10-06 | Replace references to static writefile with write so we end up with only a ↵ | Callum Prentice | |
single read and a single write function | |||
2020-09-24 | Complete the change from lldiskcache -> llfilesystem and then addition of ↵ | Callum Prentice | |
new lldiskcache implementation | |||
2020-09-22 | Merge branch 'master' into DRTVWR-519 | Callum Prentice | |
2020-09-16 | Renamed the references to LLVFile and llvfile.* source code plus cmake ↵ | Callum Prentice | |
scripts to use a different name - lldiskcache - since that more closely resembles what it is (or will be) now that the VFA is no more | |||
2020-09-16 | First part of change to remove LLVFS from the Viewer. Consists of code ↵ | Callum Prentice | |
changes to remove LLVFS and LLVFSThread classes along with the associated source files. The existing llvfs folder is renamed to llcache. Also includes changes to CMake script in many places to reflect changes. Eventually, llvfile source file and class will be renamed but that is not in this change. | |||
2020-09-02 | SL-13894 Abuse Report Screenshot should always include UI | Andrey Kleshchev | |
2020-07-20 | Merge branch 'master' into DRTVWR-501-maint | Andrey Lihatskiy | |
# Conflicts: # autobuild.xml # indra/newview/llimprocessing.cpp | |||
2020-03-28 | Merge branch 'master' into DRTVWR-501-maint | Andrey Lihatskiy | |
2020-03-25 | SL-11216: Convert LLVersionInfo to an LLSingleton. | Nat Goodspeed | |
This changeset is meant to exemplify how to convert a "namespace" class whose methods are static -- and whose data are module-static -- to an LLSingleton. LLVersionInfo has no initClass() or cleanupClass() methods, but the general idea is the same. * Derive the class from LLSingleton<T>: class LLSomeSingleton: public LLSingleton<LLSomeSingleton> { ... }; * Add LLSINGLETON(LLSomeSingleton); in the private section of the class. This usage implies a separate LLSomeSingleton::LLSomeSingleton() definition, as described in indra/llcommon/llsingleton.h. * Move module-scope data in the .cpp file to non-static class members. Change any sVariableName to mVariableName to avoid being outright misleading. * Make static class methods non-static. Remove '//static' comments from method definitions as needed. * For LLVersionInfo specifically, the 'const std::string&' return type was replaced with 'std::string'. Returning a reference to a static or a member, const or otherwise, is an anti-pattern: the interface constrains the implementation, prohibiting possibly later returning a temporary (an expression). * For LLVersionInfo specifically, 'const S32' return type was replaced with simple 'S32'. 'const' is just noise in that usage. * Simple member initialization (e.g. the original initializer expressions for static variables) can be done with member{ value } initializers (no examples here though). * Delete initClass() method. * LLSingleton's forté is of course lazy initialization. It might work to simply delete any calls to initClass(). But if there are side effects that must happen at that moment, replace LLSomeSingleton::initClass() with (void)LLSomeSingleton::instance(); * Most initClass() initialization can be done in the constructor, as would normally be the case. * Initialization that might cause a circular LLSingleton reference should be moved to initSingleton(). Override 'void initSingleton();' should be private. * For LLVersionInfo specifically, certain initialization that used to be lazily performed was made unconditional, due to its low cost. * For LLVersionInfo specifically, certain initialization involved calling methods that have become non-static. This was moved to initSingleton() because, in a constructor body, 'this' does not yet point to the enclosing class. * Delete cleanupClass() method. * There is already a generic LLSingletonBase::deleteAll() call in LLAppViewer::cleanup(). It might work to let this new LLSingleton be cleaned up with all the rest. But if there are side effects that must happen at that moment, replace LLSomeSingleton::cleanupClass() with LLSomeSingleton::deleteSingleton(). That said, much of the benefit of converting to LLSingleton is deleteAll()'s guarantee that cross-LLSingleton dependencies will be properly honored: we're trying to migrate the code base away from the present fragile manual cleanup sequence. * Most cleanupClass() cleanup can be done in the destructor, as would normally be the case. * Cleanup that might throw an exception should be moved to cleanupSingleton(). Override 'void cleanupSingleton();' should be private. * Within LLSomeSingleton methods, remove any existing LLSomeSingleton::methodName() qualification: simple methodName() is better. * In the rest of the code base, convert most LLSomeSingleton::methodName() references to LLSomeSingleton::instance().methodName(). (Prefer instance() to getInstance() because a reference does not admit the possibility of NULL.) * Of course, LLSomeSingleton::ENUM_VALUE can remain unchanged. In general, for many successive references to an LLSingleton instance, it can be useful to capture the instance() as in: auto& versionInfo{LLVersionInfo::instance()}; // ... versionInfo.getVersion() ... We did not do that here only to simplify the code review. The STRINGIZE(expression) macro encapsulates: std::ostringstream out; out << expression; return out.str(); We used that in a couple places. For LLVersionInfo specifically, lllogininstance_test.cpp used to dummy out a couple specific static methods. It's harder to dummy out LLSingleton::instance() references, so we add the real class to that test. | |||
2019-11-15 | SL-11898 Hi-res snapshots do not support UI and HUDs and should not show them | andreykproductengine | |
2019-11-14 | SL-10499, SL-10497 - use LLAgentBenefits info | Brad Payne (Vir Linden) | |
2019-06-12 | SL-11402 Floater reporter images should be saved as png | andreykproductengine | |
2018-04-06 | SL-440 Fix coroutine name | Andrey Kleshchev | |
2018-03-30 | SL-440 Obtain Abuse Report categories from capability | Andrey Kleshchev | |
2018-03-09 | MAINT-8366 FIXED "Report Abuse" preview screenshot all black | maxim_productengine | |
2018-01-11 | MAINT-8170 Crash viewer when double click on "Report Abuse" | Mnikolenko Productengine | |
2017-09-13 | MAINT-7794 Wrap getCapability(..) calls to avoid crashes | Mnikolenko Productengine | |
2017-01-24 | MAINT-7067 Issue with UI artifacts showing up in Abuse Report screenshots. | Mnikolenko Productengine | |
2017-01-19 | MAINT-7066 Issues where viewer always asks to use previous screenshot when ↵ | Mnikolenko Productengine | |
filing abuse report. | |||
2016-10-04 | MAINT-6779 Allow to use last pic from Abuse report floater after relog | Mnikolenko Productengine | |
2016-09-12 | SL-444 Add Abuse Report Submision Confirmation Pop up | Mnikolenko Productengine | |
2016-08-10 | SL-437 Remove Checkbox from Abuse Report Submission | Mnikolenko Productengine | |
2016-04-04 | merge with 4.0.3-release | Oz Linden | |
2015-11-10 | remove execute permission from many files that should not have it | Oz Linden | |
2015-10-19 | Merge from viewer release. | Rider Linden | |
2015-09-03 | Changes from code review with Nat | Rider Linden | |
2015-09-01 | MAINT-5575: Convert the Experience cache into a coro based singleton. | Rider Linden | |
--HG-- branch : MAINT-5575 | |||
2015-08-25 | Merge | Rider Linden | |
2015-08-05 | MAINT-5348 FIXED Use this screenshot option will be checked by default now. | Mnikolenko ProductEngine | |
2015-07-23 | Remove unused code and llassetuploadresponders files. | Rider Linden | |
2015-07-23 | AR Reports now use coroutines. | Rider Linden | |
2015-07-01 | Merge from viewer-relese and become version 3.8.1 | andreykproductengine | |
2015-06-08 | merge changes for 3.7.29-release | Oz Linden | |
2015-07-02 | Merge from viewer-relese and become version 3.8.1 | andreykproductengine | |
2015-04-28 | increment viewer version to 3.7.29 | Mnikolenko ProductEngine | |
2015-04-28 | Merge viewer-release, become version 3.7.29 | Mnikolenko ProductEngine | |
2015-03-04 | MAINT-4939 FIXED Remove Abuse Report Pop-Up Dialog | andreykproductengine | |
2014-10-18 | Update to build on Xcode 6.0: remove lots of unused variables | callum_linden | |
2014-06-17 | Merge with 3.7.9-release | dolphin | |
2014-05-13 | sunshine-external merge WIP | Brad Payne (Vir Linden) | |
2014-05-07 | Merge with 3.7.7-release | dolphin | |
2014-04-23 | Clear abuse details before adding experience id for ACME-1421 | Cho | |
2014-03-20 | Experience log panel | dolphin | |
2014-03-17 | Updated experience cache to get a const reference to xp data | dolphin | |
2014-03-13 | Added a Report Abuse button to the experience profile | dolphin | |
2013-08-09 | second phase summer cleaning | Richard Linden | |
replace llinfos, lldebugs, etc with new LL_INFOS(), LL_DEBUGS(), etc. | |||
2013-07-08 | SH-4299 WIP: Interesting: High fps shown temporarily off scale in statistics ↵ | Richard Linden | |
console added percentage/ratio units added auto-range and auto tick calculation to stat bar to automate display stats | |||
2013-05-21 | merge | Brad Payne (Vir Linden) | |
2013-04-19 | merge changes for DRTVWR-294 | Oz Linden | |
2013-03-29 | Update Mac and Windows breakpad builds to latest | Graham Madarasz | |