Age | Commit message (Collapse) | Author |
|
with less finicky hit testing
|
|
|
|
landmarks don't send any back to the end of the list
|
|
Landmarks" menuitem)
- Added menu item "Open landmarks" as the last menu item in favorites menu
|
|
- Removed all sidetray dependencies and the sidetray itself.
- Also removed LLFloaterSidetrayTab and LLSidetrayListener as unused.
|
|
sergeylproductengine/viewer-experience-fui/
|
|
deprecated pointless LLView::deleteViewByHandle
|
|
- Added xml for a new floater and registred it in the floaterreg
- Removed side tray dependencies
- Added static helper method: LLFloaterSidePanelContainer::showPanel
|
|
to be on one line)
- Changed member variable name mChevronButton to mMoreTextBox
- Fixed some bugs which PE testers have found:
1. Parcel characteristics icons from location bar overlay other ui elements
2. Navigation & Favorites bar are displayed after exitting mouselook mode although 'Show Navigation & Favorites bar' is unchecked
|
|
one line)
- Relocated address bar, combined with favorite landmarks EXP-1208
- Added dragger to change amount of space allocated to address bar and favorites bar EXP-1217
- Modified Favorites ->> More spillover EXP-1218
- Combined context menu menuitems for favorites & address bars EXP-1219
|
|
|
|
showing them on login screen.
- Changed the way SLURLs are cached a little, because previous one introduced problems with theit order.
- Also allowed saving of favorites to disk even if not all of them received SLURL info - this is done to avoid favorites not saving when there is at least one "dead" landmark among them.
- "Username" field on login screen is now not a lineeditor, but combobox (to enable autocompletion), but without button (Esbee asked for this in ticket for security reasons, and perhaps for visual consistency).
- Elements of this combobox are names of users whose favorites we have saved in file.
- Contents of "Start at:" combobox are changed depending on changes in "Username"- if username is present in favorites file, favorites for this user are added there.
- New callback was added to LLCombobox and used in this fix, because present ones weren't enough to easily track changes in text entry.
|
|
landmark context menu item.
|
|
|
|
"Start at" combobox on login screen was implemented.
Implementation details:
- File is saved on exit from viewer and not immediately on changes as was written in spec. It is done to make this file consistent with favorites order: order of favorites is saved on exit,
so if favorites info is saved in other moment earlier, crashing viewer or other unexpected way of finishing its work (i.e. via Windows task bar) would cause inconsistence between favorites order
saved per account and one from this new file.
- File is saved in user_settings\stored_favorites.xml.
- If you uncheck the option in Preferences and press OK, the file gets immediately deleted (according to spec).
Issues that require further changes:
- Currently only favorites of last logged in user are shown in login screen. Showing favorites of multiple users will be implemented later when design for it is approved by Esbee.
- Preference is now global for all users, because design states it may be changed before login, and we don't have account info at the moment. But it doesn't seem to be a good idea, so changes in design are needed.
- Currently the way of retrieving SLURLs needs optimization in a separate ticket.
More detailed design approved by Esbee is needed to develop it further, perhaps in new tickets.
|
|
Favorites bar from any location besides My Inventory or Library.
|
|
Caused by the fix of EXT-4217 which I had to revert.
|
|
|
|
|
|
|
|
streamlined LLUICtrlFactory's interface
|
|
|
|
|
|
kept after LM was dragged away)
- Added menu hiding on left mouse down callback for drop down menu item
Reviewed by Mike Antipov at https://codereview.productengine.com/secondlife/r/337/
--HG--
branch : product-engine
|
|
|
|
reviewed by Leyla
|
|
Moved all the LLInventoryModelCOllectFunctors from LLInventoryModel to LLInventoryFunctions
|
|
Checker: NULL_RETURNS
Function: LLFavoritesBarCtrl::insertBeforeItem(LLDynamicArray<LLPointer<LLViewerInventoryItem>, (int)32> &, const LLUUID &, LLViewerInventoryItem *)
File: /indra/newview/llfavoritesbar.cpp
|
|
copy/paste/delete)
--HG--
branch : product-engine
|
|
--HG--
branch : product-engine
|
|
appear if you have no favorites
Changes:
Check for empty favbar has been added to change visibility of favbar label
--HG--
branch : product-engine
|
|
--HG--
branch : product-engine
|
|
|
|
with 1@ in Viewer 1.23.x)
-- cleanup: removed deprecated code added for previous sollution to support custom sorting of favorite landmarks.
For now previous implementation is removed, bug is FIXED.
--HG--
branch : product-engine
|
|
choose 'Copy SLUrl' from 'Favorites Bar' context menu.
--HG--
branch : product-engine
|
|
from 'Places Task Panel ->My Landmarks'
to 'Favorites Bar').
--HG--
branch : product-engine
|
|
non-changed if change its order in the 'Favorites Bar')
-- reason: there was two places where identical resorting of Favorite landmarks functionality was implemented: InventoryBridge & Favorite bar.
It was not impelnmented properly in favorites bar: LLInventoryObserver::SORT flag was not set after d-n-d.
-- fix: moved identical functionality to update & save order of Favorite landmarks from these places to Inventory Panel
--HG--
branch : product-engine
|
|
- Removed extra attributes from favorites_bar_button.xml.
- Changed warning message about favorites bar button creation failure.
--HG--
branch : product-engine
|
|
was fixed)
--HG--
branch : product-engine
|
|
being performed by \"teleport\" item from landmark's context menu
--HG--
branch : product-engine
|
|
the Favor bar / Overflow menu
rect param actually do nothing. to change tooltip width we may manipulate max_width param.
--HG--
branch : product-engine
|
|
|
|
Cause:
An error of invalid array index.
Solution:
Additional check has been added.
--HG--
branch : product-engine
|
|
Map accessor was not checking for NULL.
|
|
--HG--
branch : product-engine
|
|
cache (was Clear Cache)
EXT-2652 Favorites bar drop-down button (for when favorites exceed width of viewer) is not configurable via XUI
EXT-2227 [BSI] Preferences -> Setup -> Cache Location blank
EXT-1036 Clicking menu separators selects wrong menu option (allows selection of greyed-out option)
reviewed by James
|
|
reviewed by James
|
|
coordinates).
--HG--
branch : product-engine
|
|
- Fixed toggleable menu in Picks panel.
- Minor optimization of LLToggleableMenu.
--HG--
branch : product-engine
|
|
|