summaryrefslogtreecommitdiff
path: root/indra/newview/llenvmanager.h
AgeCommit message (Collapse)Author
2016-09-15MAINT-5232: Normalize LLSingleton subclasses.Nat Goodspeed
A shocking number of LLSingleton subclasses had public constructors -- and in several instances, were being explicitly instantiated independently of the LLSingleton machinery. This breaks the new LLSingleton dependency-tracking machinery. It seems only fair that if you say you want an LLSingleton, there should only be ONE INSTANCE! Introduce LLSINGLETON() and LLSINGLETON_EMPTY_CTOR() macros. These handle the friend class LLSingleton<whatevah>; and explicitly declare a private nullary constructor. To try to enforce the LLSINGLETON() convention, introduce a new pure virtual LLSingleton method you_must_use_LLSINGLETON_macro() which is, as you might suspect, defined by the macro. If you declare an LLSingleton subclass without using LLSINGLETON() or LLSINGLETON_EMPTY_CTOR() in the class body, you can't instantiate the subclass for lack of a you_must_use_LLSINGLETON_macro() implementation -- which will hopefully remind the coder. Trawl through ALL LLSingleton subclass definitions, sprinkling in LLSINGLETON() or LLSINGLETON_EMPTY_CTOR() as appropriate. Remove all explicit constructor declarations, public or private, along with relevant 'friend class LLSingleton<myself>' declarations. Where destructors are declared, move them into private section as well. Where the constructor was inline but nontrivial, move out of class body. Fix several LLSingleton abuses revealed by making ctors/dtors private: LLGlobalEconomy was both an LLSingleton and the base class for LLRegionEconomy, a non-LLSingleton. (Therefore every LLRegionEconomy instance contained another instance of the LLGlobalEconomy "singleton.") Extract LLBaseEconomy; LLGlobalEconomy is now a trivial subclass of that. LLRegionEconomy, as you might suspect, now derives from LLBaseEconomy. LLToolGrab, an LLSingleton, was also explicitly instantiated by LLToolCompGun's constructor. Extract LLToolGrabBase, explicitly instantiated, with trivial subclass LLToolGrab, the LLSingleton instance. (WARNING: LLToolGrabBase methods have an unnerving tendency to go after LLToolGrab::getInstance(). I DO NOT KNOW what should be the relationship between the instance in LLToolCompGun and the LLToolGrab singleton instance.) LLGridManager declared a variant constructor accepting (const std::string&), with the comment: // initialize with an explicity grid file for testing. As there is no evidence of this being called from anywhere, delete it. LLChicletBar's constructor accepted an optional (const LLSD&). As the LLSD parameter wasn't used, and as there is no evidence of it being passed from anywhere, delete the parameter. LLViewerWindow::shutdownViews() was checking LLNavigationBar:: instanceExists(), then deleting its getInstance() pointer -- leaving a dangling LLSingleton instance pointer, a land mine if any subsequent code should attempt to reference it. Use deleteSingleton() instead. ~LLAppViewer() was calling LLViewerEventRecorder::instance() and then explicitly calling ~LLViewerEventRecorder() on that instance -- leaving the LLSingleton instance pointer pointing to an allocated-but-destroyed instance. Use deleteSingleton() instead.
2015-11-10remove execute permission from many files that should not have itOz Linden
2013-11-19replace uses of LLEnvManagerNew::setRegionChangeCallback with ↵Oz Linden
LLAgent::addRegionChangedCallback
2013-03-29Update Mac and Windows breakpad builds to latestGraham Madarasz
2011-08-04fix license headersOz Linden
2011-07-06STORM-1262 FIXED Removed the original Windlight Region Settings implementation.Vadim ProductEngine
2011-06-10STORM-1279 FIXED Changing sky preset with a keyboard shortcut now updates ↵Vadim ProductEngine
the Environment Settings floater. Changes: * Subscribed the floater to the "settings changed" signal of the environment manager. * Rewrote the floater to not modify settings only when the Save button is pressed. * Refactoring to eliminate code duplication.
2011-06-09STORM-1279 WIP Renamed a method.Vadim ProductEngine
2011-06-09STORM-1279 WIP Moved private methods to the appropriate section.Vadim ProductEngine
2011-06-06STORM-1255 WIP Made the check for region permissions reusable.Vadim ProductEngine
2011-06-02STORM-1253 WIP Changed the workflow to modify region day cycle.Vadim ProductEngine
Was: Press "Save" after editing the region day cycle in the Day Cycle Editor. Now: - Press "Save" in the Day Cycle Editor. - Open Region / Estate -> Environment tab. - Select the region day cycle. - Press "Apply".
2011-06-02STORM-1253 WIP Debugging stuff.Vadim ProductEngine
2011-06-01STORM-1253 WIP Fixed a couple of typos.Vadim ProductEngine
2011-05-26STORM-1284 FIXED Changes to region environment are now visible immediately.Vadim ProductEngine
Pressing "Apply" sends the settings update to server. Pressing "Cancel" reverts to current region settings.
2011-05-26STORM-1253 WIP Implemented switching between multiple day cycles (locally ↵Vadim ProductEngine
and region-wide).
2011-05-24STORM-1256 WIP Added perpetual indicator for progress of applying changes.Vadim ProductEngine
2011-05-24STORM-1256 WIP Improvements to region enviroment settings editing.Vadim ProductEngine
* Enable/disable controls according to the region permissions. * Update controls when region settings update comes.
2011-05-23STORM-1256 WIP Implemented editing region environment settings via the ↵Vadim ProductEngine
Region/Estate floater.
2011-05-17STORM-1244 FIXED Environment Settings floater implementation.Seth ProductEngine
2011-05-17STORM-1245 WIP Restored environment settings interpolation on region crossing.Vadim ProductEngine
Also got rid of duplicated region environment settings requests.
2011-05-16STORM-1245 WIP Implement loading and applying region environment settings.Vadim ProductEngine
2011-05-16STORM-1245 WIP Reimplementing management of local presets according to the ↵Vadim ProductEngine
new spec. User environment preferences are now persistent. TODO: Implement applying region env. settings.
2011-04-07STORM-1142 ADDITIONAL_COMMIT Debugging improvements.Vadim ProductEngine
2011-03-31STORM-1126 WIP Windlight Estate Settings integration: pass 6Vadim ProductEngine
* Made it possible to update a region sky preset with the Save button. * Fixed resetting day cycle when you start editing region environment settings. * Fixed: if you press "Cancel Changes" in the region envitonment settings and then choose to resume editing in the confirmation dialog, you won't be able to cancel your changes later.
2011-03-31STORM-1126 WIP Windlight Estate Settings integration: pass 5Vadim ProductEngine
* Added "Apply Local to Region" button to the region terrain setttings panel. * Fixed previewing presets via a combomox in the Advanced Sky Editor floater.
2011-03-31STORM-1126 WIP Windlight Estate Settings integration: pass 4Vadim ProductEngine
Changes: * Fixed incorrect way to pass parameters to notifications. * Fixed crashes in the Advanced Sky floater and the Region Terrain panel. * Fixed initialization and multiple instantiation of the Day Cycle floater (that might lead to incorrect behavior). * Fixed and re-enabled committing env. settings changes to region. * Fixed day cycle and sky settings being sent as empty arrays and therefore not passing validation on server. It is now possible to change region environment settings. * Added debug messages.
2010-09-27STORM-1126 WIP Windlight Estate Settings port from 1.23: first pass at ↵Nyx (Neal Orman)
merging in windlight estate settings to viewer-dev codebase. not built, not tested. Probably needs a bunch of fixes to be able to be integrated. (resubmitted by Vadim ProductEngine)