summaryrefslogtreecommitdiff
path: root/indra/newview/llattachmentsmgr.h
AgeCommit message (Collapse)Author
2016-09-15MAINT-5232: Normalize LLSingleton subclasses.Nat Goodspeed
A shocking number of LLSingleton subclasses had public constructors -- and in several instances, were being explicitly instantiated independently of the LLSingleton machinery. This breaks the new LLSingleton dependency-tracking machinery. It seems only fair that if you say you want an LLSingleton, there should only be ONE INSTANCE! Introduce LLSINGLETON() and LLSINGLETON_EMPTY_CTOR() macros. These handle the friend class LLSingleton<whatevah>; and explicitly declare a private nullary constructor. To try to enforce the LLSINGLETON() convention, introduce a new pure virtual LLSingleton method you_must_use_LLSINGLETON_macro() which is, as you might suspect, defined by the macro. If you declare an LLSingleton subclass without using LLSINGLETON() or LLSINGLETON_EMPTY_CTOR() in the class body, you can't instantiate the subclass for lack of a you_must_use_LLSINGLETON_macro() implementation -- which will hopefully remind the coder. Trawl through ALL LLSingleton subclass definitions, sprinkling in LLSINGLETON() or LLSINGLETON_EMPTY_CTOR() as appropriate. Remove all explicit constructor declarations, public or private, along with relevant 'friend class LLSingleton<myself>' declarations. Where destructors are declared, move them into private section as well. Where the constructor was inline but nontrivial, move out of class body. Fix several LLSingleton abuses revealed by making ctors/dtors private: LLGlobalEconomy was both an LLSingleton and the base class for LLRegionEconomy, a non-LLSingleton. (Therefore every LLRegionEconomy instance contained another instance of the LLGlobalEconomy "singleton.") Extract LLBaseEconomy; LLGlobalEconomy is now a trivial subclass of that. LLRegionEconomy, as you might suspect, now derives from LLBaseEconomy. LLToolGrab, an LLSingleton, was also explicitly instantiated by LLToolCompGun's constructor. Extract LLToolGrabBase, explicitly instantiated, with trivial subclass LLToolGrab, the LLSingleton instance. (WARNING: LLToolGrabBase methods have an unnerving tendency to go after LLToolGrab::getInstance(). I DO NOT KNOW what should be the relationship between the instance in LLToolCompGun and the LLToolGrab singleton instance.) LLGridManager declared a variant constructor accepting (const std::string&), with the comment: // initialize with an explicity grid file for testing. As there is no evidence of this being called from anywhere, delete it. LLChicletBar's constructor accepted an optional (const LLSD&). As the LLSD parameter wasn't used, and as there is no evidence of it being passed from anywhere, delete the parameter. LLViewerWindow::shutdownViews() was checking LLNavigationBar:: instanceExists(), then deleting its getInstance() pointer -- leaving a dangling LLSingleton instance pointer, a land mine if any subsequent code should attempt to reference it. Use deleteSingleton() instead. ~LLAppViewer() was calling LLViewerEventRecorder::instance() and then explicitly calling ~LLViewerEventRecorder() on that instance -- leaving the LLSingleton instance pointer pointing to an allocated-but-destroyed instance. Use deleteSingleton() instead.
2016-03-07merge DRTVWR-398 build cleanup fixesOz Linden
2015-11-10remove execute permission from many files that should not have itOz Linden
2015-09-21MAINT-5570 limiting exposure of attachment managerandreykproductengine
2015-09-17MAINT-5570 [QuickGraphics] Visual complexity notifications are confusing.andreykproductengine
2015-04-22MAINT-4653 WIP, DRTVWR-397 WIP - log output to file now includes tags. ↵Brad Payne (Vir Linden)
Request max 5 attachments per idle loop to reduce sim-side failures seen when requesting large numbers.
2015-04-10MAINT-5070 WIP, MAINT-4409 WIP - try to clean up invalid COF links under ↵Brad Payne (Vir Linden)
certain circumstances.
2015-04-09MAINT-5069 WIP, MAINT-5071 WIP - handle dropping objects and attaching from ↵Brad Payne (Vir Linden)
ground. WIP on better tracking of attachment requests via various message in LLSelectMgr.
2015-03-31DRTVWR-397 WIP - logging updates and fixesBrad Payne (Vir Linden)
2015-03-20DRTVWR-397 WIP - logging for detach requests and unexpected detaches ↵Brad Payne (Vir Linden)
(presumably server-initiated)
2015-03-19MAINT-4917 WIP - comments and bug fixes for batching up COF link requests ↵Brad Payne (Vir Linden)
after attachments added.
2015-03-18MAINT-4917 WIP - Attachment deferred bulk COF linking WIPBrad Payne (Vir Linden)
2015-02-24MAINT-4917 WIP - batch COF link request before batch attachment request. ↵Brad Payne (Vir Linden)
Should only generate one bake request.
2013-03-29Update Mac and Windows breakpad builds to latestGraham Madarasz
2010-09-01VWR-22695 FIXED Adding attachments messaging is inefficientLoren Shih
Single attachment request are now batched up and sent all at once as a single message.