summaryrefslogtreecommitdiff
path: root/indra/newview/llappearancemgr.h
AgeCommit message (Collapse)Author
2016-12-01MAINT-6562 Avatar COF was occasionally failing to update because Not Foundandreykproductengine
2016-11-14Merged in lindenlab/viewer-cleanupAndreyL ProductEngine
2016-09-16Automated merge with ssh://bitbucket.org/lindenlab/viewer-releaseNat Goodspeed
2016-09-15MAINT-5232: Normalize LLSingleton subclasses.Nat Goodspeed
A shocking number of LLSingleton subclasses had public constructors -- and in several instances, were being explicitly instantiated independently of the LLSingleton machinery. This breaks the new LLSingleton dependency-tracking machinery. It seems only fair that if you say you want an LLSingleton, there should only be ONE INSTANCE! Introduce LLSINGLETON() and LLSINGLETON_EMPTY_CTOR() macros. These handle the friend class LLSingleton<whatevah>; and explicitly declare a private nullary constructor. To try to enforce the LLSINGLETON() convention, introduce a new pure virtual LLSingleton method you_must_use_LLSINGLETON_macro() which is, as you might suspect, defined by the macro. If you declare an LLSingleton subclass without using LLSINGLETON() or LLSINGLETON_EMPTY_CTOR() in the class body, you can't instantiate the subclass for lack of a you_must_use_LLSINGLETON_macro() implementation -- which will hopefully remind the coder. Trawl through ALL LLSingleton subclass definitions, sprinkling in LLSINGLETON() or LLSINGLETON_EMPTY_CTOR() as appropriate. Remove all explicit constructor declarations, public or private, along with relevant 'friend class LLSingleton<myself>' declarations. Where destructors are declared, move them into private section as well. Where the constructor was inline but nontrivial, move out of class body. Fix several LLSingleton abuses revealed by making ctors/dtors private: LLGlobalEconomy was both an LLSingleton and the base class for LLRegionEconomy, a non-LLSingleton. (Therefore every LLRegionEconomy instance contained another instance of the LLGlobalEconomy "singleton.") Extract LLBaseEconomy; LLGlobalEconomy is now a trivial subclass of that. LLRegionEconomy, as you might suspect, now derives from LLBaseEconomy. LLToolGrab, an LLSingleton, was also explicitly instantiated by LLToolCompGun's constructor. Extract LLToolGrabBase, explicitly instantiated, with trivial subclass LLToolGrab, the LLSingleton instance. (WARNING: LLToolGrabBase methods have an unnerving tendency to go after LLToolGrab::getInstance(). I DO NOT KNOW what should be the relationship between the instance in LLToolCompGun and the LLToolGrab singleton instance.) LLGridManager declared a variant constructor accepting (const std::string&), with the comment: // initialize with an explicity grid file for testing. As there is no evidence of this being called from anywhere, delete it. LLChicletBar's constructor accepted an optional (const LLSD&). As the LLSD parameter wasn't used, and as there is no evidence of it being passed from anywhere, delete the parameter. LLViewerWindow::shutdownViews() was checking LLNavigationBar:: instanceExists(), then deleting its getInstance() pointer -- leaving a dangling LLSingleton instance pointer, a land mine if any subsequent code should attempt to reference it. Use deleteSingleton() instead. ~LLAppViewer() was calling LLViewerEventRecorder::instance() and then explicitly calling ~LLViewerEventRecorder() on that instance -- leaving the LLSingleton instance pointer pointing to an allocated-but-destroyed instance. Use deleteSingleton() instead.
2016-09-15Merged in lindenlab/viewer-releaseAndreyL ProductEngine
2016-09-05MAINT-6685 [VOB] Outfit Image from an Outfit Gallery disappears after ↵Mnikolenko Productengine
editing outfit
2016-08-30MAINT-5232: Remove unreferenced mInFlightCounter.Nat Goodspeed
This fixes fatal warnings.
2016-08-16Merge VOB with 4.0.8-releasepavelkproductengine
2016-07-18MAINT-6520 Add a way to see worn temp attachments.Mnikolenko Productengine
2016-06-08MAINT-6473 Request for Drag & Drop functionality for adding images to Outfit ↵Mnikolenko Productengine
Folders
2016-05-24MAINT-6403: Updated a couple comments and dropped a couple warning levels ↵Rider Linden
back down to DEBUG.
2016-05-23MAINT-6403: in the case of a version mismatch between the viewer's local ↵Rider Linden
accounting and the AIS reported. Override with the AIS version. simplify the appearance update code to account for new versioning. Fix spelling of descendant
2016-05-06merge 4.0.4-release and MAINT-5974Oz Linden
2016-04-13MAINT-6305: Serialize the AIS calls by reducing the queue size to 1, move ↵Rider Linden
the bake request out of the AIS queue.
2016-04-12Added exponential timeout to retry, protect against attempting to downgrade ↵Rider Linden
the COF version in the bake request.
2016-04-04merge with 4.0.3-releaseOz Linden
2016-03-03MAINT-5693: Move avatar update into the AIS coprocedure pool.Rider Linden
2016-02-25MAINT-5693: Some bake requests were getting lost. If a bake request is made ↵Rider Linden
while another one is outstanding rather than launch the new one, set a flag and remake the request with new data.
2015-11-10remove execute permission from many files that should not have itOz Linden
2015-10-06MAINT-5693: Consolidated the avatar appearance request into a coroutine. If ↵Rider Linden
the request fails because of a stale COF, then rerequest with the corrected one.
2015-07-15MergeRider Linden
2015-06-08Added a way to pass a policy Id to the coroadapter.Rider Linden
Changed language, appearance, and maturity to conform to use the adapter rather than the SDHandler
2015-06-08MergeRider Linden
2015-05-27mergeBrad Payne (Vir Linden)
2015-04-16Fix for bad syntax that displeased linux more than windows.Brad Payne (Vir Linden)
2015-04-16MAINT-5082 WIP, MAINT-5083 WIP - consolidate COF link creation calls during ↵Brad Payne (Vir Linden)
mass add of wearables/objects
2015-03-26Adding llagentlanguage to new LLCore::Http code moved some of ↵Rider Linden
llappearancemgr handling into llAgent.
2015-03-26Fix line endings on appearancemgr and added LLCore::Http to llAgent.Rider Linden
2015-03-25Some slight reorganization and removal of some dead code.Rider Linden
2015-03-25gcc remove extra qualification on decrementInFlightCounter static.Rider Linden
2015-03-25Replace appearance responder with new LLCore Appearance Handler.Rider Linden
Prep for some slight cleanup of the code. Add AP_AVATAR Policy
2015-03-18MAINT-4917 WIP - Attachment deferred bulk COF linking WIPBrad Payne (Vir Linden)
2015-03-13MAINT-4980 WIP - moved canAddWearables() to LLAppearanceMgrBrad Payne (Vir Linden)
2015-03-05SL-103 WIP - viewer enforces wearable limits based on total articles of ↵Brad Payne (Vir Linden)
clothing rather than per-type limit. Limit is artificially low for testing, will bump before release.
2015-02-27DRTVWR-397 - removed duplicate functionBrad Payne (Vir Linden)
2015-02-20MAINT-4653, DRTVWR-397 WIP - more code for tracking attachment operations, ↵Brad Payne (Vir Linden)
smarter handling of multiple requests.
2014-05-13sunshine-external merge WIPBrad Payne (Vir Linden)
2013-12-05mergeBrad Payne (Vir Linden)
2013-11-11Automated merge with http://bitbucket.org/lindenlab/viewer-releaseRichard Linden
2013-09-11SH-4422 WIP - avoid redundant calls to updateAppearanceFromCOF() if rezzing ↵Brad Payne (Vir Linden)
an attachment that's already linked in COF
2013-08-29SH-4455 WIP - restrict use of LLWearableHoldingPattern metrics. When ↵Brad Payne (Vir Linden)
changing wearables, bail out if current wearables already match those requested.
2013-10-17SUN-69 MAINT-2258 : temp attachments getting removed improperly. Reviewed ↵simon
by Kelly.
2013-08-09Refactoring link creation calls in preparation for adding AIS v3 hook.Don Kjer
2013-07-03SH-4305 WIP - unlock and set loading complete after base outfit saved.Brad Payne (Vir Linden)
2013-07-03SH-4226 WIP - try to be smarter about when to send appearance update ↵Brad Payne (Vir Linden)
requests, removed many redundant calls
2013-06-27SH-4300 WIP - removed outfit autopopulateBrad Payne (Vir Linden)
2013-06-27SH-4300 WIP - added order validationBrad Payne (Vir Linden)
2013-06-26SH-4300 WIP - set wearable ordering desc fields in slammer during ↵Brad Payne (Vir Linden)
updateCOF(), should need to go item-by-item fairly rarely.
2013-06-26SH-4300 WIP - removed unused update_base_outfit stuff in ↵Brad Payne (Vir Linden)
updateClothingOrderingInfo()
2013-06-26SH-4305 WIP - cleanupBrad Payne (Vir Linden)