summaryrefslogtreecommitdiff
path: root/indra/newview/llappdelegate-objc.mm
AgeCommit message (Collapse)Author
2016-06-30DRTVWR-418: Unify control flow through LLAppViewer across platforms.Nat Goodspeed
The LLApp API used to consist of init(), mainLoop(), cleanup() methods. This makes sense -- but on Mac that structure was being subverted. The method called mainLoop() was in fact being called once per frame. There was initialization code in the method, which (on Mac) needed to be skipped with an already-initialized bool. There was a 'while' loop which (on Mac) needed to be turned into an 'if' instead so the method would return after every frame. Rename LLApp::mainLoop() to frame(). Propagate through subclasses LLAppViewer and LLCrashLogger. Document the fact that frame() returns true to mean "done." (This was always the case, but had to be inferred from the code.) Rename the Mac Objective-C function mainLoop to oneFrame. Rename the C++ free function it calls from runMainLoop() to pumpMainLoop(). Add comments to llappdelegate-objc.mm explaining (inferred) control flow. Change the Linux viewer main() and the Windows viewer WINMAIN() from a single LLAppViewer::mainLoop() call to repeatedly call frame() until it returns true. Move initialization code from the top of LLAppViewer::frame() to the init() method, where it more properly belongs. Remove corresponding mMainLoopInitialized flag (and all references) from LLAppViewer. Remove 'while (! LLApp::isExiting())' (or on Mac, 'if (! LLApp::isExiting())') from LLAppViewer::frame() -- thus unindenting the whole body of the 'while' and causing many lines of apparent change. (Apologies to reviewers.) There are four LLApp states: APP_STATUS_RUNNING, APP_STATUS_QUITTING, APP_STATUS_STOPPED and APP_STATUS_ERROR. Change LLAppViewer::frame() return value from (isExiting()) (QUITTING or ERROR) to (! isRunning()). I do not know under what circumstances the state might transition to STOPPED during a frame() call, but I'm quite sure that if it does, we don't want to call frame() again. We only want a subsequent call if the state is RUNNING. Also rename mainLoop() method in LLCrashLogger subclasses LLCrashLoggerWindows, LLCrashLoggerMac, LLCrashLoggerLinux. Of course it's completely up to the frame() method whether to yield control; none of those in fact do. Honor protocol by returning true (frame() is done), even though each one's main() caller ignores the return value. In fact LLCrashLoggerWindows::mainLoop() wasn't using the return protocol correctly anyway, returning wParam or 0 or 1 -- possibly because the return protocol was never explicitly documented. It should always return true: "I'm done, don't call me again."
2015-11-10remove execute permission from many files that should not have itOz Linden
2014-12-01mergeBrad Payne (Vir Linden)
2014-09-11MAINT-3569 FIXED Handle window hide/unhide and minimize/unminimize events on ↵Mnikolenko ProductEngine
mac.
2014-08-06STORM-2053 - applicationShouldTerminate returns an ↵Cinder Biscuits
NSApplicationTeminateReply, not NSApplicationDelegateReply
2013-11-08MAINT-3155 redux moved reg for URL event handling to WillFinishLaunching ↵Graham Madarasz (Graham Linden)
instead of DidFinishLaunching while laughing at Apple
2013-09-26MAINT-3155 add cocoa equiv for former AppleEventManager shenanigans for ↵Graham Madarasz (Graham Linden)
SLURL handling
2013-06-27Added license headers.Geenz
2013-06-17Moved detecting if we're using a roman-script language to it's own function ↵Geenz
in the application delegate. Also consider the delete and backspace characters to be special cases.
2013-06-17Have showInputWindow hand off input events to the bottom line input window.Geenz
2013-06-17Move logic involving the input window to keyDown. Pass input events to the ↵Geenz
input window from there.
2013-06-17Insert text into the input window when we attempt to insert text without a ↵Geenz
pre-editor. Also handle backspace as a special case when determining if the input window needs to be displayed.
2013-05-13Added IME input window white list.Geenz
2013-04-01First pass at adding a viable replacement for TSM's old UseInputWindow ↵Geenz
method (which is now deprecated with seemingly no Cocoa replacement).
2013-03-27IME support is pretty much finished at this point.Geenz
2013-01-23Readd event handling for application focus.Geenz
2013-01-23Refactor the key input handling to make it easier to filter out keys we ↵Geenz
don't need unicode characters for (such as the arrow keys).
2013-01-08Big change set:Geenz
- LLAppDelegate header relocated to LLWindow. Definition is still present in secondlife-bin (for compatibility reasons when loading a nib). - Return key handling fixed. - Command key now acts the same as the control key by issuing control character codes when the command key is pressed. - We now retrieve the window pointer directly from the app delegate in LLWindow.