Age | Commit message (Collapse) | Author |
|
suppressable is broken
|
|
fixed logic so that ignore consistently means *don't show* the notification
the ignore settings still store "show the notification if true" values
|
|
reverted to old sense where ignore setting of notifications has meaning true=show false=ignore
reviewed by Callum
|
|
|
|
|
|
|
|
|
|
(transplanted from 01d8534678f5613c924a036128addf6b7447c92a)
|
|
/Users/Aimee/Documents/Work/Linden-Lab/Development/viewer/convert/viewer-identity-evolution
|
|
access functions, begin(), end(), etc.
this allows mutation of param block contents, without being able to change number of elements
|
|
|
|
logged in
reviewed by Monroe
|
|
|
|
|
|
variables
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
feeeeling.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Details:
Instead of copying shared pointer, raw pointer was used, that cause crash, since notification responder object was accessed after it was destroyed.
Replaced usage copying of raw pointer instead of copying shared pointer of notification responder object, that should live after notification destroyed.
--HG--
branch : product-engine
|
|
Details:
1 Provided passing necessary is_group parameter to LLPostponedNotification::add<LLPostponedServerObjectNotification> method call;
3 Corrected handling group name in LLPostponedNotification::onCachedNameReceived;
2 Added check on retrieved name from cache name and replacement with fallback value.
reviewed by Vadim Savchuk at https://codereview.productengine.com/secondlife/r/743/
--HG--
branch : product-engine
|
|
|
|
reviewed by Nyx
|
|
Helps with global finds looking for remaining calls to patch.
Reviewed with Leyla.
|
|
Reviewed with Richard
|
|
|
|
notifications.
Utilized old save and load notification code.
Main concern was with notifications that have complex responder - UserGiveItem, ObjectGiveItem. Those responders are object with own fields that need to persist through sessions.
Notifications that should be saved are marked with persist="true" in notifications.xml
Notifications using functor responders are saved automatically.
Notifications using object responders need additional tuning. Responder object should be a) serializable(implement LLNotificationResponderInterface), b) registered with LLResponderRegistry.
At this point following notifications persist through sessions: UserGiveItem, ObjectGiveItem, TeleportOffered, FrienshipOffered.
Reviewed by Mike Antipov - https://codereview.productengine.com/secondlife/r/211/
--HG--
branch : notifications
|
|
history,
* added class for LLPostponedNotification to rpovide possibility postpone adding notification to notifications system till sender avatar name will be received from cache name;
* rolled back changes related to fix of EXT-4779;
* avoided passing avatar id when logging 'Object Return' notification to nearby chat;
eviewed by Vadim Savchuk at https://jira.secondlife.com/browse/EXT-6373
--HG--
branch : product-engine
|
|
Reusable notifications are deleted when user closes IM floater(old - when user closes Viewer).
--HG--
branch : product-engine
|
|
Implemented requested feature - "Resolving offer in the notification toast shouldn't remove offer panel form IM log until IM session is restarted"
--HG--
branch : product-engine
|
|
Added functionality to make Toasts accept multiple user inputs(clicks on option buttons).
--HG--
branch : product-engine
|
|
Checker: UNINIT_CTOR
Function: LLNotificationForm::LLNotificationForm(const LLSD &)
File: /indra/llui/llnotifications.cpp
|
|
Checker: UNINIT_CTOR
Function: LLNotificationTemplate::LLNotificationTemplate()
File: /indra/llui/llnotifications.cpp
|
|
Checker: INVALIDATE_ITERATOR
Function: LLNotifications::getChannel(const std::basic_string<char, std::char_traits<char>, std::allocator<char>>&)
File: /indra/llui/llnotifications.cpp
not a bug.
|
|
I made it about a year and a half ago; Zero found it while reading code. I had added a return value to LLSD::insert(), but a) did it wrong, and b) broke the STL-like semantics of insert(). So I've put insert() back to returning void and created LLSD::with(), which does what my earlier insert() did. The compiler then caught all the cases where insert()'s return value were being used, and I changed those to use with() instead.
|
|
Cuts number of includes of llnotifications.h from 300+ to 40.
|
|
for months, it spams the logs, and it hits the disk.
Discussed with Q, the author.
|
|
|