summaryrefslogtreecommitdiff
path: root/indra/llui/lllayoutstack.cpp
AgeCommit message (Collapse)Author
2020-03-25DRTVWR-494: Defend LLInstanceTracker against multi-thread usage.Nat Goodspeed
The previous implementation went to some effort to crash if anyone attempted to create or destroy an LLInstanceTracker subclass instance during traversal. That restriction is manageable within a single thread, but becomes unworkable if it's possible that a given subclass might be used on more than one thread. Remove LLInstanceTracker::instance_iter, beginInstances(), endInstances(), also key_iter, beginKeys() and endKeys(). Instead, introduce key_snapshot() and instance_snapshot(), the only means of iterating over LLInstanceTracker instances. (These are intended to resemble functions, but in fact the current implementation simply presents the classes.) Iterating over a captured snapshot defends against container modifications during traversal. The term 'snapshot' reminds the coder that a new instance created during traversal will not be considered. To defend against instance deletion during traversal, a snapshot stores std::weak_ptrs which it lazily dereferences, skipping on the fly any that have expired. Dereferencing instance_snapshot::iterator gets you a reference rather than a pointer. Because some use cases want to delete all existing instances, add an instance_snapshot::deleteAll() method that extracts the pointer. Those cases used to require explicitly copying instance pointers into a separate container; instance_snapshot() now takes care of that. It remains the caller's responsibility to ensure that all instances of that LLInstanceTracker subclass were allocated on the heap. Replace unkeyed static LLInstanceTracker::getInstance(T*) -- which returned nullptr if that instance had been destroyed -- with new getWeak() method returning std::weak_ptr<T>. Caller must detect expiration of that weak_ptr. Adjust tests accordingly. Use of std::weak_ptr to detect expired instances requires engaging std::shared_ptr in the constructor. We now store shared_ptrs in the static containers (std::map for keyed, std::set for unkeyed). Make LLInstanceTrackerBase a template parameterized on the type of the static data it manages. For that reason, hoist static data class declarations out of the class definitions to an LLInstanceTrackerStuff namespace. Remove the static atomic sIterationNestDepth and its methods incrementDepth(), decrementDepth() and getDepth(), since they were used only to forbid creation and destruction during traversal. Add a std::mutex to static data. Introduce an internal LockStatic class that locks the mutex while providing a pointer to static data, making that the only way to access the static data. The LLINSTANCETRACKER_DTOR_NOEXCEPT macro goes away because we no longer expect ~LLInstanceTracker() to throw an exception in test programs. That affects LLTrace::StatBase as well as LLInstanceTracker itself. Adapt consumers to the new LLInstanceTracker API.
2019-08-10DRTVWR-493 LLUI to LLParamSingletonandreykproductengine
2019-05-14Mac buildfixAndreyL ProductEngine
2019-02-20SL-1811 Slight chat optimizationandreykproductengine
2015-11-10remove execute permission from many files that should not have itOz Linden
2014-12-10Rename llround(..) to ll_round(..) because of a collision with MS llround ↵callum_linden
(long long round) in VS2013
2013-11-05fixed focus issue on inventoryRichard Linden
2013-10-15renamed TimeBlock to BlockTimerStatHandleRichard Linden
2013-09-09merge with viewer-releaseRichard Linden
2013-09-05changed fast timer over to using macroRichard Linden
another attempt to move mem stat into base class
2013-06-05merge with viewer-releaseRichard Linden
2013-05-22Pull merge from viewer-releaseMerov Linden
2013-04-19merge changes for DRTVWR-294Oz Linden
2013-04-16CHUI-808 FIXED Draggable separator between conversations and message pane is ↵maksymsproductengine
not discoverable: - final solution;
2013-03-29Update Mac and Windows breakpad builds to latestGraham Madarasz
2013-03-18SH-3931 WIP Interesting: Add graphs to visualize scene load metricsRichard Linden
changed LLCriticalDamp to LLSmoothInterpolation and sped up interpolator lookup improvements to stats display of llstatbar added scene load stats floater accessed with ctrl|shift|2
2013-03-14SH-3931 WIP Interesting: Add graphs to visualize scene load metricsRichard Linden
collapsed Orientation enums to all use LLView::EOrientation added ability to display stat bar horizontally
2013-03-11Viewer-chui mergeprep
2012-12-15CHUI-591 FIXED Issues with resizing conversations floatermaksymsproductengine
2012-11-02This does not pertain to a CHUI bug fix but Richard took a look at the ↵Gilbert Gonzales
behavior of the layout stack test and found a mathematical bug that caused panels in a layout stack to jitter as they were resized. Submitting in this branch.
2012-11-02CHUI-472: This is a fix for the following case: When a torn off floater has ↵Gilbert Gonzales
its conversation reduced to the minimum width, once re-docked the conversation does not expand. Solution: Discussed problem with Richard, and I'm submitting the changes required to fix the problem.
2012-10-11Updating linux build to gcc4.6Don Kjer
2012-10-04CHUI-331 FIXED (Resizing conversation list when message panel is collapsed ↵MaximB ProductEngine
does not resize list) *fixed missing parentheses from last push
2012-10-04CHUI-331 FIXED (Resizing conversation list when message panel is collapsed ↵MaximB ProductEngine
does not resize list)
2012-03-06EXP-1767 WIP Received Items panel state does not persist between sessionsRichard Linden
added get/setTargetDim() for managing layout_panel size even if its collapsed/invisible/etc
2012-03-06EXP-1767 WIP Received Items panel state does not persist between sessionsRichard Linden
ensure that layout stack has updated its layout before manually resizing one of its elements (which was causing the manual resize to be stomped on by the newly triggered layout update) made layout stack animation occur even when layout stack not visible (inventory will appear in proper open/closed state) LLView::setShape() now only calls handleReshape() when dimensions change removed extraneous calls to LLLayoutStack::updateClass() so that it should be called only once per frame now, allowing it to limit animation updates to layout stacks to one per frame. fixed rendering glitches arising from reshaping LLFolderView while in the middle of its draw() method
2012-02-08EXP-1767 WIP Received Items panel state does not persist between sessionsRichard Linden
fixed layout stack so programmatic size updates will work correctly
2012-02-02EXP-1858 FIX Received Items panel heading in incorrect positionRichard Linden
didn't account properly for collapsed panels
2012-01-31fixed layout_stack regression resulting in side toolbars being truncatedRichard Linden
2012-01-31 EXP-1851 FIX Crash when trying to resize the bottom sectionsRichard Linden
more layout logic fixes and added renormalization to fractional sizes to eliminate drift
2012-01-30 EXP-1851 WIP Crash when trying to resize the bottom sectionsRichard Linden
fixed layout logic when dealing with invisibile layout_panels
2012-01-19made layoutPanels have constant user_resize and auto_resize attributesRichard Linden
2012-01-19EXP-1824 FIX Received Items panel does not collapse correct when Height of ↵Richard Linden
panel is maximized in Inventory window
2012-01-18Fix a Linux compilation failureMerov Linden
2012-01-18EXP-1812 FIX Cannot resize location bar / favorites in top navigation bar in ↵Richard Linden
viewer
2012-01-17EXP-1809 FIX Buttons in right toolbar clipped and can be out of positionRichard Linden
2012-01-17EXP-1810 FIX Cannot resize Received items panel in Inventory windowRichard Linden
2012-01-17fix for crash in assert when programmatically toggling user resizeRichard Linden
2012-01-17EXP-1758 : Fix crash on login on Mac (bad pointer reference). Might need ↵Merov Linden
more work if the intent was to always get that pointer.
2012-01-16Fix Mac build issueMerov Linden
2012-01-16EXP-1758 WIP Progress spinner not shown during merketplace synch if Merchant ↵Richard Linden
Outbox floater was previously minimized rewrote layout_stack resizing logic to be symmetrical
2011-10-18EXP-1367 FIX Moving in and out of mouselook causes location bar to move downRichard Linden
2011-09-28fix linux buildRichard Nelson
2011-09-27EXP-1258 WIP toggle buttons between icons and icons+text modesRichard Linden
fixed button layout for icon+text layout stack now uses floating point precision to avoid clamping panels to 0
2011-09-20EXP-1228 FIX Create toolbar widget class that displays list of buttons ↵Richard Linden
horizontally or vertically buttons are now centered and sized according to content created floater_test_toolbar.xml to test
2011-09-06EXP-1196 FIX Fix param block template orderingRichard Linden
changed ordering of template loading relative to constructor setting of params moved a lot of constructor-set params to template files reviewed by Leslie
2011-07-26EXP-1021 FIX Position of web content browser dictates position of profile ↵Richard Nelson
panel - profile panel position changes do not persist EXP-1030 FIX Search button toggle can get out of synch in bottom bar made llinstancetracker::iterator do own nested level management (removing need for separate guard) added support for filename= to floaters can pass in arbitrary window_class to floaters
2011-06-23another gcc fixRichard Linden
2011-06-23Build fix after merge.Leslie Linden
2011-06-23fix for gcc buildRichard Linden