summaryrefslogtreecommitdiff
path: root/indra/llui/llfloater.cpp
AgeCommit message (Collapse)Author
2010-09-20STORM-192 ADDITIONAL FIX Fixed crash on pressing Ctrl+Shift+W (which closes ↵Vadim Savchuk
all floaters). The crash was introduced by my previous fix of this ticket in changeset 8ceebd3612f0. The problem was that, suprisingly, even invisible (faded) toasts were destroyed when you hit Ctrl_Shift+W, however they were still referenced by the toast pool, so the references were invalidated. The easiest fix would be to remove all references to the toast being destroyed, no matter is it visible or not. However, then we'd have to search for each destroyed toast in the pool, which is slow. Besides, removing toasts from the pool compromises the whole idea of pooling (which was introduced to speed up creation of new toasts). Another possible fix is not to destroy any nearby chat toasts when user hits Ctrl+Shift+W. That would save us from any crashes at a price of changing existing behaviour (the toasts will remain visible). So I went for a third option: when closing all floaters, skip invisible ones. Then there won't be attempts to destroy invisible (pooled) toasts, so the crash won't happen, and we don't seem to change any existing behavior. However I'm not 100% sure of the latter statement, so the fix requires extensive testing.
2010-09-13STORM-101 FIXED Moved floater settings (rect, visibility, docked state) to ↵Vadim Savchuk
account-specific XML file. The settings are now stored to settings_per_account.xml. This change affects all floaters having save_rect/save_visibility/save_dock_state params set to "true", not just detached sidebar tabs as the ticket requests.
2010-09-09CID-508Tofu Linden
Checker: UNINIT_CTOR Function: LLFloaterView::LLFloaterView(const LLFloaterView::Params &) File: /indra/llui/llfloater.cpp
2010-09-03VWR-21127 FIXED Implemented restoring sidebar tabs that were detached in ↵Vadim Savchuk
previous session. It is now possible to detach some sidebar tabs, exit the viewer, login again and see those tabs still detached. Also fixed incorrect saving of tabs dimensions implemented in the previous commit (766d6e749836). Reviewed by Sergey Litovchuk
2010-09-01VWR-21127 WIP Implemented saving position and dimensions of detached sidebar ↵Vadim Savchuk
tabs. Reviewed by Sergey Litovchuk.
2010-08-24Backed out changeset c3d41f18ce2bTofu Linden
back-out the back-out for this branch. yay.
2010-08-24Backed out changeset a62bf7c0af21Tofu Linden
Backing out this merge that I pushed (prematurely) to the wrong place.
2010-08-24merge heads. whew.Tofu Linden
2010-08-13Change license from GPL to LGPL (version 2.1)Oz Linden
2010-08-12EXT-7951 FIXED (Mini-Location panel appearance design issues)Paul Guslisty
- Added callback on show\hide Mini Location Panel event. This callback sets proper initial minimized position depending on state (shown or hidded) Mini Location Panel. Also callback shifts vertically already minimized floaters so that they don't overlap Mini Location Panel Reviewed by Vadim Savchuk at https://codereview.productengine.com/secondlife/r/851/ --HG-- branch : product-engine
2010-07-20EXT-8458 FIXED ensure that static pointer to instance of ↵Mike Antipov
LLPanelStandStopFlying is always valid to prevent crash. Consequences of root cause: Static pointer to LLPanelStandStopFlying in LLPanelStandStopFlying::getInstance() becomes invalid when the instance of the LLPanelStandStopFlying is a child of floater while it is destroying. Next usage of that pointed cause a crash. Root Cause: 1. LLFloater::closeFloater sets floater invisible and marks floater as "dead" but does not destroy it. 2. But that instance was still in LLFloaterReg map. It is removed in LLFloater's destructor. 3. So it was possible on low fps to get "dead" floater with LLFloaterReg, LLFloaterMove in this case. 4. Then LLMortician deleted floater instance shown on previous step. Call of setVisible(false) from the LLFloater's destructor does not call overridden LLFloaterMove's method (which is expected behavior.) So, child panel LLPanelStandStopFlying was not re-parented to Main View and was destroyed with LLFloaterMove. That leaded to the "Top Reason" described above. FIX: 1. Ensure that LLPanelStandStopFlying is not a child of LLFloaterMove on its destroying. 2. Synchronized removing of a floater instance from the LLFloaterReg when it is marked as "dead". Note: both changes fixes this bug independently, but I included both of them into result patch to avoid similar but in the future. Reviewed by Vadim Savchuk at https://codereview.productengine.com/secondlife/r/781/ --HG-- branch : product-engine
2010-06-22EXT-7729 WIP LLWARNS: Tons of "Making dummy class..." warnings on startupRichard Linden
reviewed by Leyla
2010-06-14EXT-7664 FIX Titles of all floaters are shifted downRichard Nelson
2010-06-07EXT-7700 - Script error window shows [All Scripts] for every tabRichard Nelson
reviewed by Mani
2010-06-01EXT-7590 FIX Modal alerts obscure any modal alerts that they spawnRichard Linden
the toast logic to set visibility on dialogs in reverse order was bringing older modal dialogs to the front
2010-05-29EXT-7557 - About Second Life > Credits does not open with scrollbar all the ↵Richard Linden
way at the top also made floaters not update title label every time they are resized
2010-05-18EXT-7398 FIXED negative top/bottom coordinates do the wrong thing with ↵Richard Linden
topleft layout reviewed by Leyla
2010-04-13PE merge from PE's viewer-trunkTofu Linden
2010-04-12(slightly hairy) merge from viewer-hotfixTofu Linden
2010-04-08EXT-6733(normal) - Long title of voice popup notification is displayed out ↵Dmitry Zaporozhan
of window. Fixed code calculating title buttons rectangle, LLRect::isValid() does not indicate uninitialized rectangle, as a result rectangle was not properly initialized and had negative width. Fixed title width. Reviewed by Mike Antipov - https://codereview.productengine.com/secondlife/r/194/ --HG-- branch : product-engine
2010-04-08EXT-5849 - crash in LLView::drawChildren()Richard Linden
added logging to help track down cause
2010-03-25Fixed low bug EXT-6444 - Long notecard titles continue under Locked and Help ↵Dmitry Zaporozhan
icons on title bar. Changed the way floater title is reshaped. Calculations takes title buttons into account instead of using hardcoded values. --HG-- branch : product-engine
2010-03-24Manual merge from default branch.Vadim Savchuk
Resolved conflicts in llpanellandmarks.cpp. --HG-- branch : product-engine
2010-03-23Merge from viewer-2-0Tofu Linden
2010-03-23Fixed low bug EXT-4081 (Lag Meter: Ctrl+W does not close floater)Paul Guslisty
- Set 'Close' text of tooltip instead of 'Close (Ctrl+W)' for close button of chrome floaters Reviewed by Mike Antipov --HG-- branch : product-engine
2010-03-11fix line ending in file llfloater.cppangela
2010-03-11mergeangela
2010-03-10EXT-6295 - Cannot log in with new account, TOS dialog does not loadRichard Nelson
reviewed by Mani
2010-03-09EXT-4684 Beacons are not shown when beacons floater is minimizedangela
2010-03-05mergeRichard Linden
2010-03-03WIP - replace top ctrl with LLPopupViewRichard Linden
2010-03-03fix for EXT-4469 Fast Timers: Minimize and Close icons do not workYchebotarev ProductEngine
--HG-- branch : product-engine
2010-03-02initial work changing topctrl to popup layerRichard Nelson
2010-02-19Merge from default branchMike Antipov
--HG-- branch : product-engine
2010-02-18Automated merge with ssh://hg.lindenlab.com/q/viewer-hotfixMonroe Linden
2010-02-18fixed line endingsrichard
2010-02-18EXT-5535 - Resize handles will move floater when reaching minimum sizerichard
2010-02-18Mergerichard
2010-02-18Backed out changeset: 744bd7c535farichard
2010-02-18Fixed low bug EXT-5225 - Local chat doesn't go translucent when loses focus.Dmitry Zaporozhan
Added customizable background image overlay color to control background transparency. Default overlay color is White, as before. --HG-- branch : product-engine
2010-02-17Moved shadow drawing code from draw to separate function(drawShadow) to make ↵Dmitry Zaporozhan
this code reusable. --HG-- branch : product-engine
2010-02-02no ticket. Removing the hack from llfloater.This code is dangerous. It ↵Denis Serdjuk
involved losing of topctrl in focusmgr and can cause strange bugs and problems. --HG-- branch : product-engine
2010-02-02fix for normal EXT-4810 Block hot-keys in mouse-look modeYchebotarev ProductEngine
--HG-- branch : product-engine
2010-01-28CID-343Tofu Linden
Checker: UNINIT_CTOR Function: LLFloaterView::LLFloaterView(const LLUICtrl::Params &) File: /indra/llui/llfloater.cpp
2010-01-21fix for normal EXT-4035 Old sidepanel tab's text remains highlighted when ↵Ychebotarev ProductEngine
switching to inventory sidepanel tab --HG-- branch : product-engine
2010-01-20fix for major EXT-4414 Floaters can be expanded over bottom barYchebotarev ProductEngine
left<->top...:) --HG-- branch : product-engine
2010-01-19mergeYchebotarev ProductEngine
--HG-- branch : product-engine
2010-01-19working on floaters rezise-position bugs: EXT-4414, EXT-2625Ychebotarev ProductEngine
--HG-- branch : product-engine
2010-01-15EXT-4233: Display "?" button on torn-off floaters.Lynx Linden
This involved tracking the torn-off state of a floater, which we apparently weren't doing before. Also, making sure that we update the title bar buttons when the floater changes torn-off state.
2010-01-14EXT-4233: Don't show help button on tear-off floaters.Lynx Linden
The script error floater may be the only floater left that uses the old-style tearoff functionality, but at least it should behave a little better now in terms of help "?" buttons.