Age | Commit message (Collapse) | Author |
|
LLPanelStandStopFlying is always valid to prevent crash.
Consequences of root cause:
Static pointer to LLPanelStandStopFlying in LLPanelStandStopFlying::getInstance() becomes invalid when the instance of the LLPanelStandStopFlying is a child of floater while it is destroying.
Next usage of that pointed cause a crash.
Root Cause:
1. LLFloater::closeFloater sets floater invisible and marks floater as "dead" but does not destroy it.
2. But that instance was still in LLFloaterReg map. It is removed in LLFloater's destructor.
3. So it was possible on low fps to get "dead" floater with LLFloaterReg, LLFloaterMove in this case.
4. Then LLMortician deleted floater instance shown on previous step.
Call of setVisible(false) from the LLFloater's destructor does not call overridden LLFloaterMove's method (which is expected behavior.)
So, child panel LLPanelStandStopFlying was not re-parented to Main View and was destroyed with LLFloaterMove.
That leaded to the "Top Reason" described above.
FIX:
1. Ensure that LLPanelStandStopFlying is not a child of LLFloaterMove on its destroying.
2. Synchronized removing of a floater instance from the LLFloaterReg when it is marked as "dead".
Note: both changes fixes this bug independently, but I included both of them into result patch to avoid similar but in the future.
Reviewed by Vadim Savchuk at https://codereview.productengine.com/secondlife/r/781/
--HG--
branch : product-engine
|
|
reviewed by Leyla
|
|
|
|
reviewed by Mani
|
|
the toast logic to set visibility on dialogs in reverse order was bringing older modal dialogs to the front
|
|
way at the top
also made floaters not update title label every time they are resized
|
|
topleft layout
reviewed by Leyla
|
|
|
|
|
|
of window.
Fixed code calculating title buttons rectangle, LLRect::isValid() does not indicate uninitialized rectangle, as a result rectangle was not properly initialized and had negative width.
Fixed title width.
Reviewed by Mike Antipov - https://codereview.productengine.com/secondlife/r/194/
--HG--
branch : product-engine
|
|
added logging to help track down cause
|
|
icons on title bar.
Changed the way floater title is reshaped. Calculations takes title buttons into account instead of using hardcoded values.
--HG--
branch : product-engine
|
|
Resolved conflicts in llpanellandmarks.cpp.
--HG--
branch : product-engine
|
|
|
|
- Set 'Close' text of tooltip instead of 'Close (Ctrl+W)' for close button of chrome floaters
Reviewed by Mike Antipov
--HG--
branch : product-engine
|
|
|
|
|
|
reviewed by Mani
|
|
|
|
|
|
|
|
--HG--
branch : product-engine
|
|
|
|
--HG--
branch : product-engine
|
|
|
|
|
|
|
|
|
|
|
|
Added customizable background image overlay color to control background transparency. Default overlay color is White, as before.
--HG--
branch : product-engine
|
|
this code reusable.
--HG--
branch : product-engine
|
|
involved losing of topctrl in focusmgr and can cause strange bugs and problems.
--HG--
branch : product-engine
|
|
--HG--
branch : product-engine
|
|
Checker: UNINIT_CTOR
Function: LLFloaterView::LLFloaterView(const LLUICtrl::Params &)
File: /indra/llui/llfloater.cpp
|
|
switching to inventory sidepanel tab
--HG--
branch : product-engine
|
|
left<->top...:)
--HG--
branch : product-engine
|
|
--HG--
branch : product-engine
|
|
--HG--
branch : product-engine
|
|
This involved tracking the torn-off state of a floater, which we
apparently weren't doing before. Also, making sure that we update
the title bar buttons when the floater changes torn-off state.
|
|
The script error floater may be the only floater left that uses the
old-style tearoff functionality, but at least it should behave a
little better now in terms of help "?" buttons.
|
|
reviewed by Leyla
|
|
|
|
|
|
made focus be passed to game area in case floater can't hold focus;
--HG--
branch : product-engine
|
|
|
|
for XUI-based params
|
|
|
|
|
|
Code to set default floater position to top-left was causing incorrect
floater height computation when floater XML specified a bottom coordinate.
Reviewed with Callum.
|
|
--HG--
branch : product-engine
|