summaryrefslogtreecommitdiff
path: root/indra/llui/llcommandmanager.h
AgeCommit message (Collapse)Author
2016-09-15MAINT-5232: Normalize LLSingleton subclasses.Nat Goodspeed
A shocking number of LLSingleton subclasses had public constructors -- and in several instances, were being explicitly instantiated independently of the LLSingleton machinery. This breaks the new LLSingleton dependency-tracking machinery. It seems only fair that if you say you want an LLSingleton, there should only be ONE INSTANCE! Introduce LLSINGLETON() and LLSINGLETON_EMPTY_CTOR() macros. These handle the friend class LLSingleton<whatevah>; and explicitly declare a private nullary constructor. To try to enforce the LLSINGLETON() convention, introduce a new pure virtual LLSingleton method you_must_use_LLSINGLETON_macro() which is, as you might suspect, defined by the macro. If you declare an LLSingleton subclass without using LLSINGLETON() or LLSINGLETON_EMPTY_CTOR() in the class body, you can't instantiate the subclass for lack of a you_must_use_LLSINGLETON_macro() implementation -- which will hopefully remind the coder. Trawl through ALL LLSingleton subclass definitions, sprinkling in LLSINGLETON() or LLSINGLETON_EMPTY_CTOR() as appropriate. Remove all explicit constructor declarations, public or private, along with relevant 'friend class LLSingleton<myself>' declarations. Where destructors are declared, move them into private section as well. Where the constructor was inline but nontrivial, move out of class body. Fix several LLSingleton abuses revealed by making ctors/dtors private: LLGlobalEconomy was both an LLSingleton and the base class for LLRegionEconomy, a non-LLSingleton. (Therefore every LLRegionEconomy instance contained another instance of the LLGlobalEconomy "singleton.") Extract LLBaseEconomy; LLGlobalEconomy is now a trivial subclass of that. LLRegionEconomy, as you might suspect, now derives from LLBaseEconomy. LLToolGrab, an LLSingleton, was also explicitly instantiated by LLToolCompGun's constructor. Extract LLToolGrabBase, explicitly instantiated, with trivial subclass LLToolGrab, the LLSingleton instance. (WARNING: LLToolGrabBase methods have an unnerving tendency to go after LLToolGrab::getInstance(). I DO NOT KNOW what should be the relationship between the instance in LLToolCompGun and the LLToolGrab singleton instance.) LLGridManager declared a variant constructor accepting (const std::string&), with the comment: // initialize with an explicity grid file for testing. As there is no evidence of this being called from anywhere, delete it. LLChicletBar's constructor accepted an optional (const LLSD&). As the LLSD parameter wasn't used, and as there is no evidence of it being passed from anywhere, delete the parameter. LLViewerWindow::shutdownViews() was checking LLNavigationBar:: instanceExists(), then deleting its getInstance() pointer -- leaving a dangling LLSingleton instance pointer, a land mine if any subsequent code should attempt to reference it. Use deleteSingleton() instead. ~LLAppViewer() was calling LLViewerEventRecorder::instance() and then explicitly calling ~LLViewerEventRecorder() on that instance -- leaving the LLSingleton instance pointer pointing to an allocated-but-destroyed instance. Use deleteSingleton() instead.
2015-11-10remove execute permission from many files that should not have itOz Linden
2014-10-05DD-170 : Handle 503 answer from SLM and added a MARKET_MERCHANT_NOT_MIGRATED ↵Merov Linden
state to the UI, showing only the relevant UI to the user (i.e. Merchant Outbox or Marketplace Listings).
2013-11-26remove excessively complex fixes for MAINT-2914 and MAINT-3142Oz Linden
2013-10-04MAINT-3142 FIXED Hover over highlighting broken in Second Life 3.6.6 (280797)dmitrykproductengine
2013-08-02MAINT-2914 FIXED Mousing over UI elements does not make them light updmitry
2013-03-29Update Mac and Windows breakpad builds to latestGraham Madarasz
2012-11-21CHUI-531 FIXED Poor fps in CHUI viewermaksymsproductengine
2011-10-20* Moved the name storage on the LLCommandId back to the LLCommand itself.Leslie Linden
Reviewed by Merov.
2011-10-11Added 'execute_stop_function' command parameter to handle mouse down/up ↵Leslie Linden
actions on toolbar buttons
2011-10-10EXP-1300 : Simplify and clean up of the DaD which now doesn't duplicate the ↵Merov Linden
dragged tool.
2011-10-09EXP-1300 : drop tool animation. First shot. Works but still a bit hacky and ↵Merov Linden
with some bugs (tools can be duplicated at times).
2011-10-05EXP-1286 : Clean-up the mess I added to llcommandmanager. All CommandId now ↵Merov Linden
have a trusted UUID which is the base for indexing and comparison.
2011-10-05Fix for typo that broke build.callum
2011-10-05EXP-1202 : pull from richard/viewer-experience-fuiMerov Linden
2011-10-05EXP-1286 : DaD is functional though has bugs... Working on it...Merov Linden
2011-10-04* Modified commands to add functions for is_enabled, is_running and is_starting,Leslie Linden
currently not hooked to any functionality.
2011-09-28EXP-1205 PROGRESS -- As a User, I want a toybox which will contain all ↵Leslie Linden
buttons that I can d&d into the toolbars EXP-1233 FIX -- Populate the toybox floater window with all FUI toolbar buttons indicated as such in the "commands.xml" definition. EXP-1267 FIX -- Enable/disable buttons in the toybox * Hooked up button callbacks to the toolbar buttons * Fixed toybox button enable/disable to function properly and live update as buttons change states. * Removed the toybox toolbar background image Reviewed by Leyla
2011-09-27EXP-1257 : Save toolbar settings in a per user toolbars.xml fileMerov Linden
2011-09-26initial support for switching between icons only and icons + textRichard Nelson
2011-09-26EXP-1202 : Fix Mac compilation failureMerov Linden
2011-09-26EXP-1205 PROGRESS -- As a User, I want a toybox which will contain all ↵Leslie Linden
buttons that I can d&d into the toolbars * Command buttons are now enabled/disabled in toybox based on whether or not the LLToolBarView has them anywhere. * Commands now have argument to specify whether or not they should be in the toybox. * LLCommandId is now used a universal reference for commands. Reviewed by Richard.
2011-09-22EXP-1205 PROGRESS -- As a User, I want a toybox which will contain all ↵Leslie Linden
buttons that I can d&d into the toolbars EXP-1233 PROGRESS -- Populate the toybox floater window with all FUI toolbar buttons EXP-1236 FIX -- The toybox floater should remember its position for the user * Basic addCommand function to the LLToolBar. Need proper implementation. * Added map for faster lookup of commands * Toybox now adds commands to its toolbar for basic button setup Reviewed by Richard.
2011-09-21EXP-1205 PROGRESS -- As a User, I want a toybox which will contain all ↵Leslie Linden
buttons that I can d&d into the toolbars EXP-1232 FIX -- Create class to load and hold all of the command meta data associated with FUI toolbar actions * Added basic commands.xml file to define FUI-related toolbar actions. For now a basic "avatar" and "places" button are defined. * Added basic command manager to parse and hold strings that define potential toolbar command actions. * Broke out a separate floater function as a placeholder for the 3-state toolbar floater toggling. * LLUI::initClass now parses the new commands.xml file Reviewed by Richard.