viewer.git - Megapahit's fork of the Second Life viewer.

Age	Commit message (Collapse)	Author
2011-12-23	Automated merge with ssh://hg.lindenlab.com/nat/viewer-leap	Nat Goodspeed

2011-12-23	Make pipe-management logic more robust.	Nat Goodspeed
	Previous logic was vulnerable to the case in which both pipes reached EOF in the same loop iteration. Now we use std::list instead of std::vector, allowing us to iterate and delete with a single pass.
2011-12-22	Comment out lookup table used only by commented-out code.	Nat Goodspeed
	Otherwise the unreferenced declaration causes a fatal warning.
2011-12-22	Never call apr_proc_wait() inside child_status_callback().	Nat Goodspeed
	Quiet the temporary child_status_callback() output. Add a bit of diagnostic info if apr_proc_wait() returns anything but APR_CHILD_DONE.
2011-12-22	Add child_status_callback() function and arrange to call periodically.	Nat Goodspeed
	At least on OS X 10.7, a call to apr_proc_wait(APR_NOWAIT) in fact seems to block the caller. So instead of polling apr_proc_wait(), use APR callback mechanism (apr_proc_other_child_register() et al.) and poll that using apr_proc_other_child_refresh_all(). Evidently this polls the underlying system waitpid(), but the internal call seems to better support nonblocking. On arrival in the child_status_callback(APR_OC_REASON_DEATH) call, though, apr_proc_wait() produces ECHILD: the child process in question has already been reaped. The OS-encoded wait() status does get passed to the callback, but then we have to use OS-dependent macros to tease apart voluntary termination vs. killed by signal... a bit of a hole in APR's abstraction layer. Wrap ensure_equals() calls with a macro to explain which comparison failed.
2011-12-21	Tweak llprocesslauncher_test.cpp to run properly on Windows.	Nat Goodspeed
	Fix EOL issues: "\r\n" vs. "\n". On Windows, requesting a read in nonblocking mode can produce EAGAIN instead of EWOULDBLOCK.
2011-12-21	Change llprocesslauncher_test.cpp eyeballing to program verification.	Nat Goodspeed
	That is, where before we just flung stuff to stdout with the expectation that a human user would verify, replace with assertions in the test code itself. Quiet previous noise on stdout. Introduce a temp script file that produces output on both stdout and stderr, with sleep() calls so we predictably have to wait for it. Track and then verify the history of our interaction with the child process, noting especially EWOULDBLOCK attempts.
2011-12-21	Fix llprocesslauncher_test.cpp to work on Windows.	Nat Goodspeed

2011-12-21	Add unit-test module for LLProcessLauncher.	Nat Goodspeed
	As always with llcommon, this is expressed as an "integration test" to sidestep a circular dependency: the llcommon build depends on its unit tests, but all our unit tests depend on llcommon. Initial test code is more for human verification than automated verification: does APR's child-process management in fact support nonblocking operations?