summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-04-12Merge pull request #1198 from secondlife/signal/xzSignal Linden
CI: adopt xz compression, actions/*-artifact@v4
2024-04-12Merge pull request #1211 from secondlife/marchcat/x-mergeAndrey Lihatskiy
Release (Maint W) -> Maint X merge
2024-04-12viewer-private#226 Unhandled PngError throws application into a loopAndrey Kleshchev
png_read_info triggered a PngError, LLAppViewer::frame() handled it instead of LLPngWrapper::readPng, and since status didn't change viewer tried to decode image again and again and again.
2024-04-12Merge branch 'main' into marchcat/x-mergeAndrey Lihatskiy
# Conflicts: # indra/llimage/llimageworker.cpp # indra/llimage/llimageworker.h # indra/newview/llcontrolavatar.cpp # indra/newview/llfloaterprofiletexture.cpp # indra/newview/lloutfitslist.cpp # indra/newview/lloutfitslist.h # indra/newview/lltexturefetch.cpp
2024-04-12Fix ASAN errors from LLVector4a::memcpyNonAliased16Nicky
Found by running with -fsanitze=thread Suggestion to avoid accessing invalid memory: In both cases memory will be allocated by can be accessed beyond bounds. In LLPolyMesh it can be off by at least one (+x%2). Though I am not even sure if even in best case it always will be a multiple of 16. In LLViewerJointMesh::updateFaceData the code tries to account for padding by, but the allocation in LLPolyMeshSharedData::allocateVertexData is done without any padding. Thus the sizes must not match. Replacing the calls with memcpy as a quick fix to see if the error goes away fixed address sanitzer complaining. It is up to debate if memcpy is a good replacement. LLVector4a::memcpyNonAliased16 was invented for performance. But on the other hand one could argue that nowadays every stdlib maintainer will very heavily optmize functions like memcpy themselves and could take advantage of CPU features the old LL implementation does not take into account. AVX comes to mind. In any case did I not measure any of this.
2024-04-12Chore/cmake pretty up (#1205)Nicky Dasmijn
* - Add an option to with ASAN - Fix GCC -Werror option. * - find_program should not set REQUIRED if per logic a fallback to ld.bfd is fine - cmake idiomatic is to test Variables without dereferencing them * Add -Wno-unknown-warning-option for clang or it will complain about some GCC only options ``` /home/runner/work/viewer/viewer/indra/llcommon/llsdutil.cpp:39:32: error: unknown warning group '-Wstringop-truncation', ignored [-Werror,-Wunknown-warning-option] #pragma GCC diagnostic ignored "-Wstringop-truncation" // It's actually okay what happens here ```
2024-04-11secondlife/viewer#1184: Stop making terrain textures undeletableCosmic Linden
2024-04-11CI: adopt xz compressionBennett Goble
Move towards packaging artifacts with xz, which offers higher compression ratios and faster decode time.
2024-04-11Merge pull request #1197 from secondlife/signal/rm-incredibuild.pySignal Linden
Remove unused fix-incredibuild.py
2024-04-11Merge pull request #1095 from secondlife/signal/rm-buildparamsSignal Linden
Remove BuildParams
2024-04-11Merge pull request #1199 from secondlife/signal/rm-py-matrixSignal Linden
CI: Remove python-version from matrix
2024-04-11Restore the fix for #945 (lost during merge #1178)Andrey Lihatskiy
2024-04-11CI: Remove python-version from matrixBennett Goble
Drop python version from matrix configuration as it's always 3.11.
2024-04-10Merge pull request #1196 from secondlife/signal/moldSignal Linden
Add LINK_WITH_MOLD option
2024-04-11Make sure items get removed from maps before the item itself gets destroyed,Nicky
Otherwise the viewer ends with a dangling pointer in the map
2024-04-10Remove unused fix-incredibuild.pyBennett Goble
2024-04-10Linux: build with clang, link with moldBennett Goble
2024-04-10Merge pull request #1194 from secondlife/v-1163cosmic-linden
viewer#1163: Avoid terrain texture memory leak
2024-04-10viewer#1163: Unboost terrain textures when done to allow deletionCosmic Linden
2024-04-10Multiple fixes for mirrors. (#1192)Jonathan "Geenz" Goodman
* #1064 Fix for mirror surfaces going black when the roughness is set too high. * #1130 Fix for the user's avatar not appearing in mouselook in a mirror. * #1059 Disable mirrors on low settings per the feature table. * #860 Modify the settings UI to better reflect that we only have two AA modes: off and FXAA. * #1191 Add some settings for mirrors in preferences. * #1185 Add support for runtime mirror resolution changing. Useful for quality settings, and auto-FPS.
2024-04-10Fix linux some shader errors when running under WSL, related to ↵Brad Linden
secondlife/viewer#1149 (#1170)
2024-04-10Fix mac build (#1182)RunitaiLinden
* Fix mac build * Mac build take 2 * Mac build take 3
2024-04-10Fix BUG-225288: Detaching stops unrelated animationsSalad Dais
This is to do with misunderstandings related to how .find() works with multimaps. .find() will, in fact, return an iterator to the first iterator it finds, and will iterate through all elements in the multimap when incremented, not just items with the same key. Change code working with animation sources to be aware of this fact, so unrelated animation sources do not have their animations stopped.
2024-04-10Merge pull request #1178 from secondlife/marchcat/b-mergeAndrey Lihatskiy
Release (Maint W) -> Maint B merge
2024-04-10Merge pull request #1179 from secondlife/marchcat/y-mergeAndrey Lihatskiy
Release (Maint W) -> Maint YZ merge
2024-04-10Merge branch 'main' into marchcat/y-mergeAndrey Lihatskiy
# Conflicts: # autobuild.xml # indra/llcommon/llsys.cpp
2024-04-10Merge branch 'main' into marchcat/b-mergeAndrey Lihatskiy
# Conflicts: # indra/llrender/llgl.cpp # indra/newview/lloutfitslist.cpp
2024-04-09#1126 gltf scene import prototype (#1172)RunitaiLinden
* #1126 GLTF Scene import initial prototype (working geometry import for some assets) * #1126 WIP -- Expand support for more vertex formats, PoC material import, shadow support, scale support * #1126 move GLTF implementation to newview/gltf * #1126 Refactor attribute loading to be less copy/pasta for each combination of types * #1126 Partially working object selection. Ability to have multiple scenes at once. Helpful message on how to use the preview button. * #1126 Add bounding box debug display and untangle GLTF raycast from LLVOVolume raycast * #1126 Working raycast on GLTF scenes. * #1126 Remove some #pragma optimize offs
2024-04-09Merge remote-tracking branch 'origin/main' into release/materials_featuretteBrad Linden
2024-04-09Increment viewer version to 7.1.6Nat Goodspeed
following promotion of secondlife/viewer #690
2024-04-09Merge pull request #1162 from secondlife/v-759cosmic-linden
secondlife/viewer#759: Fix minimap loading for 2k PBR materials
2024-04-09Update Linux media handling (#1146)Nicky Dasmijn
* Enable CEF browser for Linux * Disable the update for Linux, we don't have that one right now * Update build_linux.yaml We need libpulse-dev for volume_catcher Linux * Add linux_volum_catcher* files * Enable OpenAL for Linux-ReleaseOS * Linux: Update OpenAL * Update SDL2 * Add libsndio-dev to the dependencies. * Update CEF to an official LL version * Remove dupe of emoji_shortcodes * Reording autobuild does because it can and wants to * Linux: Disable NDOF for the time being. After updating the ndof 3P needs to be rebuilt and we do not have a fresh one from LL yet. Forcefully undefine LIB_NDOF, it gets defined in the build variables no matter if it is safe to define. * Remove wrestling with mutliarch and LIBGL_DRIVERS_PATH * Remove tcmalloc snippet, tcmalloc is a very faint bad dream of the past * Putting out a warning this viewer ran on a x64 arch and then suggesting to install 32 bit compat packages makes no sense at all * CEF resources need to be in lib * It;'s okay to warn about missing plugins * Linux: CEF keyboard handling * Remove old gstreamer 0.10 implementation * Linux DSO loading always had been very peculiar due to macro magic. At least now it is peculiar shared magic with only one implementation. * Remove -fPIC. We get that one from LL_BUILD * /proc/cpuinfo is not reliable to detrmine the max CPU clock. Try to determine this by reading "/sys/devices/system/cpu/cpu0/cpufreq/cpuinfo_max_freq". Only if this fails go back to /proc/cpuinfo * Cleanup * Cleanup common linker and compiler flags, make it more obvious which flags are for which OS/compiler * Switch to correct plugin file * Install libpulse-dev for volume catcher. * And the runner needs libsndio-dev as well. * check for runner.os=='linux'. matrix.os is the full name of the image (limux-large).
2024-04-08Linux GHA builds (#1147)Nicky Dasmijn
* Linux GHA builds Add Ubuntu 22.04 runner and Linux dependencies Do not even try to touch ReleaseFS for Linux yet (this needs KDU, Havok, FMOD) * Lets play a game of 'guess the havok source url' * Move to linux-large runner. * ReleaseOS used OpenAL, not fmod studio (which otherwise is the default) * - Correction for Linux build dir - HAVOK / CrashReporting wrestling. HAVOK is always turned on, even for OS builds Turn this off for Linux-ReleaseOS Same with crashreporting, we need it off for now * Add missing brace * When doing a GHA build pack right into RUNNER_TEMP and then signal the created archive as our "viewer_app" * Upload Linux-ReleaseOS after build * - Need to use os.path.join and not hyst join - set_github_output_path can be called unconditionally * Remove Linux GHA build example.
2024-04-08Some fixes to linux builds (#1144)AiraYumi
* compile flag cleanup for linux * rollback indra/llcommon/llprofiler.h * use 3p fltk package * fix build gcc 13 (dangling-pointer)
2024-04-08triage#163 'Create folder from selected' misbehaves in marketplaceAndrey Kleshchev
Marketplace deliberately doesn't allow creating folders and the "New folder from selected" is a way of creating a new folder then moving selected items inside, therefore shouldn't be allowed.
2024-04-08secondlife/viewer#759: Fix minimap loading for 2k PBR materials, and ↵Cosmic Linden
probably other odd cases
2024-04-05Linux viewer (ReleaseOS) resurrection (#1099)Nicky Dasmijn
Co-authored-by: AiraYumi <aira.youme@airanyumi.net>
2024-04-03Merge pull request #1133 from secondlife/v-773cosmic-linden
secondlife/viewer#773: Improve documentation for RenderTerrainPBREnabled
2024-04-03secondlife/viewer#773: Improve test plan for PBR terrain feature flagCosmic Linden
2024-04-03secondlife/viewer#773: Amend dev setting description for RenderTerrainPBREnabledCosmic Linden
2024-04-03viewer#1114 Expose max impostors setting in basic graphics preferencesAndrey Kleshchev
2024-04-02#1116 HDRI preview enhancements (#1119)RunitaiLinden
Don't split sky in radiance and irradiance maps Allow for applying HDRI sky to only irradiance map Allow for showing entire EEP sky (clouds and all) when split is set to zero
2024-04-02#854 Fix for skies that shouldn't be auto-adjusted getting auto-adjusted. ↵RunitaiLinden
(#1115)
2024-04-02https://github.com/secondlife/jira-archive-internal/issues/71062 Fix for ↵RunitaiLinden
avatar not responding to keyboard inputs when not visible (#1113)
2024-04-02Merge pull request #1106 from ↵Guru
secondlife/guru/viewer-925-missing-simple-smile-emoji secondlife/viewer#925 Missing simple :smile emoji
2024-04-02Fix wrong reverts from #958Andrey Lihatskiy
2024-04-02Revert "Do not automatically close issues (#929)"Andrey Lihatskiy
This reverts commit 52945758c479c403f86026f36276d7d805b87af3.
2024-04-02Revert "Make signing and symbol posting jobs conditional on secrets."Andrey Lihatskiy
This reverts commit beea0c55dd68a1584300a02333f8be9ffcac0476.
2024-04-02Revert "Enclose 'if:' expressions in ${{ ... }}."Andrey Lihatskiy
This reverts commit f738df6c147a84c17f28b8326c5bc1eb54e4519f.
2024-04-02Revert "To test for presence of secrets, set environment variables."Andrey Lihatskiy
This reverts commit c83d93becdee899736a121cbb8eae5c0c9d37c09.