| Age | Commit message (Collapse) | Author |
|---|
|
Noticed later that the bottom scrollbar stepper was still slightly cut-off. Reduce list height again by 3.
|
|
Adding NearMeRange slider caused avatar at the bottom of the nearby list to be cut off. Fix by reducing height.
|
|
Turns out it's not necessarily pulled by some other dependencies
on a fresh Arch installation.
|
|
|
|
instead of blank. The coords are hidden too, but the Party numbers
are still shown, for consistency with TPVs' implementations.
|
|
now that we don't need the user to authorise Discord SDK to have
any access to the user's friends list, etc. (which are Discord
Relationships related, and not needed just for Rich Presence).
|
|
Thank you Signal Linden for the pointer from https://discord.com/developers/docs/social-sdk/classdiscordpp_1_1Client.html#af0a85e30f2b3d8a0b502fd23744ee58e
"Note: On Desktop, rich presence can be set before calling Client::Connect, but it will be cleared if the Client connects. When Client is not connected, this sets the rich presence in the current user's Discord client when available."
This lead me to setting the Application ID here https://discord.com/developers/docs/social-sdk/classdiscordpp_1_1Client.html#ad452335c06b28be0406dab824acccc49 in place of setting it on
https://discord.com/developers/docs/social-sdk/classdiscordpp_1_1AuthorizationArgs.html which would lead Authorize, GetToken, UpdateToken, Connect, and so on.
This means we don't even need the SecAPI saveCredential, loadCredential and deleteCredential parts now.
|
|
Add "m" after the NearMeRange slider distance.
|
|
Add slider allowing users to adjust NearMeRange
|
|
Use NearMeRange to minimize difference with SLv
|
|
Full (user) name should suffice for the chat log, as it's the one
that is more of a reference anyway instead of display name.
The other avatar's display name is still displayed on the header
anyway. Seems like display names have higher chance of being empty,
that we would miss it being logged/notified because of that.
Also, now that we've optimised the avatars' positions' retrieval,
the numbers can come later after some avatar arrives, that getting
the position using the avatar's ID as the key would result in zero.
In that case, rather than reporting wrong distances (like 403996.2),
it's better to just skip distance information (it shouldn't matter
that much anyway).
|
|
by not having extra calls to getAvatars.
The avatars' positions member had to be moved to an object that is
accessible from VOAvatar too, and that would be the global Agent.
It makes sense too, that it's the object that keeps the positions
of other agents. It even has a section for positions too.
|
|
by not having extra calls to getAvatars, by avoiding unnecessary
function overhead which actually make it possible to share some
iterative code, and by piggybacking updateNearbyList and
updateArrivalTime which is already done periodically though the
range had to be lengthened to match nearby list range which is
MPVNearMeRange instead of SLv's NearMeRange. Minimise differences
from SLv too (arrival time really doesn't need to be updated
*every* second.. every 5 seconds is just okay).
|
|
No need to check setting for the status change callback one,
because getting there would need to be connected to Discord first,
which in turn needs the integration to be enabled first.
|
|
|
|
The State field (region & coords) is updated well enough without it
now.
|
|
by saving it to a static global string for reuse.
|
|
so we don't have to make any extra getAvatars calls just for this,
as it's pricy in crowds, and we'll just be piggybacking
`updateSpeakerList` and `updateNearbyList`.
|
|
plus delay saving Discord credentials to only after the access
token is successfully updated on Discord, and try to disconnect
from Discord when the integration gets disabled regardless whether
there are credentials to delete or not and whether there's an
access token to revoke or not.
|
|
As suggested by Andrey Kleshchev. They likely can get pricey so
they need to be visible in the profiler.
|
|
as suggested by Andrey Kleshchev, anticipating external factors
such as user moving settings from another PC.
|
|
As suggested by Andrey Kleschev.
getBOOL and getF32 are expensive, so using `static LLCachedControl<>`
is the way to do it in llappviewer.cpp.
|
|
Time elapses right after viewer launch even before login.
Plus parameter name change in header to make it the same as in
implementation.
|
|
Add option to show/hide avatar name in privacy panel & connect rich presense directly to llappviewer.cpp
|
|
so when the user enables the integration after being logged in,
the init can show the name and location right away.
|
|
By setting CurrentSize to the number of people within chat radius,
and MaxSize to the number of people within (MP's) near range.
|
|
Avatar name cache can be used right away upon login now after I
moved the update call to the end of PRECACHE section in llstartup.
|
|
I had to find a spot in source code where it doesn't cause a crash
(it did in LLAgent::setRegion), but I'm not removing the one in
llstartup.cpp because on login, the one in llviewermessage.cpp
gets only the placeholder coords (10, 10, 10).
|
|
I was going to use LLAgentUI::buildLocationString but there's no
location format that shows only region and coords without having
to have the parcel name empty, so I copied buildLocationString
implementation in the case of LOCATION_FORMAT_NO_MATURITY but when
the parcel name is empty.
I had to make updateDiscordActivity check agent's ID and the
existence of agent avatar pointer first before trying to set
Activity Details or State, cause I like the "Show location" button
be checkable not only after online when both the ID & pointer will
have existed. I think this way is simpler than programmatically
enabling the "Show location" button after the user is logged in.
I put a trigger to Activity update somewhere after the user is
logged in for now, not yet after a TP.
The elapsed time gets reset whenever Activity is updated for now,
but I'll try to make elapsed time extended instead.
No Party for now, because I couldn't find a way to make a Party
shown without showing its CurrentSize (I could still get away not
showing its MaxSize by setting it to 0), so the State (location)
is shown above the elapsed time, not on the right of it.
I'll try to figure out to get some representative numbers for its
CurrentSize & MaxSize next.
Also no privacy on hiding the username for now, until the UI is
ready.
|
|
Now the access token is saved the way passwords are saved, but
without a username, so we can have some persistence without having
to implement an OAuth2 backend server cause we would have to store
those tokens there anyway still and that would even require more
disclosure that the user token gets saved on a server, and it's
just simpler to not go that way. Discord Social SDK doesn't have
to have a helper for sending code to a custom server anyway, that
we would have to have some asynchronous HTTP requestor ready.
Show location check button gets enabled only when Discord
integration is enabled, though it's not functioning yet.
|
|
and minimise difference from SL main.
|
|
Add tab and checkboxes for discord social SDK integration options to panel_preferences_privacy.xml
|
|
The doFrame is the one called over and over again, so running the
Discord callbacks from there shouldn't have one extra function
overhead, while running the Discord initialisation is only once so
it's much more okay to have the extra function overhead there.
|
|
and reindent the appearance manager functions to call to match
how they will be placed on the combining macro.
|
|
Copying from LLEditTakeOff implementation in llviewermenu.cpp.
|
|
Per specification, the folder must be directly under "#RLV" for
this to work, hence not using the shared folder ID retrieval macro.
|
|
|
|
|
|
Copied from llwindowwin32.cpp.
|
|
for libcef.so. On a minimal system, those two wouldn't be pulled
automatically by some other package(s).
|
|
Tested on Debian Asahi so far, will try on Fedora Asahi next.
I had to trace this down, setting Logging Level to Debug, and comparing
SecondLife.log with a successful login on Linux x86-64.
At first setWeight() in LLViewerVisualParam::setInfo seemed to be
avoiding a crash too when commented out, but turns out it's still okay
when re-enabled.
|
|
When WebRTC was compiled with the viewer, we got this:
Fatal error in: ../webrtc/src/media/engine/adm_helpers.cc, line 39
last system error: 88
Check failed: 0 == adm->Init() (0 vs. -1)
Failed to initialize the ADM.
This commit hasn't included the additional preprocessor macro for the
platform in indra/newview/llvoiceclient.cpp yet, because there's no such
macro yet to distinguish such distro from any other GNU/Linux distro.
|
|
This reverts commit a8dfeed4632aad0233ff08d1efd950b620fd1be7.
|
|
|
|
previously unintentionally left out from commit 829e4
|
|
Make downstepper better match upstepper
|
|
Download DiscordSocialSdk-1.4.9649.zip
https://discord.com/developers/applications/1393451183741599796/social-sdk/downloads
to your ~/Downloads folder.
Add -DUSE_DISCORD:BOOL=ON to your cmake line.
The authorisation is triggered by selecting Help > Discord Social.
It seems that the user will need to do this every time they want Rich
Presence support on the viewer while using Discord.
The Discord app is still set to be a public client in the OAuth2 tab,
I'm going to try to make it work with the app set to be a confidential
client, next.
All Discord-related code are contained within one file, llstartup.cpp,
and other classes access it through some opaque layer, static functions,
otherwise we'd get these "duplicate symbol" linking errors.
|
|
See f4e04a3e7bac42a8cb18e9c70b67bf97ce020d8c
|
|
Variant of default skin with gold buttons & tabs
|
|
A minimal one. It would still work even when the path leading to
the right name of the end folder is wrong, but since scripts would
likely be trying to get path components from issuing @getinv
commands beforehand instead of inserting random names, we'll
perfect this implementation later.
|
