Age | Commit message (Collapse) | Author |
|
Removed useless sending notification "CapsKeyOn" since it doesn't fit actual design;
reviewed by Vadim Savchuk https://codereview.productengine.com/secondlife/r/277/
--HG--
branch : product-engine
|
|
--HG--
branch : product-engine
|
|
(transplanted from 19036fc277d88c364e957019a66b4cdf4cce8b53)
|
|
take them in a diamond pattern instead of all in a line. this also slightly simplifies(?) the shader.
(transplanted from 7b334c22ece4e98565c5d182690ab9ca4c2526c6)
|
|
--HG--
branch : product-engine
|
|
"my outfits" tab in top-level appearance sidebar (tier 1)
llui:
- Setting container panel for accordion tab control to dynamically add tabs to accordions.
- Added method to dynamically remove accordion tabs.
- Added LLIconCtrl image setter.
newview:
- Class LLOutfitsList - a list of agents's outfits from "My Outfits" inventory category which represents each outfit by an accordion tab with a list of items inside it.
- Class LLWearableItemsList - a list of wearable items used in each accordion tab of "My Outfits" tab.
- Class LLInventoryItemsList - a base class for LLWearableItemsList that represents inventory items by panels in LLFlatListView.
- Class LLPanelInventoryItem - inventory item representation for a flat list. Item icon is set according to item type.
- Class LLInventoryCategoriesObserver - an observer used in LLOutfitsList for monitoring changes to "My Outfits" inventory category and updating outfits accordion tabs and list of items for each outfit.
Known issues:
- Only first outfit tab is displayed in "My Outfits" until this tab is expanded.
- Bottom bar buttons and filter field not functioning for "My Outfits" tab since LLOutfitsList still doesn't support selection, filtering and sorting.
- "My Outfits" and "Wearing" tabs of "Appearance" side panel might need a common interface to use LLOutfitsList and LLinventoryPanel as tabs in LLPanelOutfitsInventory or "Wearing" tab should be replaces with LLOutfitsList class object i.e. a flat list.
On review - https://codereview.productengine.com/secondlife/r/285/
--HG--
branch : product-engine
|
|
notifications.
Utilized old save and load notification code.
Main concern was with notifications that have complex responder - UserGiveItem, ObjectGiveItem. Those responders are object with own fields that need to persist through sessions.
Notifications that should be saved are marked with persist="true" in notifications.xml
Notifications using functor responders are saved automatically.
Notifications using object responders need additional tuning. Responder object should be a) serializable(implement LLNotificationResponderInterface), b) registered with LLResponderRegistry.
At this point following notifications persist through sessions: UserGiveItem, ObjectGiveItem, TeleportOffered, FrienshipOffered.
Reviewed by Mike Antipov - https://codereview.productengine.com/secondlife/r/211/
--HG--
branch : notifications
|
|
Increased IM control panel width by nine pixels to avoid truncation in all languages(longest are Spanish and German).
Also updated IM floater width(by nine pixels) to avoid any possible truncation.
Reviewed by Mike Antipov - https://codereview.productengine.com/secondlife/r/252/
--HG--
branch : product-engine
|
|
Problem:
"Profile" button is visible when viewing current agent place info and remote parcel info.
Solution:
Hide "Profile" button when we are viewing place profile. Updated "Profile" button visibility condition. New condition hides the button when viewing landmark info, teleport history info, agent place info and remote parcel info.
Bug introduced in changeset 11252 : c5b3adc89f28 (EXT-6605 (No profile verb button on Places panel))
Reviewed by Mike Antipov - https://codereview.productengine.com/secondlife/r/274/
--HG--
branch : product-engine
|
|
the button and respective code were removed.
Reviewed by Vadim Savchuk at https://codereview.productengine.com/secondlife/r/283/.
--HG--
branch : product-engine
|
|
|
|
|
|
This is also sprinkled with asserts so we can see which of the NULL tests are - or aren't - needed, if it's really so important to skip them.
(transplanted from 66851d9c86b7ec5155b6c3950e2971d0d7375826)
|
|
--HG--
branch : product-engine
|
|
to store order information
- COF items get checked for correct ordering when COF is loaded (LLAppearanceMgr::updateAppearanceFromCOF..., LLAppearanceMgr::updateClothingOrderingInfo() ), and also when COF is saved to a new outfit, base outfit.
- wearables are arranged in LLAgentWearables in a proper order
* updateClothingOrderingInfo() [struggling with naming] does integrity checking and updates "invalid" items (items with wrong, gapped descriptions)
* moved LLAgentWearables::makeNewOutfitLinks(...) and LLShowCreatedOutfit to a more natural place (llappearancemgr.cpp), because they use LLAppearanceMgr's methods a lot
* changed link_inventory_item(...), added the "new_description" parameter
Reviewed by Neal Orman at https://codereview.productengine.com/secondlife/r/268/
--HG--
branch : product-engine
|
|
|
|
|
|
after moderator left group call)
Reason: session's Speaker Manager was not updated when voice call ended. Speakers had incorrect voice related state.
Fix: update speakers' state when voice call is finished.
Also VCP now uses LLIMMgr::endCall to perform "Leave Call" action.
Reviewed by Vadim Savchuk at https://codereview.productengine.com/secondlife/r/276/
--HG--
branch : product-engine
|
|
a message suggesting the user try global search.)
Partial implementation of help text in case of empty list when filtered for Nearby and Recent lists of People panel:
* Extracted support implementation of several messages for empty list depend of filtering from LLGroupList to LLFlatListEx
* change inheritence of LLGroupList and LLAvatarList from LLFlatListView to LLFlatListViewEx
* updated panel people to init Nearby & Recent lists with appropriate messages.
--HG--
branch : product-engine
|
|
allowed to edit but changes can not be saved
https://codereview.productengine.com/secondlife/r/281/
vsavchuk
--HG--
branch : product-engine
|
|
|
|
|
|
|
|
it too badly. Sprinkle it with asserts for the sanity checks we've started to skip, see which one (ones?) fires.
(transplanted from 09164f83f03cfa62d0fd8296c810d3e3794cb365)
|
|
This didn't help. I'll try another approach.
(transplanted from ecd9ac6b5a41ab5c816fff8d993b03616076b82a)
|
|
|
|
|
|
|
|
|
|
the delicate branch optimization, BUT there was a real crash there. :/
(transplanted from e13b292907c5c208e0c96de73b80e203412c5c33)
|
|
Function: LLViewerInventoryMoveFromWorldObserver::onAssetAdded(const LLUUID &)
File: /indra/newview/llviewermessage.cpp
|
|
Checker: UNINIT_CTOR
Function: LLInventoryFetchItemsObserver::LLInventoryFetchItemsObserver(const std::vector<LLUUID, std::allocator<LLUUID>> &)
File: /indra/newview/llinventoryobserver.cpp
|
|
Checker: UNINIT_CTOR
Function: LLInventoryFetchComboObserver::LLInventoryFetchComboObserver(const std::vector<LLUUID, std::allocator<LLUUID>> &, const std::vector<LLUUID, std::allocator<LLUUID>> &)
File: /indra/newview/llinventoryobserver.cpp
dead member.
|
|
Checker: DEADCODE
Function: LLAssetStorage::findInStaticVFSAndInvokeCallback(const LLUUID &, LLAssetType::EType, void (*)(LLVFS *, const LLUUID &, LLAssetType::EType, void *, int, int), void *)
File: /indra/llmessage/llassetstorage.cpp
|
|
(transplanted from 06e897a5e9a67c675844993564d006de08501c72)
|
|
(transplanted from 5b6c80049d6e6c0df2396099b865729f21200de8)
|
|
(transplanted from 8476304a30a3c387a722b33743ef3385e85f85a0)
|
|
Contrato tab. Space in blank needed).
Added a space after the colon, so the translatable string is now "Last Modified: ".
Reviewed by Mike: https://codereview.productengine.com/secondlife/r/272/
--HG--
branch : product-engine
|
|
Added text left padding: 5px.
Reviewed by Mike: https://codereview.productengine.com/secondlife/r/271/
--HG--
branch : product-engine
|
|
doesn't work).
Disabled links in the remove pick dialog.
This seems to be the simpliest solution and the same is done e.g. in the teleport confirmation dialog.
I'm not sure how to fix the drop-down menu.
Reviewed by Mike: https://codereview.productengine.com/secondlife/r/269/
--HG--
branch : product-engine
|
|
--HG--
branch : product-engine
|
|
--HG--
branch : product-engine
|
|
--HG--
branch : product-engine
|
|
--HG--
branch : product-engine
|
|
at the top
reply to https://codereview.productengine.com/secondlife/r/267/#review471
add comments to code
--HG--
branch : product-engine
|
|
--HG--
branch : product-engine
|
|
--HG--
branch : product-engine
|
|
- moved the common code (menu stuff handling) from LLIMP2PChiclet, LLAdHocChiclet, LLIMGroupChiclet to their parent LLIMChiclet
- added popup menus to LLInvOfferChiclet and LLScriptChiclet (notice that just the closing menu item was added because these chiclets are not connected with IM sessions.)
Reviewed by Mike Antipov at https://codereview.productengine.com/secondlife/r/254/
--HG--
branch : product-engine
|
|
https://codereview.productengine.com/secondlife/r/267/
mantipov
--HG--
branch : product-engine
|
|
|