summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-07-08SL-18837: Don't use LLDir, use NamedTempFile::temp_path.Nat Goodspeed
Remove llcommon circular dependency on llfilesystem, which doesn't work for this case anyway.
2023-07-07SL-18837: Ditch unreferenced name of caught exceptionNat Goodspeed
2023-07-07SL-18837: Hook in LLDir to allow reading APR log file.Nat Goodspeed
2023-07-07SL-18837: Fix spurious semiNat Goodspeed
2023-07-07SL-18837: Fix "lldir.h" #includeNat Goodspeed
2023-07-07SL-18837: Coax APR to log LLProcess launch attempts; show log file.Nat Goodspeed
2023-07-07SL-18837: Partially revert e933ace, keeping useful tweaks.Nat Goodspeed
Introducing indirection via test_python_script.py did NOT address the "Access is denied" errors on GitHub Windows runners.
2023-07-07SL-18837: Try to bypass Windows perm problem with Python indirection.Nat Goodspeed
2023-07-07SL-18837: Try putting generated Python scripts in RUNNER_TEMP dir.Nat Goodspeed
The claim is that the Windows Python interpreter is integrated somehow with the OS such that a command line that tries to run Python with a script that "looks suspicious" (i.e. in a system temp directory) fails with "Access denied" without even loading the interpreter. At least that theory would explain the "Access denied" errors we've been getting trying to run Python scripts generated into the system temp directory by our integration tests. Our hope is that generating such scripts into the GitHub RUNNER_TEMP directory will work better. As this test is specific to Windows, don't even bother running Mac builds.
2023-07-07SL-18837: Use multi-line GitHub outputs to upload artifacts.Nat Goodspeed
Having observed installer upload failures, I discovered the warning in actions/upload-artifact/README.md about multiple concurrent jobs trying to post the same pathname to the same artifact name. Try to disambiguate artifacts not only for different platforms, but for different jobs running on the same platform. This change also reflects my understanding that an artifact is (effectively) a distinct zip file that can contain multiple uploaded files. Because we'll want to download metadata without having to download enormous installers, create a separate metadata artifact per platform. Similarly, symbol files can get large: use a third distinct artifact for symbol files. But with those artifacts defined, leverage actions/upload-artifact's ability to upload multiple paths to the same artifact. In build.sh, define bash arrays installer, metadata, symbolfile and set up so that, on exit, each is written to a GITHUB_OUTPUT variable with the corresponding name. This involves a little magic to get macOS bash 3 to indirectly access an array. These multi-line output variables are then used to drive the upload-artifact step for each of the defined artifacts.
2023-07-06SL-18837: Ding Dong, 32-bit is dead!Nat Goodspeed
2023-07-06SL-18837: Add addoutput, addarrayoutput functions to build.shNat Goodspeed
and use them instead of codeticket addoutput to pass GitHub xxx_name, xxx_path outputs to build.yaml. Add upload steps to build.yaml to try to upload build products identified in build.sh.
2023-06-30SL-18837: Unset AUTOBUILD_CONFIGURATION.Nat Goodspeed
We suspect that autobuild incorrectly prioritizes AUTOBUILD_CONFIGURATION over its command-line -c switch. The autobuild command to build the TPV package for llphysicsextensions specifies -c Tpv (the configuration in the specified config file), but with AUTOBUILD_CONFIGURATION=Release set, autobuild fails: "ERROR: no configuration for build configuration 'Release' found"
2023-06-30SL-18837: Revert "Install autobuild from source repo, not PyPI."Nat Goodspeed
That doesn't seem to be the distinction between TC builds and GH builds. Instead, we'll try unsetting AUTOBUILD_CONFIGURATION. This reverts commit d62e7039dafe4a49d548225203785eeda0eeb44a.
2023-06-29SL-18837: Install autobuild from source repo, not PyPI.Nat Goodspeed
Bug in autobuild 3.9.2? The TC viewer build can successfully build llphysicsextensions/autobuild-tpv.xml, but the previous GH actions build failed: "no configuration for Release found" despite -c Tpv. The difference seems to be that we used 'pip3 install autobuild' from PyPI, whereas the TC buildscripts setup clones secondlife/autobuild branch v3 and installs from that repo.
2023-06-29SL-18837: Temporarily suppress Windows builds; add finalize functionNat Goodspeed
Also pretend novel arch value MINGW6 is really CYGWIN so we'll recognize it.
2023-06-28SL-18837: Make LLVersionInfo::getBuild() S64 for GitHub run IDs.Nat Goodspeed
2023-06-28SL-18837: Don't try to engage git-hooks explicitly at all.Nat Goodspeed
2023-06-28SL-18837: git-hooks no longer has requirements.txt?Nat Goodspeed
2023-06-28SL-18837: Get buildscripts_support_functions from sling-buildscriptsNat Goodspeed
and use these variants for GitHub builds.
2023-06-28SL-18837: Don't fetch (unmigrated) build-secrets, use GH secrets.Nat Goodspeed
2023-06-28SL-18837: Include actions-build-sh branch in build trigger pushes.Nat Goodspeed
2023-06-27SL-18837: Try doing necessary setup to run viewer's own build.sh.Nat Goodspeed
2023-06-07SL-18837 fix win32 build warning about missing python-version settingBrad Linden
2023-06-07Revert "SL-18837: On Windows, try using py.exe Python stub."Brad Linden
This reverts commit 996ea03d874c714f312c1bfbafda3dddc2172a39.
2023-06-07Attempt to port some build.yaml improvements from DRTVWR-559 over to actions ↵Brad Linden
branch
2023-06-07SL-18837: Try to install llsd in the Python used by py.exeNat Goodspeed
2023-06-07SL-18837: Tell py.exe to use Python 3.9 instead of 3.11Nat Goodspeed
2023-06-07SL-18837: Quote integers used for environment variablesNat Goodspeed
2023-06-07SL-18837: Try setting PY_PYTHON and PYLAUNCHER_DEBUGNat Goodspeed
which should only affect Windows unit tests, but should hopefully improve our chances that Windows unit tests will succeed.
2023-06-07SL-18837: On Windows, try using py.exe Python stub.Nat Goodspeed
2023-06-06SL-18837: Concat path part with / rather than +=.Nat Goodspeed
Using concatenation appends the intended filename to the parent directory name, instead of putting the filename in the parent directory.
2023-06-06SL-18837: On Windows, NamedTempFile must convert from wstringNat Goodspeed
2023-06-06SL-18837: Ditch Boost.Phoenix implicit lambda syntax.Nat Goodspeed
It's cool to be able to write 'arg1 << "stuff" << var ...;' for a lambda accepting a std::ostream reference, but cascading compile errors mean it's no longer worth trying to make that work -- given actual C++ lambdas. Also clean up a lingering BOOST_FOREACH() and a boost::bind() while at it.
2023-06-06SL-18837: Make NamedTempFile name template compatible with Python.Nat Goodspeed
The recommended template uses hyphens; change to underscores to be valid Python temp module names.
2023-06-06SL-18837: NamedTempFile back to std::function, use boost::phoenix <<Nat Goodspeed
It seems the problem addressed by aab769e wasn't some synergy between Boost.Phoenix and Boost.Function, but rather the lack of a Phoenix header file introducing operator<<().
2023-06-05SL-18837: NamedTempFile must still disambiguate string literals.Nat Goodspeed
2023-06-05SL-18837: Make NamedTempFile revert to boost::functionNat Goodspeed
from std::function, since some consumers still use (e.g.) boost::phoenix::placeholders::arg1 to generate an inline callable.
2023-06-05SL-18837: Try giving temp Python scripts a .py extension.Nat Goodspeed
On GitHub Windows Actions runners, we're getting permissions errors trying to tell the Python interpreter to run a NamedTempFile script. Try using NamedExtTempFile to give each such script a .py extension.
2023-06-05SL-18837: Use Boost.Filesystem for NamedTempFile, instead of APR.Nat Goodspeed
2023-06-05SL-18837: Followup to 19e9e8c: global Boost.Bind placeholdersNat Goodspeed
do not need 'using' directive, given BOOST_BIND_GLOBAL_PLACEHOLDERS.
2023-06-05SL-18837: pip install llsd as well as autobuild.Nat Goodspeed
The Python child processes used by llprocess_test.cpp and llleap_test.cpp need the Python llsd module to communicate with the C++ parent process. Also set LOGFAIL and BUGSPLAT_DB environment variables.
2023-06-05SL-18837: Try to silence cascade of Boost.Bind warning messages.Nat Goodspeed
2023-06-05SL-18837: Windows APR 1.7.2 requires MS rpcrt4.dll.Nat Goodspeed
2023-06-05SL-18837: Bump the granularity of WorkQueue timing tests.Nat Goodspeed
On a low-powered GitHub Mac runner, the system doesn't wake up as soon as it should, and we get spurious "too late" errors. Try a bigger time increment.
2023-06-05SL-18837: Update apr_suite to release v1.7.2-4d6fcb2.Nat Goodspeed
2023-06-05SL-18837: #include <array> in several sources that need it.Nat Goodspeed
It seems we're no longer implicitly inheriting <array> from some other [set of] header file[s]. Where we use std::array, bring it in explicitly.
2023-06-05SL-18837: We no longer build Windows apr-iconv -- don't reference.Nat Goodspeed
With VS 2022 on Windows GitHub Actions runners, we can't build apr_suite at all with the upstream .sln / .vcxproj files, so we had to switch to "experimental" CMake support. However there's no CMakeLists.txt file for apr-iconv, so the Windows package omits that library.
2023-06-02SL-18837: Don't include a version-specific Boost.Regex header.Nat Goodspeed
Let the umbrella <regex.hpp> header make that decision.
2023-06-02SL-18837: Boost.Bind _1, _2 placeholders are no longer global.Nat Goodspeed
This was a longstanding complaint: that Boost shouldn't dump the (somewhat mysterious) _1, _2 et al. names into the global namespace. Recent Boost has fixed that, requiring 'using namespace boost::placeholders;' if you want to use them unqualified.