diff options
Diffstat (limited to 'indra')
| -rw-r--r-- | indra/llui/lltextvalidate.cpp | 10 | ||||
| -rw-r--r-- | indra/llui/lltextvalidate.h | 10 | ||||
| -rwxr-xr-x | indra/newview/installers/darwin/apple-notarize.sh | 4 | ||||
| -rwxr-xr-x | indra/newview/installers/darwin/fix_application_icon_position.sh | 2 | ||||
| -rwxr-xr-x | indra/newview/linux_tools/register_secondlifeprotocol.sh | 2 | ||||
| -rw-r--r-- | indra/newview/llfloateremojipicker.cpp | 4 | ||||
| -rw-r--r-- | indra/newview/llfloaterprofiletexture.h | 10 | ||||
| -rw-r--r-- | indra/newview/llinventorygallery.cpp | 48 | ||||
| -rw-r--r-- | indra/newview/llinventorygallerymenu.cpp | 13 | ||||
| -rw-r--r-- | indra/newview/llreflectionmap.cpp | 14 | ||||
| -rw-r--r-- | indra/newview/llsetkeybinddialog.cpp | 10 | ||||
| -rwxr-xr-x | indra/newview/viewer_manifest.py | 24 | 
12 files changed, 76 insertions, 75 deletions
| diff --git a/indra/llui/lltextvalidate.cpp b/indra/llui/lltextvalidate.cpp index f9de6f7386..9a087d8230 100644 --- a/indra/llui/lltextvalidate.cpp +++ b/indra/llui/lltextvalidate.cpp @@ -1,25 +1,25 @@ -/**  +/**   * @file lltextvalidate.cpp   * @brief Text validation helper functions   *   * $LicenseInfo:firstyear=2001&license=viewerlgpl$   * Second Life Viewer Source Code   * Copyright (C) 2010, Linden Research, Inc. - *  + *   * This library is free software; you can redistribute it and/or   * modify it under the terms of the GNU Lesser General Public   * License as published by the Free Software Foundation;   * version 2.1 of the License only. - *  + *   * This library is distributed in the hope that it will be useful,   * but WITHOUT ANY WARRANTY; without even the implied warranty of   * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU   * Lesser General Public License for more details. - *  + *   * You should have received a copy of the GNU Lesser General Public   * License along with this library; if not, write to the Free Software   * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA - *  + *   * Linden Research, Inc., 945 Battery Street, San Francisco, CA  94111  USA   * $/LicenseInfo$   */ diff --git a/indra/llui/lltextvalidate.h b/indra/llui/lltextvalidate.h index 2c2941de7f..a4ff144d82 100644 --- a/indra/llui/lltextvalidate.h +++ b/indra/llui/lltextvalidate.h @@ -1,4 +1,4 @@ -/**  +/**   * @file lltextbase.h   * @author Martin Reddy   * @brief The base class of text box/editor, providing Url handling support @@ -6,21 +6,21 @@   * $LicenseInfo:firstyear=2009&license=viewerlgpl$   * Second Life Viewer Source Code   * Copyright (C) 2010, Linden Research, Inc. - *  + *   * This library is free software; you can redistribute it and/or   * modify it under the terms of the GNU Lesser General Public   * License as published by the Free Software Foundation;   * version 2.1 of the License only. - *  + *   * This library is distributed in the hope that it will be useful,   * but WITHOUT ANY WARRANTY; without even the implied warranty of   * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU   * Lesser General Public License for more details. - *  + *   * You should have received a copy of the GNU Lesser General Public   * License along with this library; if not, write to the Free Software   * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA - *  + *   * Linden Research, Inc., 945 Battery Street, San Francisco, CA  94111  USA   * $/LicenseInfo$   */ diff --git a/indra/newview/installers/darwin/apple-notarize.sh b/indra/newview/installers/darwin/apple-notarize.sh index d90772ec0e..cc4435e614 100755 --- a/indra/newview/installers/darwin/apple-notarize.sh +++ b/indra/newview/installers/darwin/apple-notarize.sh @@ -17,7 +17,7 @@ if [[ -f "$CONFIG_FILE" ]]; then                                     --asc-provider $ASC_PROVIDER \                                     --file "$zip_file" 2>&1)          echo $res -         +          requestUUID=$(echo $res | awk '/RequestUUID/ { print $NF; }')          if [[ -n $requestUUID ]]; then              in_progress=1 @@ -26,7 +26,7 @@ if [[ -f "$CONFIG_FILE" ]]; then                  res=$(xcrun altool --notarization-info "$requestUUID" \                                              --username $USERNAME \                                              --password $PASSWORD 2>&1) -                if [[ $res != *"in progress"* ]]; then  +                if [[ $res != *"in progress"* ]]; then                      in_progress=0                  fi                  echo "." diff --git a/indra/newview/installers/darwin/fix_application_icon_position.sh b/indra/newview/installers/darwin/fix_application_icon_position.sh index 62abcdd07e..841defe96c 100755 --- a/indra/newview/installers/darwin/fix_application_icon_position.sh +++ b/indra/newview/installers/darwin/fix_application_icon_position.sh @@ -1,5 +1,5 @@  #!/bin/bash -# just run this script each time after you change the installer's name to fix the icon misalignment  +# just run this script each time after you change the installer's name to fix the icon misalignment  mydir="$(dirname "$0")"  # If there's more than one DMG in more than one build directory, pick the most  # recent one. diff --git a/indra/newview/linux_tools/register_secondlifeprotocol.sh b/indra/newview/linux_tools/register_secondlifeprotocol.sh index 16e73cb854..33c34d7a76 100755 --- a/indra/newview/linux_tools/register_secondlifeprotocol.sh +++ b/indra/newview/linux_tools/register_secondlifeprotocol.sh @@ -27,7 +27,7 @@ for LLKDECONFIG in kde-config kde4-config; do          LLKDEPROTODIR=`$LLKDECONFIG --path services | cut -d ':' -f 1`          if [ -d "$LLKDEPROTODIR" ]; then              LLKDEPROTOFILE=${LLKDEPROTODIR}/secondlife.protocol -            cat > ${LLKDEPROTOFILE} <<EOF || echo Warning: Did not register secondlife:// handler with KDE: Could not write ${LLKDEPROTOFILE}  +            cat > ${LLKDEPROTOFILE} <<EOF || echo Warning: Did not register secondlife:// handler with KDE: Could not write ${LLKDEPROTOFILE}  [Protocol]  exec=${HANDLER} '%u'  protocol=secondlife diff --git a/indra/newview/llfloateremojipicker.cpp b/indra/newview/llfloateremojipicker.cpp index f1fd4edef2..d38f53eed6 100644 --- a/indra/newview/llfloateremojipicker.cpp +++ b/indra/newview/llfloateremojipicker.cpp @@ -39,9 +39,9 @@  #include "llscrolllistctrl.h"  #include "llscrolllistitem.h"  #include "llsdserialize.h" -#include "lltextbox.h"  +#include "lltextbox.h"  #include "lltrans.h" -#include "llviewerchat.h"  +#include "llviewerchat.h"  namespace {  // The following variables and constants are used for storing the floater state diff --git a/indra/newview/llfloaterprofiletexture.h b/indra/newview/llfloaterprofiletexture.h index 16e2656bc6..cdb1b92ba9 100644 --- a/indra/newview/llfloaterprofiletexture.h +++ b/indra/newview/llfloaterprofiletexture.h @@ -1,25 +1,25 @@ -/**  +/**   * @file llfloaterprofiletexture.h   * @brief LLFloaterProfileTexture class definition   *   * $LicenseInfo:firstyear=2022&license=viewerlgpl$   * Second Life Viewer Source Code   * Copyright (C) 2022, Linden Research, Inc. - *  + *   * This library is free software; you can redistribute it and/or   * modify it under the terms of the GNU Lesser General Public   * License as published by the Free Software Foundation;   * version 2.1 of the License only. - *  + *   * This library is distributed in the hope that it will be useful,   * but WITHOUT ANY WARRANTY; without even the implied warranty of   * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU   * Lesser General Public License for more details. - *  + *   * You should have received a copy of the GNU Lesser General Public   * License along with this library; if not, write to the Free Software   * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA - *  + *   * Linden Research, Inc., 945 Battery Street, San Francisco, CA  94111  USA   * $/LicenseInfo$   */ diff --git a/indra/newview/llinventorygallery.cpp b/indra/newview/llinventorygallery.cpp index 20a4a8f2d6..ba8d99642f 100644 --- a/indra/newview/llinventorygallery.cpp +++ b/indra/newview/llinventorygallery.cpp @@ -187,7 +187,7 @@ LLInventoryGallery::~LLInventoryGallery()          mHiddenItems.pop_back();          panelp->die();      } -     +      if (gInventory.containsObserver(mCategoriesObserver))      { @@ -200,7 +200,7 @@ LLInventoryGallery::~LLInventoryGallery()          gInventory.removeObserver(mThumbnailsObserver);      }      delete mThumbnailsObserver; -     +      LLGestureMgr::instance().removeObserver(mGestureObserver);      delete mGestureObserver;  } @@ -263,7 +263,7 @@ void LLInventoryGallery::updateRootFolder()              updateRemovedItem(mHiddenItems[i]->getUUID());          }          mItemBuildQuery.clear(); -         +          if (gInventory.containsObserver(mCategoriesObserver))          {              gInventory.removeObserver(mCategoriesObserver); @@ -284,7 +284,7 @@ void LLInventoryGallery::updateRootFolder()          mRootChangedSignal();          gInventory.addObserver(mCategoriesObserver); -         +          // Start observing changes in selected category.          mCategoriesObserver->addCategory(mFolderID,              boost::bind(&LLInventoryGallery::refreshList, this, mFolderID)); @@ -294,7 +294,7 @@ void LLInventoryGallery::updateRootFolder()          // the observer will refresh the list as soon as the new items          // arrive.          category->fetch(); -         +          //refreshList(cat_id);          LLInventoryModel::cat_array_t* cat_array;          LLInventoryModel::item_array_t* item_array; @@ -308,7 +308,7 @@ void LLInventoryGallery::updateRootFolder()          {              mItemBuildQuery.insert((*iter)->getUUID());          } -         +          for (LLInventoryModel::item_array_t::const_iterator iter = item_array->begin();              iter != item_array->end();              iter++) @@ -448,7 +448,7 @@ void LLInventoryGallery::reArrangeRows(S32 row_diff)          buf_items.push_back(*it);      }      mHiddenItems.clear(); -     +      mItemsInRow+= row_diff;      updateGalleryWidth(); @@ -458,7 +458,7 @@ void LLInventoryGallery::reArrangeRows(S32 row_diff)      {          return compareGalleryItem(item1, item2, sort_by_date, sort_folders_by_name);      }); -     +      for (std::vector<LLInventoryGalleryItem*>::const_iterator it = buf_items.begin(); it != buf_items.end(); ++it)      {          (*it)->setHidden(false); @@ -735,7 +735,7 @@ void LLInventoryGallery::setFilterSubString(const std::string& string)  {      mFilterSubString = string;      mFilter->setFilterSubString(string); -     +      //reArrangeRows();  } @@ -763,7 +763,7 @@ bool LLInventoryGallery::checkAgainstFilters(LLInventoryGalleryItem* item, const      {          return false;      } -     +      bool hidden = false;      if(mFilter->getFilterCreatorType() == LLInventoryFilter::FILTERCREATOR_SELF) @@ -806,7 +806,7 @@ bool LLInventoryGallery::checkAgainstFilters(LLInventoryGalleryItem* item, const              desc = item->getItemName() + item->getItemNameSuffix();              break;      } -     +      LLStringUtil::toUpper(desc);      std::string cur_filter = filter_substring; @@ -2009,7 +2009,7 @@ void LLInventoryGallery::deleteSelection()          if (item && get_is_item_worn(item))          {              has_worn = true; -            LLWearableType::EType type = item->getWearableType();             +            LLWearableType::EType type = item->getWearableType();              if (type == LLWearableType::WT_SHAPE                  || type == LLWearableType::WT_SKIN                  || type == LLWearableType::WT_HAIR @@ -2385,7 +2385,7 @@ void LLInventoryGallery::onCOFChanged()      LLCommonUtils::computeDifference(vnew, mCOFLinkedItems, vadded, vremoved);      mCOFLinkedItems = vnew; -     +      for (uuid_vec_t::const_iterator iter = vadded.begin();          iter != vadded.end();          ++iter) @@ -2416,7 +2416,7 @@ void LLInventoryGallery::onGesturesChanged()      LLCommonUtils::computeDifference(vnew, mActiveGestures, vadded, vremoved);      mActiveGestures = vnew; -     +      for (uuid_vec_t::const_iterator iter = vadded.begin();          iter != vadded.end();          ++iter) @@ -2594,7 +2594,7 @@ void LLInventoryGallery::startDrag()              ids.push_back(selected_id);          } -        const LLViewerInventoryCategory* cat = gInventory.getCategory(selected_id);         +        const LLViewerInventoryCategory* cat = gInventory.getCategory(selected_id);          if (cat)          {              if (gInventory.isObjectDescendentOf(selected_id, gInventory.getLibraryRootFolderID())) @@ -2672,7 +2672,7 @@ bool LLInventoryGallery::checkAgainstFilterType(const LLUUID& object_id)              break;          }      } -     +      if (filterTypes & LLInventoryFilter::FILTERTYPE_DATE)      {          const U16 HOURS_TO_SECONDS = 3600; @@ -3115,7 +3115,7 @@ void LLThumbnailsObserver::changed(U32 mask)      {          const LLUUID& obj_id = (*iter).first;          LLItemData& data = (*iter).second; -         +          LLInventoryObject* obj = gInventory.getObject(obj_id);          if (!obj)          { @@ -3326,7 +3326,7 @@ bool dragItemIntoFolder(LLUUID folder_id, LLInventoryItem* inv_item, bool drop,          //          //-------------------------------------------------------------------------------- -         +          //--------------------------------------------------------------------------------          // Determine if item can be moved & dropped          // Note: if user_confirm is false, we already went through those accept logic test and can skip them @@ -3365,9 +3365,10 @@ bool dragItemIntoFolder(LLUUID folder_id, LLInventoryItem* inv_item, bool drop,              LLViewerInventoryCategory * dest_folder = cat;              accept = dest_folder->acceptItem(inv_item);          } -         +          LLInventoryPanel* active_panel = LLInventoryPanel::getActiveInventoryPanel(false); +          if (accept && drop)          {              if (inv_item->getType() == LLAssetType::AT_GESTURE @@ -3439,7 +3440,7 @@ bool dragItemIntoFolder(LLUUID folder_id, LLInventoryItem* inv_item, bool drop,                  gInventory.changeItemParent((LLViewerInventoryItem*)inv_item, folder_id, move_is_into_trash);              } -             +              if (move_is_from_marketplacelistings)              {                  // If we move from an active (listed) listing, checks that it's still valid, if not, unlist @@ -3659,7 +3660,6 @@ bool dragCategoryIntoFolder(LLUUID dest_id, LLInventoryCategory* inv_cat,      const LLUUID ¤t_outfit_id = model->findCategoryUUIDForType(LLFolderType::FT_CURRENT_OUTFIT);      const LLUUID &marketplacelistings_id = model->findCategoryUUIDForType(LLFolderType::FT_MARKETPLACE_LISTINGS);      //const LLUUID from_folder_uuid = inv_cat->getParentUUID(); -          const bool move_is_into_current_outfit = (dest_id == current_outfit_id);      const bool move_is_into_marketplacelistings = model->isObjectDescendentOf(dest_id, marketplacelistings_id);      const bool move_is_from_marketplacelistings = model->isObjectDescendentOf(cat_id, marketplacelistings_id); @@ -3768,7 +3768,7 @@ bool dragCategoryIntoFolder(LLUUID dest_id, LLInventoryCategory* inv_cat,              is_movable = false;              // tooltip?          } -         +          LLInventoryModel::cat_array_t descendent_categories;          LLInventoryModel::item_array_t descendent_items;          if (is_movable) @@ -3834,7 +3834,7 @@ bool dragCategoryIntoFolder(LLUUID dest_id, LLInventoryCategory* inv_cat,                  }              }          } -         +          if (is_movable && move_is_into_marketplacelistings)          {              const LLViewerInventoryCategory * master_folder = model->getFirstDescendantOf(marketplacelistings_id, dest_id); @@ -3907,7 +3907,7 @@ bool dragCategoryIntoFolder(LLUUID dest_id, LLInventoryCategory* inv_cat,              {                  //disable dropping in or out of marketplace for now                  return false; -                 +                  // If we are moving a folder at the listing folder level (i.e. its parent is the marketplace listings folder)                  /*if (from_folder_uuid == marketplacelistings_id)                  { diff --git a/indra/newview/llinventorygallerymenu.cpp b/indra/newview/llinventorygallerymenu.cpp index f9fb47c5c1..8e56ccc01d 100644 --- a/indra/newview/llinventorygallerymenu.cpp +++ b/indra/newview/llinventorygallerymenu.cpp @@ -110,6 +110,7 @@ LLContextMenu* LLInventoryGalleryContextMenu::createMenu()      registrar.add("Inventory.Share", boost::bind(&LLAvatarActions::shareWithAvatars, uuids, gFloaterView->getParentFloater(mGallery)));      enable_registrar.add("Inventory.CanSetUploadLocation", boost::bind(&LLInventoryGalleryContextMenu::canSetUploadLocation, this, _2)); +      enable_registrar.add("Inventory.EnvironmentEnabled", [](LLUICtrl*, const LLSD&)                           {                               return LLEnvironment::instance().isInventoryEnabled(); @@ -121,7 +122,7 @@ LLContextMenu* LLInventoryGalleryContextMenu::createMenu()                               return (!agent_url.empty() && !task_url.empty());                           }); -     +      LLContextMenu* menu = createFromFile("menu_gallery_inventory.xml");      updateMenuItemsVisibility(menu); @@ -448,7 +449,7 @@ void LLInventoryGalleryContextMenu::onRename(const LLSD& notification, const LLS      if (!new_name.empty())      {          LLUUID id = notification["payload"]["id"].asUUID(); -         +          LLViewerInventoryCategory* cat = gInventory.getCategory(id);          if(cat && (cat->getName() != new_name))          { @@ -457,7 +458,7 @@ void LLInventoryGalleryContextMenu::onRename(const LLSD& notification, const LLS              update_inventory_category(cat->getUUID(),updates, NULL);              return;          } -         +          LLViewerInventoryItem* item = gInventory.getItem(id);          if(item && (item->getName() != new_name))          { @@ -506,12 +507,12 @@ bool LLInventoryGalleryContextMenu::canSetUploadLocation(const LLSD& userdata)  bool is_inbox_folder(LLUUID item_id)  {      const LLUUID inbox_id = gInventory.findCategoryUUIDForType(LLFolderType::FT_INBOX); -     +      if (inbox_id.isNull())      {          return false;      } -     +      return gInventory.isObjectDescendentOf(item_id, inbox_id);  } @@ -865,7 +866,7 @@ void LLInventoryGalleryContextMenu::updateMenuItemsVisibility(LLContextMenu* men                  disabled_items.push_back(std::string("Open"));                  disabled_items.push_back(std::string("Open Original"));              } -             +              if(LLAssetType::AT_GESTURE == obj->getType())              {                  items.push_back(std::string("Gesture Separator")); diff --git a/indra/newview/llreflectionmap.cpp b/indra/newview/llreflectionmap.cpp index 90a2f30c92..f4b9d8b2c5 100644 --- a/indra/newview/llreflectionmap.cpp +++ b/indra/newview/llreflectionmap.cpp @@ -56,7 +56,7 @@ void LLReflectionMap::update(U32 resolution, U32 face)      llassert(mCubeArray.notNull());      llassert(mCubeIndex != -1);      //llassert(LLPipeline::sRenderDeferred); -     +      // make sure we don't walk off the edge of the render target      while (resolution > gPipeline.mRT->deferredScreen.getWidth() ||          resolution > gPipeline.mRT->deferredScreen.getHeight()) @@ -142,7 +142,7 @@ void LLReflectionMap::autoAdjustOrigin()              LLVector3 origin(fp);              F32 height = LLWorld::instance().resolveLandHeightAgent(origin) + 2.f;              fp[2] = llmax(fp[2], height); -             +              // make sure radius encompasses all objects              LLSimdScalar r2 = 0.0;              for (int i = 0; i < 8; ++i) @@ -162,7 +162,7 @@ void LLReflectionMap::autoAdjustOrigin()              // make sure near clip doesn't poke through ground              fp[2] = llmax(fp[2], height+mRadius*0.5f); -             +          }      }      else if (mViewerObject) @@ -234,7 +234,7 @@ F32 LLReflectionMap::getNearClip()  bool LLReflectionMap::getIsDynamic()  {      if (gSavedSettings.getS32("RenderReflectionProbeDetail") > (S32) LLReflectionMapManager::DetailLevel::STATIC_ONLY && -        mViewerObject &&  +        mViewerObject &&          mViewerObject->getVolume())      {          return ((LLVOVolume*)mViewerObject)->getReflectionProbeIsDynamic(); @@ -244,7 +244,7 @@ bool LLReflectionMap::getIsDynamic()  }  bool LLReflectionMap::getBox(LLMatrix4& box) -{  +{      if (mViewerObject)      {          LLVolume* volume = mViewerObject->getVolume(); @@ -267,7 +267,7 @@ bool LLReflectionMap::getBox(LLMatrix4& box)                      // construct object to camera space (with scale)                      mv = mv * rm * scale; -                    // inverse is camera space to object unit cube  +                    // inverse is camera space to object unit cube                      mv = mv.inverse();                      box = LLMatrix4(mv.m); @@ -334,7 +334,7 @@ void LLReflectionMap::doOcclusion(const LLVector4a& eye)          mOccluded = false;          return;      } -     +      if (mOcclusionQuery == 0)      { // no query was previously issued, allocate one and issue          LL_PROFILE_ZONE_NAMED_CATEGORY_PIPELINE("rmdo - glGenQueries"); diff --git a/indra/newview/llsetkeybinddialog.cpp b/indra/newview/llsetkeybinddialog.cpp index 6508220c1e..e172e15a0e 100644 --- a/indra/newview/llsetkeybinddialog.cpp +++ b/indra/newview/llsetkeybinddialog.cpp @@ -1,25 +1,25 @@ -/**  +/**   * @file llsetkeybinddialog.cpp   * @brief LLSetKeyBindDialog class implementation.   *   * $LicenseInfo:firstyear=2019&license=viewerlgpl$   * Second Life Viewer Source Code   * Copyright (C) 2019, Linden Research, Inc. - *  + *   * This library is free software; you can redistribute it and/or   * modify it under the terms of the GNU Lesser General Public   * License as published by the Free Software Foundation;   * version 2.1 of the License only. - *  + *   * This library is distributed in the hope that it will be useful,   * but WITHOUT ANY WARRANTY; without even the implied warranty of   * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU   * Lesser General Public License for more details. - *  + *   * You should have received a copy of the GNU Lesser General Public   * License along with this library; if not, write to the Free Software   * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA - *  + *   * Linden Research, Inc., 945 Battery Street, San Francisco, CA  94111  USA   * $/LicenseInfo$   */ diff --git a/indra/newview/viewer_manifest.py b/indra/newview/viewer_manifest.py index c8144f2a93..30305cabab 100755 --- a/indra/newview/viewer_manifest.py +++ b/indra/newview/viewer_manifest.py @@ -59,7 +59,7 @@ class ViewerManifest(LLManifest):          # files during the build (see copy_w_viewer_manifest          # and copy_l_viewer_manifest targets)          return 'package' in self.args['actions'] -     +      def construct(self):          super(ViewerManifest, self).construct()          self.path(src="../../scripts/messages/message_template.msg", dst="app_settings/message_template.msg") @@ -87,7 +87,7 @@ class ViewerManifest(LLManifest):                  # ... and the entire image filters directory                  self.path("filters") -             +                  # ... and the included spell checking dictionaries                  pkgdir = os.path.join(self.args['build'], os.pardir, 'packages')                  with self.prefix(src=pkgdir): @@ -260,14 +260,14 @@ class ViewerManifest(LLManifest):      def app_name_oneword(self):          return ''.join(self.app_name().split()) -     +      def icon_path(self):          return "icons/" + self.channel_type()      def extract_names(self,src):          """Extract contributor names from source file, returns string"""          try: -            with open(src, 'r') as contrib_file:  +            with open(src, 'r') as contrib_file:                  lines = contrib_file.readlines()          except IOError:              print("Failed to open '%s'" % src) @@ -491,7 +491,7 @@ class Windows_x86_64_Manifest(ViewerManifest):                  raise Exception("Directories are not supported by test_CRT_and_copy_action()")          else:              print("Doesn't exist:", src) -         +      def construct(self):          super().construct() @@ -543,7 +543,7 @@ class Windows_x86_64_Manifest(ViewerManifest):          self.path2basename(os.path.join(os.pardir,                                          'llplugin', 'slplugin', self.args['configuration']),                             "slplugin.exe") -         +          # Get shared libs from the shared libs staging directory          with self.prefix(src=os.path.join(self.args['build'], os.pardir,                                            'sharedlibs', self.args['buildtype'])): @@ -572,7 +572,7 @@ class Windows_x86_64_Manifest(ViewerManifest):              # Vivox libraries              self.path("vivoxsdk_x64.dll")              self.path("ortp_x64.dll") -             +              # OpenSSL              self.path("libcrypto-1_1-x64.dll")              self.path("libssl-1_1-x64.dll") @@ -699,7 +699,7 @@ class Windows_x86_64_Manifest(ViewerManifest):                  self.path("plugins/")          if not self.is_packaging_viewer(): -            self.package_file = "copied_deps"     +            self.package_file = "copied_deps"      def nsi_file_commands(self, install=True):          def INSTDIR(path): @@ -758,7 +758,7 @@ class Windows_x86_64_Manifest(ViewerManifest):          installer_file = self.installer_base_name() + '_Setup.exe'          substitution_strings['installer_file'] = installer_file -         +          version_vars = """          !define INSTEXE "SLVersionChecker.exe"          !define VERSION "%(version_short)s" @@ -767,7 +767,7 @@ class Windows_x86_64_Manifest(ViewerManifest):          !define VERSION_REGISTRY "%(version_registry)s"          !define VIEWER_EXE "%(final_exe)s"          """ % substitution_strings -         +          if self.channel_type() == 'release':              substitution_strings['caption'] = CHANNEL_VENDOR_BASE          else: @@ -898,7 +898,7 @@ class Darwin_x86_64_Manifest(ViewerManifest):                  # yields a slightly smaller binary but makes crash                  # logs mostly useless. This may be desirable for the                  # final release. Or not. -                if ("package" in self.args['actions'] or  +                if ("package" in self.args['actions'] or                      "unpacked" in self.args['actions']):                      self.run_command(                          ['strip', '-S', executable]) @@ -923,7 +923,7 @@ class Darwin_x86_64_Manifest(ViewerManifest):                  with self.prefix(src=relpkgdir, dst=""):                      self.path("libndofdev.dylib") -                    self.path("libhunspell-*.dylib")    +                    self.path("libhunspell-*.dylib")                  with self.prefix(src_dst="cursors_mac"):                      self.path("*.tif") | 
