diff options
Diffstat (limited to 'indra/llcorehttp')
| -rw-r--r-- | indra/llcorehttp/_httplibcurl.cpp | 59 | ||||
| -rw-r--r-- | indra/llcorehttp/_httpoperation.cpp | 1 | ||||
| -rw-r--r-- | indra/llcorehttp/_httpoperation.h | 1 | ||||
| -rw-r--r-- | indra/llcorehttp/_httpoprequest.cpp | 48 | ||||
| -rw-r--r-- | indra/llcorehttp/_httpoprequest.h | 22 | ||||
| -rw-r--r-- | indra/llcorehttp/_httpopsetpriority.cpp | 3 | ||||
| -rw-r--r-- | indra/llcorehttp/_httpopsetpriority.h | 6 | ||||
| -rw-r--r-- | indra/llcorehttp/_httppolicy.cpp | 31 | ||||
| -rw-r--r-- | indra/llcorehttp/_httppolicy.h | 6 | ||||
| -rw-r--r-- | indra/llcorehttp/_httpservice.cpp | 32 | ||||
| -rw-r--r-- | indra/llcorehttp/_httpservice.h | 9 | ||||
| -rw-r--r-- | indra/llcorehttp/examples/http_texture_load.cpp | 4 | ||||
| -rw-r--r-- | indra/llcorehttp/httprequest.cpp | 45 | ||||
| -rw-r--r-- | indra/llcorehttp/httprequest.h | 30 | ||||
| -rw-r--r-- | indra/llcorehttp/tests/test_httprequest.hpp | 20 | 
15 files changed, 99 insertions, 218 deletions
| diff --git a/indra/llcorehttp/_httplibcurl.cpp b/indra/llcorehttp/_httplibcurl.cpp index 975ce8a4d5..bd0ac740db 100644 --- a/indra/llcorehttp/_httplibcurl.cpp +++ b/indra/llcorehttp/_httplibcurl.cpp @@ -113,6 +113,7 @@ void HttpLibcurl::shutdown()  void HttpLibcurl::start(int policy_count)  { +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;  	llassert_always(policy_count <= HTTP_POLICY_CLASS_LIMIT);  	llassert_always(! mMultiHandles);					// One-time call only @@ -143,6 +144,7 @@ void HttpLibcurl::start(int policy_count)  // sleep otherwise ask for a normal polling interval.  HttpService::ELoopSpeed HttpLibcurl::processTransport()  { +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;  	HttpService::ELoopSpeed	ret(HttpService::REQUEST_SLEEP);  	// Give libcurl some cycles to do I/O & callbacks @@ -168,6 +170,7 @@ HttpService::ELoopSpeed HttpLibcurl::processTransport()  		CURLMcode status(CURLM_CALL_MULTI_PERFORM);  		do  		{ +            LL_PROFILE_ZONE_NAMED_CATEGORY_NETWORK("httppt - curl_multi_perform");  			running = 0;  			status = curl_multi_perform(mMultiHandles[policy_class], &running);  		} @@ -176,31 +179,34 @@ HttpService::ELoopSpeed HttpLibcurl::processTransport()  		// Run completion on anything done  		CURLMsg * msg(NULL);  		int msgs_in_queue(0); -		while ((msg = curl_multi_info_read(mMultiHandles[policy_class], &msgs_in_queue))) -		{ -			if (CURLMSG_DONE == msg->msg) -			{ -				CURL * handle(msg->easy_handle); -				CURLcode result(msg->data.result); +        { +            LL_PROFILE_ZONE_NAMED_CATEGORY_NETWORK("httppt - curl_multi_info_read"); +            while ((msg = curl_multi_info_read(mMultiHandles[policy_class], &msgs_in_queue))) +            { +                if (CURLMSG_DONE == msg->msg) +                { +                    CURL* handle(msg->easy_handle); +                    CURLcode result(msg->data.result); -				completeRequest(mMultiHandles[policy_class], handle, result); -				handle = NULL;					// No longer valid on return -				ret = HttpService::NORMAL;		// If anything completes, we may have a free slot. -												// Turning around quickly reduces connection gap by 7-10mS. -			} -			else if (CURLMSG_NONE == msg->msg) -			{ -				// Ignore this... it shouldn't mean anything. -				; -			} -			else -			{ -				LL_WARNS_ONCE(LOG_CORE) << "Unexpected message from libcurl.  Msg code:  " -										<< msg->msg -										<< LL_ENDL; -			} -			msgs_in_queue = 0; -		} +                    completeRequest(mMultiHandles[policy_class], handle, result); +                    handle = NULL;					// No longer valid on return +                    ret = HttpService::NORMAL;		// If anything completes, we may have a free slot. +                                                    // Turning around quickly reduces connection gap by 7-10mS. +                } +                else if (CURLMSG_NONE == msg->msg) +                { +                    // Ignore this... it shouldn't mean anything. +                    ; +                } +                else +                { +                    LL_WARNS_ONCE(LOG_CORE) << "Unexpected message from libcurl.  Msg code:  " +                        << msg->msg +                        << LL_ENDL; +                } +                msgs_in_queue = 0; +            } +        }  	}  	if (! mActiveOps.empty()) @@ -214,6 +220,7 @@ HttpService::ELoopSpeed HttpLibcurl::processTransport()  // Caller has provided us with a ref count on op.  void HttpLibcurl::addOp(const HttpOpRequest::ptr_t &op)  { +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;  	llassert_always(op->mReqPolicy < mPolicyCount);  	llassert_always(mMultiHandles[op->mReqPolicy] != NULL); @@ -257,6 +264,7 @@ void HttpLibcurl::addOp(const HttpOpRequest::ptr_t &op)  // method to kill the request.  bool HttpLibcurl::cancel(HttpHandle handle)  { +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;      HttpOpRequest::ptr_t op = HttpOpRequest::fromHandle<HttpOpRequest>(handle);  	active_set_t::iterator it(mActiveOps.find(op));  	if (mActiveOps.end() == it) @@ -282,6 +290,7 @@ bool HttpLibcurl::cancel(HttpHandle handle)  // op to the reply queue with refcount intact.  void HttpLibcurl::cancelRequest(const HttpOpRequest::ptr_t &op)  { +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;  	// Deactivate request  	op->mCurlActive = false; @@ -308,6 +317,7 @@ void HttpLibcurl::cancelRequest(const HttpOpRequest::ptr_t &op)  // Keep them synchronized as necessary.  bool HttpLibcurl::completeRequest(CURLM * multi_handle, CURL * handle, CURLcode status)  { +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;      HttpHandle ophandle(NULL);      CURLcode ccode(CURLE_OK); @@ -445,6 +455,7 @@ int HttpLibcurl::getActiveCountInClass(int policy_class) const  void HttpLibcurl::policyUpdated(int policy_class)  { +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;  	if (policy_class < 0 || policy_class >= mPolicyCount || ! mMultiHandles)  	{  		return; diff --git a/indra/llcorehttp/_httpoperation.cpp b/indra/llcorehttp/_httpoperation.cpp index 3fc4e28910..3b64018132 100644 --- a/indra/llcorehttp/_httpoperation.cpp +++ b/indra/llcorehttp/_httpoperation.cpp @@ -62,7 +62,6 @@ HttpOperation::HttpOperation():      mReplyQueue(),      mUserHandler(),      mReqPolicy(HttpRequest::DEFAULT_POLICY_ID), -    mReqPriority(0U),      mTracing(HTTP_TRACE_OFF),      mMyHandle(LLCORE_HTTP_HANDLE_INVALID)  { diff --git a/indra/llcorehttp/_httpoperation.h b/indra/llcorehttp/_httpoperation.h index 1a75921c09..8c1364bab4 100644 --- a/indra/llcorehttp/_httpoperation.h +++ b/indra/llcorehttp/_httpoperation.h @@ -181,7 +181,6 @@ protected:  public:  	// Request Data  	HttpRequest::policy_t		mReqPolicy; -	HttpRequest::priority_t		mReqPriority;  	// Reply Data  	HttpStatus					mStatus; diff --git a/indra/llcorehttp/_httpoprequest.cpp b/indra/llcorehttp/_httpoprequest.cpp index ba31290c24..d60eb6c95f 100644 --- a/indra/llcorehttp/_httpoprequest.cpp +++ b/indra/llcorehttp/_httpoprequest.cpp @@ -200,6 +200,7 @@ HttpOpRequest::~HttpOpRequest()  void HttpOpRequest::stageFromRequest(HttpService * service)  { +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;      HttpOpRequest::ptr_t self(boost::dynamic_pointer_cast<HttpOpRequest>(shared_from_this()));      service->getPolicy().addOp(self);			// transfers refcount  } @@ -207,6 +208,7 @@ void HttpOpRequest::stageFromRequest(HttpService * service)  void HttpOpRequest::stageFromReady(HttpService * service)  { +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;      HttpOpRequest::ptr_t self(boost::dynamic_pointer_cast<HttpOpRequest>(shared_from_this()));      service->getTransport().addOp(self);		// transfers refcount  } @@ -214,6 +216,7 @@ void HttpOpRequest::stageFromReady(HttpService * service)  void HttpOpRequest::stageFromActive(HttpService * service)  { +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;  	if (mReplyLength)  	{  		// If non-zero, we received and processed a Content-Range @@ -250,6 +253,7 @@ void HttpOpRequest::stageFromActive(HttpService * service)  void HttpOpRequest::visitNotifier(HttpRequest * request)  { +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;  	if (mUserHandler)  	{  		HttpResponse * response = new HttpResponse(); @@ -292,6 +296,7 @@ void HttpOpRequest::visitNotifier(HttpRequest * request)  HttpStatus HttpOpRequest::cancel()  { +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;  	mStatus = HttpStatus(HttpStatus::LLCORE, HE_OP_CANCELED);  	addAsReply(); @@ -301,12 +306,12 @@ HttpStatus HttpOpRequest::cancel()  HttpStatus HttpOpRequest::setupGet(HttpRequest::policy_t policy_id, -								   HttpRequest::priority_t priority,  								   const std::string & url,                                     const HttpOptions::ptr_t & options,  								   const HttpHeaders::ptr_t & headers)  { -	setupCommon(policy_id, priority, url, NULL, options, headers); +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK; +	setupCommon(policy_id, url, NULL, options, headers);  	mReqMethod = HOR_GET;  	return HttpStatus(); @@ -314,14 +319,14 @@ HttpStatus HttpOpRequest::setupGet(HttpRequest::policy_t policy_id,  HttpStatus HttpOpRequest::setupGetByteRange(HttpRequest::policy_t policy_id, -											HttpRequest::priority_t priority,  											const std::string & url,  											size_t offset,  											size_t len,                                              const HttpOptions::ptr_t & options,                                              const HttpHeaders::ptr_t & headers)  { -	setupCommon(policy_id, priority, url, NULL, options, headers); +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK; +	setupCommon(policy_id, url, NULL, options, headers);  	mReqMethod = HOR_GET;  	mReqOffset = offset;  	mReqLength = len; @@ -335,13 +340,13 @@ HttpStatus HttpOpRequest::setupGetByteRange(HttpRequest::policy_t policy_id,  HttpStatus HttpOpRequest::setupPost(HttpRequest::policy_t policy_id, -									HttpRequest::priority_t priority,  									const std::string & url,  									BufferArray * body,                                      const HttpOptions::ptr_t & options,                                      const HttpHeaders::ptr_t & headers)  { -	setupCommon(policy_id, priority, url, body, options, headers); +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK; +	setupCommon(policy_id, url, body, options, headers);  	mReqMethod = HOR_POST;  	return HttpStatus(); @@ -349,13 +354,13 @@ HttpStatus HttpOpRequest::setupPost(HttpRequest::policy_t policy_id,  HttpStatus HttpOpRequest::setupPut(HttpRequest::policy_t policy_id, -								   HttpRequest::priority_t priority,  								   const std::string & url,  								   BufferArray * body,                                     const HttpOptions::ptr_t & options,  								   const HttpHeaders::ptr_t & headers)  { -	setupCommon(policy_id, priority, url, body, options, headers); +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK; +	setupCommon(policy_id, url, body, options, headers);  	mReqMethod = HOR_PUT;  	return HttpStatus(); @@ -363,12 +368,12 @@ HttpStatus HttpOpRequest::setupPut(HttpRequest::policy_t policy_id,  HttpStatus HttpOpRequest::setupDelete(HttpRequest::policy_t policy_id, -    HttpRequest::priority_t priority,      const std::string & url,      const HttpOptions::ptr_t & options,      const HttpHeaders::ptr_t & headers)  { -    setupCommon(policy_id, priority, url, NULL, options, headers); +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK; +    setupCommon(policy_id, url, NULL, options, headers);      mReqMethod = HOR_DELETE;      return HttpStatus(); @@ -376,13 +381,13 @@ HttpStatus HttpOpRequest::setupDelete(HttpRequest::policy_t policy_id,  HttpStatus HttpOpRequest::setupPatch(HttpRequest::policy_t policy_id, -    HttpRequest::priority_t priority,      const std::string & url,      BufferArray * body,      const HttpOptions::ptr_t & options,      const HttpHeaders::ptr_t & headers)  { -    setupCommon(policy_id, priority, url, body, options, headers); +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK; +    setupCommon(policy_id, url, body, options, headers);      mReqMethod = HOR_PATCH;      return HttpStatus(); @@ -390,12 +395,12 @@ HttpStatus HttpOpRequest::setupPatch(HttpRequest::policy_t policy_id,  HttpStatus HttpOpRequest::setupCopy(HttpRequest::policy_t policy_id, -    HttpRequest::priority_t priority,      const std::string & url,      const HttpOptions::ptr_t & options,      const HttpHeaders::ptr_t &headers)  { -    setupCommon(policy_id, priority, url, NULL, options, headers); +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK; +    setupCommon(policy_id, url, NULL, options, headers);      mReqMethod = HOR_COPY;      return HttpStatus(); @@ -403,12 +408,12 @@ HttpStatus HttpOpRequest::setupCopy(HttpRequest::policy_t policy_id,  HttpStatus HttpOpRequest::setupMove(HttpRequest::policy_t policy_id, -    HttpRequest::priority_t priority,      const std::string & url,      const HttpOptions::ptr_t & options,      const HttpHeaders::ptr_t &headers)  { -    setupCommon(policy_id, priority, url, NULL, options, headers); +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK; +    setupCommon(policy_id, url, NULL, options, headers);      mReqMethod = HOR_MOVE;      return HttpStatus(); @@ -416,15 +421,14 @@ HttpStatus HttpOpRequest::setupMove(HttpRequest::policy_t policy_id,  void HttpOpRequest::setupCommon(HttpRequest::policy_t policy_id, -								HttpRequest::priority_t priority,  								const std::string & url,  								BufferArray * body,                                  const HttpOptions::ptr_t & options,  								const HttpHeaders::ptr_t & headers)  { +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;  	mProcFlags = 0U;  	mReqPolicy = policy_id; -	mReqPriority = priority;  	mReqURL = url;  	if (body)  	{ @@ -465,6 +469,7 @@ void HttpOpRequest::setupCommon(HttpRequest::policy_t policy_id,  // *TODO:  Move this to _httplibcurl where it belongs.  HttpStatus HttpOpRequest::prepareRequest(HttpService * service)  { +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;  	// Scrub transport and result data for retried op case  	mCurlActive = false;  	mCurlHandle = NULL; @@ -773,6 +778,7 @@ HttpStatus HttpOpRequest::prepareRequest(HttpService * service)  size_t HttpOpRequest::writeCallback(void * data, size_t size, size_t nmemb, void * userdata)  { +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;      HttpOpRequest::ptr_t op(HttpOpRequest::fromHandle<HttpOpRequest>(userdata));  	if (! op->mReplyBody) @@ -788,6 +794,7 @@ size_t HttpOpRequest::writeCallback(void * data, size_t size, size_t nmemb, void  size_t HttpOpRequest::readCallback(void * data, size_t size, size_t nmemb, void * userdata)  { +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;      HttpOpRequest::ptr_t op(HttpOpRequest::fromHandle<HttpOpRequest>(userdata));  	if (! op->mReqBody) @@ -819,6 +826,7 @@ size_t HttpOpRequest::readCallback(void * data, size_t size, size_t nmemb, void  int HttpOpRequest::seekCallback(void *userdata, curl_off_t offset, int origin)  { +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;      HttpOpRequest::ptr_t op(HttpOpRequest::fromHandle<HttpOpRequest>(userdata));      if (!op->mReqBody) @@ -850,6 +858,7 @@ int HttpOpRequest::seekCallback(void *userdata, curl_off_t offset, int origin)  size_t HttpOpRequest::headerCallback(void * data, size_t size, size_t nmemb, void * userdata)  { +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;  	static const char status_line[] = "HTTP/";  	static const size_t status_line_len = sizeof(status_line) - 1;  	static const char con_ran_line[] = "content-range"; @@ -999,6 +1008,7 @@ size_t HttpOpRequest::headerCallback(void * data, size_t size, size_t nmemb, voi  CURLcode HttpOpRequest::curlSslCtxCallback(CURL *curl, void *sslctx, void *userdata)  { +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;      HttpOpRequest::ptr_t op(HttpOpRequest::fromHandle<HttpOpRequest>(userdata));      if (op->mCallbackSSLVerify) @@ -1025,6 +1035,7 @@ CURLcode HttpOpRequest::curlSslCtxCallback(CURL *curl, void *sslctx, void *userd  int HttpOpRequest::sslCertVerifyCallback(X509_STORE_CTX *ctx, void *param)  { +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;      HttpOpRequest::ptr_t op(HttpOpRequest::fromHandle<HttpOpRequest>(param));  	if (op->mCallbackSSLVerify) @@ -1037,6 +1048,7 @@ int HttpOpRequest::sslCertVerifyCallback(X509_STORE_CTX *ctx, void *param)  int HttpOpRequest::debugCallback(CURL * handle, curl_infotype info, char * buffer, size_t len, void * userdata)  { +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;      HttpOpRequest::ptr_t op(HttpOpRequest::fromHandle<HttpOpRequest>(userdata));  	std::string safe_line; diff --git a/indra/llcorehttp/_httpoprequest.h b/indra/llcorehttp/_httpoprequest.h index cdbe350785..ec84822cf4 100644 --- a/indra/llcorehttp/_httpoprequest.h +++ b/indra/llcorehttp/_httpoprequest.h @@ -105,13 +105,11 @@ public:  	/// Threading:  called by application thread  	///  	HttpStatus setupGet(HttpRequest::policy_t policy_id, -						HttpRequest::priority_t priority,  						const std::string & url,  						const HttpOptions::ptr_t & options,  						const HttpHeaders::ptr_t & headers);  	HttpStatus setupGetByteRange(HttpRequest::policy_t policy_id, -								 HttpRequest::priority_t priority,  								 const std::string & url,  								 size_t offset,  								 size_t len, @@ -119,40 +117,34 @@ public:  								 const HttpHeaders::ptr_t & headers);  	HttpStatus setupPost(HttpRequest::policy_t policy_id, -						 HttpRequest::priority_t priority,  						 const std::string & url,  						 BufferArray * body,                           const HttpOptions::ptr_t & options,  						 const HttpHeaders::ptr_t & headers);  	HttpStatus setupPut(HttpRequest::policy_t policy_id, -						HttpRequest::priority_t priority,  						const std::string & url,  						BufferArray * body,                          const HttpOptions::ptr_t & options,  						const HttpHeaders::ptr_t & headers);      HttpStatus setupDelete(HttpRequest::policy_t policy_id, -                        HttpRequest::priority_t priority,                          const std::string & url,                          const HttpOptions::ptr_t & options,                          const HttpHeaders::ptr_t & headers);      HttpStatus setupPatch(HttpRequest::policy_t policy_id, -                        HttpRequest::priority_t priority,                          const std::string & url,                          BufferArray * body,                          const HttpOptions::ptr_t & options,                          const HttpHeaders::ptr_t & headers);      HttpStatus setupCopy(HttpRequest::policy_t policy_id, -                        HttpRequest::priority_t priority,                          const std::string & url,                          const HttpOptions::ptr_t & options,                          const HttpHeaders::ptr_t & headers);      HttpStatus setupMove(HttpRequest::policy_t policy_id, -                        HttpRequest::priority_t priority,                          const std::string & url,                          const HttpOptions::ptr_t & options,                          const HttpHeaders::ptr_t & headers); @@ -172,7 +164,6 @@ protected:  	// Threading:  called by application thread  	//  	void setupCommon(HttpRequest::policy_t policy_id, -					 HttpRequest::priority_t priority,  					 const std::string & url,  					 BufferArray * body,                       const HttpOptions::ptr_t & options, @@ -239,19 +230,6 @@ public: -/// HttpOpRequestCompare isn't an operation but a uniform comparison -/// functor for STL containers that order by priority.  Mainly -/// used for the ready queue container but defined here. -class HttpOpRequestCompare -{ -public: -	bool operator()(const HttpOpRequest * lhs, const HttpOpRequest * rhs) -		{ -			return lhs->mReqPriority > rhs->mReqPriority; -		} -};  // end class HttpOpRequestCompare - -  // ---------------------------------------  // Free functions  // --------------------------------------- diff --git a/indra/llcorehttp/_httpopsetpriority.cpp b/indra/llcorehttp/_httpopsetpriority.cpp index d48c7a0b7d..b99b4e9e4a 100644 --- a/indra/llcorehttp/_httpopsetpriority.cpp +++ b/indra/llcorehttp/_httpopsetpriority.cpp @@ -24,6 +24,7 @@   * $/LicenseInfo$   */ +#if 0 // DEPRECATED  #include "_httpopsetpriority.h"  #include "httpresponse.h" @@ -61,3 +62,5 @@ void HttpOpSetPriority::stageFromRequest(HttpService * service)  }   // end namespace LLCore + +#endif diff --git a/indra/llcorehttp/_httpopsetpriority.h b/indra/llcorehttp/_httpopsetpriority.h index 43e2aa081b..fd543f37cc 100644 --- a/indra/llcorehttp/_httpopsetpriority.h +++ b/indra/llcorehttp/_httpopsetpriority.h @@ -27,7 +27,7 @@  #ifndef	_LLCORE_HTTP_SETPRIORITY_H_  #define	_LLCORE_HTTP_SETPRIORITY_H_ - +#if 0 // DEPRECATED  #include "httpcommon.h"  #include "httprequest.h"  #include "_httpoperation.h" @@ -49,7 +49,7 @@ namespace LLCore  class HttpOpSetPriority : public HttpOperation  {  public: -	HttpOpSetPriority(HttpHandle handle, HttpRequest::priority_t priority); +	HttpOpSetPriority(HttpHandle handle);  	virtual ~HttpOpSetPriority(); @@ -63,10 +63,10 @@ public:  protected:  	// Request Data  	HttpHandle					mHandle; -	HttpRequest::priority_t		mPriority;  }; // end class HttpOpSetPriority  }  // end namespace LLCore +#endif  #endif	// _LLCORE_HTTP_SETPRIORITY_H_ diff --git a/indra/llcorehttp/_httppolicy.cpp b/indra/llcorehttp/_httppolicy.cpp index 885f0ed61d..29f50c1693 100644 --- a/indra/llcorehttp/_httppolicy.cpp +++ b/indra/llcorehttp/_httppolicy.cpp @@ -330,37 +330,6 @@ HttpService::ELoopSpeed HttpPolicy::processReadyQueue()  	return result;  } - -bool HttpPolicy::changePriority(HttpHandle handle, HttpRequest::priority_t priority) -{ -	for (int policy_class(0); policy_class < mClasses.size(); ++policy_class) -	{ -		ClassState & state(*mClasses[policy_class]); -		// We don't scan retry queue because a priority change there -		// is meaningless.  The request will be issued based on retry -		// intervals not priority value, which is now moot. -		 -		// Scan ready queue for requests that match policy -		HttpReadyQueue::container_type & c(state.mReadyQueue.get_container()); -		for (HttpReadyQueue::container_type::iterator iter(c.begin()); c.end() != iter;) -		{ -			HttpReadyQueue::container_type::iterator cur(iter++); - -			if ((*cur)->getHandle() == handle) -			{ -				HttpOpRequest::ptr_t op(*cur); -				c.erase(cur);									// All iterators are now invalidated -				op->mReqPriority = priority; -				state.mReadyQueue.push(op);						// Re-insert using adapter class -				return true; -			} -		} -	} -	 -	return false; -} - -  bool HttpPolicy::cancel(HttpHandle handle)  {  	for (int policy_class(0); policy_class < mClasses.size(); ++policy_class) diff --git a/indra/llcorehttp/_httppolicy.h b/indra/llcorehttp/_httppolicy.h index 3c4126e14b..0b8806a3e2 100644 --- a/indra/llcorehttp/_httppolicy.h +++ b/indra/llcorehttp/_httppolicy.h @@ -110,12 +110,6 @@ public:  	/// Threading:  called by worker thread      void retryOp(const opReqPtr_t &); -	/// Attempt to change the priority of an earlier request. -	/// Request that Shadows HttpService's method -	/// -	/// Threading:  called by worker thread -	bool changePriority(HttpHandle handle, HttpRequest::priority_t priority); -  	/// Attempt to cancel a previous request.  	/// Shadows HttpService's method as well  	/// diff --git a/indra/llcorehttp/_httpservice.cpp b/indra/llcorehttp/_httpservice.cpp index 56f52f1b09..294acd7f63 100644 --- a/indra/llcorehttp/_httpservice.cpp +++ b/indra/llcorehttp/_httpservice.cpp @@ -80,6 +80,7 @@ HttpService::HttpService()  HttpService::~HttpService()  { +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;  	mExitRequested = 1U;  	if (RUNNING == sState)  	{ @@ -131,6 +132,7 @@ HttpService::~HttpService()  void HttpService::init(HttpRequestQueue * queue)  { +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;  	llassert_always(! sInstance);  	llassert_always(NOT_INITIALIZED == sState);  	sInstance = new HttpService(); @@ -145,6 +147,7 @@ void HttpService::init(HttpRequestQueue * queue)  void HttpService::term()  { +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;  	if (sInstance)  	{  		if (RUNNING == sState && sInstance->mThread) @@ -196,6 +199,7 @@ bool HttpService::isStopped()  /// Threading:  callable by consumer thread *once*.  void HttpService::startThread()  { +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;  	llassert_always(! mThread || STOPPED == sState);  	llassert_always(INITIALIZED == sState || STOPPED == sState); @@ -220,22 +224,6 @@ void HttpService::stopRequested()  } -/// Threading:  callable by worker thread. -bool HttpService::changePriority(HttpHandle handle, HttpRequest::priority_t priority) -{ -	bool found(false); - -	// Skip the request queue as we currently don't leave earlier -	// requests sitting there.  Start with the ready queue... -	found = mPolicy->changePriority(handle, priority); - -	// If not there, we could try the transport/active queue but priority -	// doesn't really have much effect there so we don't waste cycles. -	 -	return found; -} - -  /// Try to find the given request handle on any of the request  /// queues and cancel the operation.  /// @@ -244,6 +232,7 @@ bool HttpService::changePriority(HttpHandle handle, HttpRequest::priority_t prio  /// Threading:  callable by worker thread.  bool HttpService::cancel(HttpHandle handle)  { +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;  	bool canceled(false);  	// Request can't be on request queue so skip that. @@ -264,6 +253,7 @@ bool HttpService::cancel(HttpHandle handle)  /// Threading:  callable by worker thread.  void HttpService::shutdown()  { +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;  	// Disallow future enqueue of requests  	mRequestQueue->stopQueue(); @@ -293,6 +283,8 @@ void HttpService::shutdown()  // requested to stop.  void HttpService::threadRun(LLCoreInt::HttpThread * thread)  { +    LL_PROFILER_SET_THREAD_NAME("HttpService"); +  	boost::this_thread::disable_interruption di;  	LLThread::registerThreadID(); @@ -300,6 +292,7 @@ void HttpService::threadRun(LLCoreInt::HttpThread * thread)  	ELoopSpeed loop(REQUEST_SLEEP);  	while (! mExitRequested)  	{ +        LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;          try          {  		    loop = processRequestQueue(loop); @@ -344,6 +337,7 @@ void HttpService::threadRun(LLCoreInt::HttpThread * thread)  HttpService::ELoopSpeed HttpService::processRequestQueue(ELoopSpeed loop)  { +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;  	HttpRequestQueue::OpContainer ops;  	const bool wait_for_req(REQUEST_SLEEP == loop); @@ -384,6 +378,7 @@ HttpService::ELoopSpeed HttpService::processRequestQueue(ELoopSpeed loop)  HttpStatus HttpService::getPolicyOption(HttpRequest::EPolicyOption opt, HttpRequest::policy_t pclass,  										long * ret_value)  { +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;  	if (opt < HttpRequest::PO_CONNECTION_LIMIT											// option must be in range  		|| opt >= HttpRequest::PO_LAST													// ditto  		|| (! sOptionDesc[opt].mIsLong)													// datatype is long @@ -416,6 +411,7 @@ HttpStatus HttpService::getPolicyOption(HttpRequest::EPolicyOption opt, HttpRequ  HttpStatus HttpService::getPolicyOption(HttpRequest::EPolicyOption opt, HttpRequest::policy_t pclass,  										std::string * ret_value)  { +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;  	HttpStatus status(HttpStatus::LLCORE, LLCore::HE_INVALID_ARG);  	if (opt < HttpRequest::PO_CONNECTION_LIMIT											// option must be in range @@ -443,6 +439,7 @@ HttpStatus HttpService::getPolicyOption(HttpRequest::EPolicyOption opt, HttpRequ  HttpStatus HttpService::getPolicyOption(HttpRequest::EPolicyOption opt, HttpRequest::policy_t pclass,  	HttpRequest::policyCallback_t * ret_value)  { +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;  	HttpStatus status(HttpStatus::LLCORE, LLCore::HE_INVALID_ARG);  	if (opt < HttpRequest::PO_CONNECTION_LIMIT											// option must be in range @@ -472,6 +469,7 @@ HttpStatus HttpService::getPolicyOption(HttpRequest::EPolicyOption opt, HttpRequ  HttpStatus HttpService::setPolicyOption(HttpRequest::EPolicyOption opt, HttpRequest::policy_t pclass,  										long value, long * ret_value)  { +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;  	HttpStatus status(HttpStatus::LLCORE, LLCore::HE_INVALID_ARG);  	if (opt < HttpRequest::PO_CONNECTION_LIMIT											// option must be in range @@ -517,6 +515,7 @@ HttpStatus HttpService::setPolicyOption(HttpRequest::EPolicyOption opt, HttpRequ  HttpStatus HttpService::setPolicyOption(HttpRequest::EPolicyOption opt, HttpRequest::policy_t pclass,  										const std::string & value, std::string * ret_value)  { +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;  	HttpStatus status(HttpStatus::LLCORE, LLCore::HE_INVALID_ARG);  	if (opt < HttpRequest::PO_CONNECTION_LIMIT											// option must be in range @@ -548,6 +547,7 @@ HttpStatus HttpService::setPolicyOption(HttpRequest::EPolicyOption opt, HttpRequ  HttpStatus HttpService::setPolicyOption(HttpRequest::EPolicyOption opt, HttpRequest::policy_t pclass,  	HttpRequest::policyCallback_t value, HttpRequest::policyCallback_t * ret_value)  { +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;  	HttpStatus status(HttpStatus::LLCORE, LLCore::HE_INVALID_ARG);  	if (opt < HttpRequest::PO_CONNECTION_LIMIT											// option must be in range diff --git a/indra/llcorehttp/_httpservice.h b/indra/llcorehttp/_httpservice.h index d0c37ac195..551a718f20 100644 --- a/indra/llcorehttp/_httpservice.h +++ b/indra/llcorehttp/_httpservice.h @@ -147,15 +147,6 @@ public:  	void shutdown();  	/// Try to find the given request handle on any of the request -	/// queues and reset the priority (and queue position) of the -	/// request if found. -	/// -	/// @return			True if the request was found somewhere. -	/// -	/// Threading:  callable by worker thread. -	bool changePriority(HttpHandle handle, HttpRequest::priority_t priority); -	 -	/// Try to find the given request handle on any of the request  	/// queues and cancel the operation.  	///  	/// @return			True if the request was found and canceled. diff --git a/indra/llcorehttp/examples/http_texture_load.cpp b/indra/llcorehttp/examples/http_texture_load.cpp index c7376042b3..cc53b20add 100644 --- a/indra/llcorehttp/examples/http_texture_load.cpp +++ b/indra/llcorehttp/examples/http_texture_load.cpp @@ -469,11 +469,11 @@ bool WorkingSet::reload(LLCore::HttpRequest * hr, LLCore::HttpOptions::ptr_t & o  		LLCore::HttpHandle handle;  		if (offset || length)  		{ -			handle = hr->requestGetByteRange(0, 0, buffer, offset, length, opt, mHeaders, LLCore::HttpHandler::ptr_t(this, NoOpDeletor)); +			handle = hr->requestGetByteRange(0, buffer, offset, length, opt, mHeaders, LLCore::HttpHandler::ptr_t(this, NoOpDeletor));  		}  		else  		{ -            handle = hr->requestGet(0, 0, buffer, opt, mHeaders, LLCore::HttpHandler::ptr_t(this, NoOpDeletor)); +            handle = hr->requestGet(0, buffer, opt, mHeaders, LLCore::HttpHandler::ptr_t(this, NoOpDeletor));  		}  		if (! handle)  		{ diff --git a/indra/llcorehttp/httprequest.cpp b/indra/llcorehttp/httprequest.cpp index 2687f77217..de3854a101 100644 --- a/indra/llcorehttp/httprequest.cpp +++ b/indra/llcorehttp/httprequest.cpp @@ -32,7 +32,6 @@  #include "_httppolicy.h"  #include "_httpoperation.h"  #include "_httpoprequest.h" -#include "_httpopsetpriority.h"  #include "_httpopcancel.h"  #include "_httpopsetget.h" @@ -183,16 +182,16 @@ HttpStatus HttpRequest::getStatus() const  HttpHandle HttpRequest::requestGet(policy_t policy_id, -								   priority_t priority,  								   const std::string & url,                                     const HttpOptions::ptr_t & options,  								   const HttpHeaders::ptr_t & headers,  								   HttpHandler::ptr_t user_handler)  { +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;  	HttpStatus status;  	HttpOpRequest::ptr_t op(new HttpOpRequest()); -	if (! (status = op->setupGet(policy_id, priority, url, options, headers))) +	if (! (status = op->setupGet(policy_id, url, options, headers)))  	{  		mLastReqStatus = status;          return LLCORE_HTTP_HANDLE_INVALID; @@ -210,7 +209,6 @@ HttpHandle HttpRequest::requestGet(policy_t policy_id,  HttpHandle HttpRequest::requestGetByteRange(policy_t policy_id, -											priority_t priority,  											const std::string & url,  											size_t offset,  											size_t len, @@ -218,10 +216,11 @@ HttpHandle HttpRequest::requestGetByteRange(policy_t policy_id,  											const HttpHeaders::ptr_t & headers,  											HttpHandler::ptr_t user_handler)  { +    LL_PROFILE_ZONE_SCOPED_CATEGORY_NETWORK;  	HttpStatus status;  	HttpOpRequest::ptr_t op(new HttpOpRequest()); -	if (! (status = op->setupGetByteRange(policy_id, priority, url, offset, len, options, headers))) +	if (! (status = op->setupGetByteRange(policy_id, url, offset, len, options, headers)))  	{  		mLastReqStatus = status;          return LLCORE_HTTP_HANDLE_INVALID; @@ -239,7 +238,6 @@ HttpHandle HttpRequest::requestGetByteRange(policy_t policy_id,  HttpHandle HttpRequest::requestPost(policy_t policy_id, -									priority_t priority,  									const std::string & url,  									BufferArray * body,                                      const HttpOptions::ptr_t & options, @@ -249,7 +247,7 @@ HttpHandle HttpRequest::requestPost(policy_t policy_id,  	HttpStatus status;  	HttpOpRequest::ptr_t op(new HttpOpRequest()); -	if (! (status = op->setupPost(policy_id, priority, url, body, options, headers))) +	if (! (status = op->setupPost(policy_id, url, body, options, headers)))  	{  		mLastReqStatus = status;          return LLCORE_HTTP_HANDLE_INVALID; @@ -267,7 +265,6 @@ HttpHandle HttpRequest::requestPost(policy_t policy_id,  HttpHandle HttpRequest::requestPut(policy_t policy_id, -								   priority_t priority,  								   const std::string & url,  								   BufferArray * body,                                     const HttpOptions::ptr_t & options, @@ -277,7 +274,7 @@ HttpHandle HttpRequest::requestPut(policy_t policy_id,  	HttpStatus status;  	HttpOpRequest::ptr_t op (new HttpOpRequest()); -	if (! (status = op->setupPut(policy_id, priority, url, body, options, headers))) +	if (! (status = op->setupPut(policy_id, url, body, options, headers)))  	{  		mLastReqStatus = status;          return LLCORE_HTTP_HANDLE_INVALID; @@ -294,7 +291,6 @@ HttpHandle HttpRequest::requestPut(policy_t policy_id,  }  HttpHandle HttpRequest::requestDelete(policy_t policy_id, -    priority_t priority,      const std::string & url,      const HttpOptions::ptr_t & options,      const HttpHeaders::ptr_t & headers, @@ -303,7 +299,7 @@ HttpHandle HttpRequest::requestDelete(policy_t policy_id,      HttpStatus status;      HttpOpRequest::ptr_t op(new HttpOpRequest()); -    if (!(status = op->setupDelete(policy_id, priority, url, options, headers))) +    if (!(status = op->setupDelete(policy_id, url, options, headers)))      {          mLastReqStatus = status;          return LLCORE_HTTP_HANDLE_INVALID; @@ -320,7 +316,6 @@ HttpHandle HttpRequest::requestDelete(policy_t policy_id,  }  HttpHandle HttpRequest::requestPatch(policy_t policy_id, -    priority_t priority,      const std::string & url,      BufferArray * body,      const HttpOptions::ptr_t & options, @@ -330,7 +325,7 @@ HttpHandle HttpRequest::requestPatch(policy_t policy_id,      HttpStatus status;      HttpOpRequest::ptr_t op (new HttpOpRequest()); -    if (!(status = op->setupPatch(policy_id, priority, url, body, options, headers))) +    if (!(status = op->setupPatch(policy_id, url, body, options, headers)))      {          mLastReqStatus = status;          return LLCORE_HTTP_HANDLE_INVALID; @@ -347,7 +342,6 @@ HttpHandle HttpRequest::requestPatch(policy_t policy_id,  }  HttpHandle HttpRequest::requestCopy(policy_t policy_id, -    priority_t priority,      const std::string & url,      const HttpOptions::ptr_t & options,      const HttpHeaders::ptr_t & headers, @@ -356,7 +350,7 @@ HttpHandle HttpRequest::requestCopy(policy_t policy_id,      HttpStatus status;      HttpOpRequest::ptr_t op(new HttpOpRequest()); -    if (!(status = op->setupCopy(policy_id, priority, url, options, headers))) +    if (!(status = op->setupCopy(policy_id, url, options, headers)))      {          mLastReqStatus = status;          return LLCORE_HTTP_HANDLE_INVALID; @@ -374,7 +368,6 @@ HttpHandle HttpRequest::requestCopy(policy_t policy_id,  }  HttpHandle HttpRequest::requestMove(policy_t policy_id, -    priority_t priority,      const std::string & url,      const HttpOptions::ptr_t & options,      const HttpHeaders::ptr_t & headers, @@ -383,7 +376,7 @@ HttpHandle HttpRequest::requestMove(policy_t policy_id,      HttpStatus status;      HttpOpRequest::ptr_t op (new HttpOpRequest()); -    if (!(status = op->setupMove(policy_id, priority, url, options, headers))) +    if (!(status = op->setupMove(policy_id, url, options, headers)))      {          mLastReqStatus = status;          return LLCORE_HTTP_HANDLE_INVALID; @@ -483,24 +476,6 @@ HttpHandle HttpRequest::requestCancel(HttpHandle request, HttpHandler::ptr_t use  } -HttpHandle HttpRequest::requestSetPriority(HttpHandle request, priority_t priority, -										   HttpHandler::ptr_t handler) -{ -	HttpStatus status; - -	HttpOperation::ptr_t op (new HttpOpSetPriority(request, priority)); -	op->setReplyPath(mReplyQueue, handler); -	if (! (status = mRequestQueue->addOp(op)))			// transfers refcount -	{ -		mLastReqStatus = status; -        return LLCORE_HTTP_HANDLE_INVALID; -	} - -	mLastReqStatus = status; -	return op->getHandle(); -} - -  // ====================================  // Utility Methods  // ==================================== diff --git a/indra/llcorehttp/httprequest.h b/indra/llcorehttp/httprequest.h index a418eb6a7a..ca4b9e92bc 100644 --- a/indra/llcorehttp/httprequest.h +++ b/indra/llcorehttp/httprequest.h @@ -95,7 +95,6 @@ private:  public:  	typedef unsigned int policy_t; -	typedef unsigned int priority_t;  	typedef boost::shared_ptr<HttpRequest> ptr_t;      typedef boost::weak_ptr<HttpRequest>   wptr_t; @@ -316,8 +315,6 @@ public:  	///  	/// @param	policy_id		Default or user-defined policy class under  	///							which this request is to be serviced. -	/// @param	priority		Standard priority scheme inherited from -	///							Indra code base (U32-type scheme).  	/// @param	url				URL with any encoded query parameters to  	///							be accessed.  	/// @param	options			Optional instance of an HttpOptions object @@ -346,7 +343,6 @@ public:  	///							case, @see getStatus() will return more info.  	///  	HttpHandle requestGet(policy_t policy_id, -						  priority_t priority,  						  const std::string & url,                            const HttpOptions::ptr_t & options,  						  const HttpHeaders::ptr_t & headers, @@ -377,7 +373,6 @@ public:  	/// - Referer:  	///  	/// @param	policy_id		@see requestGet() -	/// @param	priority		"  	/// @param	url				"  	/// @param	offset			Offset of first byte into resource to be returned.  	/// @param	len				Count of bytes to be returned @@ -387,7 +382,6 @@ public:  	/// @return					"  	///  	HttpHandle requestGetByteRange(policy_t policy_id, -								   priority_t priority,  								   const std::string & url,  								   size_t offset,  								   size_t len, @@ -418,7 +412,6 @@ public:  	/// - Expect:  	///  	/// @param	policy_id		@see requestGet() -	/// @param	priority		"  	/// @param	url				"  	/// @param	body			Byte stream to be sent as the body.  No  	///							further encoding or escaping will be done @@ -429,7 +422,6 @@ public:  	/// @return					"  	///  	HttpHandle requestPost(policy_t policy_id, -						   priority_t priority,  						   const std::string & url,  						   BufferArray * body,                             const HttpOptions::ptr_t & options, @@ -459,7 +451,6 @@ public:  	/// - Content-Type:  	///  	/// @param	policy_id		@see requestGet() -	/// @param	priority		"  	/// @param	url				"  	/// @param	body			Byte stream to be sent as the body.  No  	///							further encoding or escaping will be done @@ -470,7 +461,6 @@ public:  	/// @return					"  	///  	HttpHandle requestPut(policy_t policy_id, -						  priority_t priority,  						  const std::string & url,  						  BufferArray * body,                            const HttpOptions::ptr_t & options, @@ -483,7 +473,6 @@ public:      /// encoding and communicating the content types.      ///      /// @param	policy_id		@see requestGet() -    /// @param	priority		"      /// @param	url				"      /// @param	options			@see requestGet()K(optional)      /// @param	headers			" @@ -491,7 +480,6 @@ public:      /// @return					"      ///      HttpHandle requestDelete(policy_t policy_id, -            priority_t priority,              const std::string & url,              const HttpOptions::ptr_t & options,              const HttpHeaders::ptr_t & headers, @@ -502,7 +490,6 @@ public:      /// encoding and communicating the content types.      ///      /// @param	policy_id		@see requestGet() -    /// @param	priority		"      /// @param	url				"      /// @param	body			Byte stream to be sent as the body.  No      ///							further encoding or escaping will be done @@ -513,7 +500,6 @@ public:      /// @return					"      ///      HttpHandle requestPatch(policy_t policy_id, -            priority_t priority,              const std::string & url,              BufferArray * body,              const HttpOptions::ptr_t & options, @@ -525,7 +511,6 @@ public:      /// encoding and communicating the content types.      ///      /// @param	policy_id		@see requestGet() -    /// @param	priority		"      /// @param	url				"      /// @param	options			@see requestGet()K(optional)      /// @param	headers			" @@ -533,7 +518,6 @@ public:      /// @return					"      ///      HttpHandle requestCopy(policy_t policy_id, -            priority_t priority,              const std::string & url,              const HttpOptions::ptr_t & options,              const HttpHeaders::ptr_t & headers, @@ -544,7 +528,6 @@ public:      /// encoding and communicating the content types.      ///      /// @param	policy_id		@see requestGet() -    /// @param	priority		"      /// @param	url				"      /// @param	options			@see requestGet()K(optional)      /// @param	headers			" @@ -552,7 +535,6 @@ public:      /// @return					"      ///      HttpHandle requestMove(policy_t policy_id, -            priority_t priority,              const std::string & url,              const HttpOptions::ptr_t & options,              const HttpHeaders::ptr_t & headers, @@ -593,18 +575,6 @@ public:  	HttpHandle requestCancel(HttpHandle request, HttpHandler::ptr_t); -	/// Request that a previously-issued request be reprioritized. -	/// The status of whether the change itself succeeded arrives -	/// via notification.   -	/// -	/// @param	request			Handle of previously-issued request to -	///							be changed. -	/// @param	priority		New priority value. -	/// @param	handler			@see requestGet() -	/// @return					" -	/// -	HttpHandle requestSetPriority(HttpHandle request, priority_t priority, HttpHandler::ptr_t handler); -  	/// @}  	/// @name UtilityMethods diff --git a/indra/llcorehttp/tests/test_httprequest.hpp b/indra/llcorehttp/tests/test_httprequest.hpp index 154f6b12e9..3eaac10aeb 100644 --- a/indra/llcorehttp/tests/test_httprequest.hpp +++ b/indra/llcorehttp/tests/test_httprequest.hpp @@ -614,7 +614,6 @@ void HttpRequestTestObjectType::test<7>()  		// Issue a GET that can't connect  		mStatus = HttpStatus(HttpStatus::EXT_CURL_EASY, CURLE_COULDNT_CONNECT);  		HttpHandle handle = req->requestGetByteRange(HttpRequest::DEFAULT_POLICY_ID, -													 0U,  													 "http://127.0.0.1:2/nothing/here",  													 0,  													 0, @@ -716,7 +715,6 @@ void HttpRequestTestObjectType::test<8>()  		// Issue a GET that *can* connect  		mStatus = HttpStatus(200);  		HttpHandle handle = req->requestGet(HttpRequest::DEFAULT_POLICY_ID, -											0U,  											url_base,  											HttpOptions::ptr_t(),                                              HttpHeaders::ptr_t(), @@ -812,7 +810,6 @@ void HttpRequestTestObjectType::test<9>()  		// Issue a GET that *can* connect  		mStatus = HttpStatus(200);  		HttpHandle handle = req->requestGetByteRange(HttpRequest::DEFAULT_POLICY_ID, -													 0U,  													 url_base,  													 0,  													 0, @@ -913,7 +910,6 @@ void HttpRequestTestObjectType::test<10>()  		body->append(body_text, strlen(body_text));  		mStatus = HttpStatus(200);  		HttpHandle handle = req->requestPut(HttpRequest::DEFAULT_POLICY_ID, -											0U,  											url_base,  											body,                                              HttpOptions::ptr_t(), @@ -1020,7 +1016,6 @@ void HttpRequestTestObjectType::test<11>()  		body->append(body_text, strlen(body_text));  		mStatus = HttpStatus(200);  		HttpHandle handle = req->requestPost(HttpRequest::DEFAULT_POLICY_ID, -											 0U,  											 url_base,  											 body,                                               HttpOptions::ptr_t(), @@ -1127,7 +1122,6 @@ void HttpRequestTestObjectType::test<12>()  		// Issue a GET that *can* connect  		mStatus = HttpStatus(200);  		HttpHandle handle = req->requestGetByteRange(HttpRequest::DEFAULT_POLICY_ID, -													 0U,  													 url_base,  													 0,  													 0, @@ -1240,7 +1234,6 @@ void HttpRequestTestObjectType::test<13>()  			regex_container_t::value_type(boost::regex("X-LL-Special", boost::regex::icase),  										  boost::regex(".*", boost::regex::icase)));  		HttpHandle handle = req->requestGetByteRange(HttpRequest::DEFAULT_POLICY_ID, -													 0U,  													 url_base,  													 0,	  												 0, @@ -1346,7 +1339,6 @@ void HttpRequestTestObjectType::test<14>()  		// Issue a GET that sleeps  		mStatus = HttpStatus(HttpStatus::EXT_CURL_EASY, CURLE_OPERATION_TIMEDOUT);  		HttpHandle handle = req->requestGetByteRange(HttpRequest::DEFAULT_POLICY_ID, -													 0U,  													 url_base,  													 0,  													 0, @@ -1454,7 +1446,6 @@ void HttpRequestTestObjectType::test<15>()  		mStatus = HttpStatus(200);  		handler.mCheckContentType = "application/llsd+xml";  		HttpHandle handle = req->requestGet(HttpRequest::DEFAULT_POLICY_ID, -											0U,  											url_base,                                              HttpOptions::ptr_t(),                                              HttpHeaders::ptr_t(), @@ -1609,7 +1600,6 @@ void HttpRequestTestObjectType::test<16>()  				boost::regex("X-Reflect-content-encoding", boost::regex::icase),  				boost::regex(".*", boost::regex::icase)));  		HttpHandle handle = req->requestGet(HttpRequest::DEFAULT_POLICY_ID, -											0U,  											url_base + "reflect/",  											options,  											HttpHeaders::ptr_t(), @@ -1684,7 +1674,6 @@ void HttpRequestTestObjectType::test<16>()  				boost::regex("X-Reflect-content-encoding", boost::regex::icase),  				boost::regex(".*", boost::regex::icase)));  		handle = req->requestGetByteRange(HttpRequest::DEFAULT_POLICY_ID, -										  0U,  										  url_base + "reflect/",  										  0,  										  47, @@ -1863,7 +1852,6 @@ void HttpRequestTestObjectType::test<17>()  				boost::regex("X-Reflect-transfer_encoding", boost::regex::icase),  				boost::regex(".*chunked.*", boost::regex::icase)));  		HttpHandle handle = req->requestPost(HttpRequest::DEFAULT_POLICY_ID, -											 0U,  											 url_base + "reflect/",  											 ba,  											 options, @@ -2049,7 +2037,6 @@ void HttpRequestTestObjectType::test<18>()  				boost::regex(".*", boost::regex::icase)));  		HttpHandle handle = req->requestPut(HttpRequest::DEFAULT_POLICY_ID, -											0U,  											url_base + "reflect/",  											ba,  											options, @@ -2249,7 +2236,6 @@ void HttpRequestTestObjectType::test<19>()  				boost::regex("X-Reflect-content-encoding", boost::regex::icase),  				boost::regex(".*", boost::regex::icase)));  		HttpHandle handle = req->requestGet(HttpRequest::DEFAULT_POLICY_ID, -											0U,  											url_base + "reflect/",  											options,  											headers, @@ -2457,7 +2443,6 @@ void HttpRequestTestObjectType::test<20>()  				boost::regex(".*", boost::regex::icase)));  		HttpHandle handle = req->requestPost(HttpRequest::DEFAULT_POLICY_ID, -											 0U,  											 url_base + "reflect/",  											 ba,  											 options, @@ -2666,7 +2651,6 @@ void HttpRequestTestObjectType::test<21>()  				boost::regex("X-Reflect-content-type", boost::regex::icase),  				boost::regex("text/html", boost::regex::icase)));  		HttpHandle handle = req->requestPut(HttpRequest::DEFAULT_POLICY_ID, -											0U,  											url_base + "reflect/",  											ba,  											options, @@ -2797,7 +2781,6 @@ void HttpRequestTestObjectType::test<22>()  			char buffer[128];  			sprintf(buffer, "/bug2295/%d/", i);  			HttpHandle handle = req->requestGetByteRange(HttpRequest::DEFAULT_POLICY_ID, -														 0U,  														 url_base + buffer,  														 0,  														 25, @@ -2829,7 +2812,6 @@ void HttpRequestTestObjectType::test<22>()  			char buffer[128];  			sprintf(buffer, "/bug2295/00000012/%d/", i);  			HttpHandle handle = req->requestGetByteRange(HttpRequest::DEFAULT_POLICY_ID, -														 0U,  														 url_base + buffer,  														 0,  														 25, @@ -2861,7 +2843,6 @@ void HttpRequestTestObjectType::test<22>()  			char buffer[128];  			sprintf(buffer, "/bug2295/inv_cont_range/%d/", i);  			HttpHandle handle = req->requestGetByteRange(HttpRequest::DEFAULT_POLICY_ID, -														 0U,  														 url_base + buffer,  														 0,  														 25, @@ -2984,7 +2965,6 @@ void HttpRequestTestObjectType::test<23>()  			std::ostringstream url;  			url << url_base << i << "/";  			HttpHandle handle = req->requestGetByteRange(HttpRequest::DEFAULT_POLICY_ID, -														 0U,  														 url.str(),  														 0,  														 0, | 
