diff options
| -rwxr-xr-x | indra/llcommon/llregistry.h | 2 | ||||
| -rwxr-xr-x | indra/llcommon/llsingleton.h | 18 | ||||
| -rwxr-xr-x | indra/llcommon/tests/llsingleton_test.cpp | 1 | ||||
| -rwxr-xr-x | indra/newview/llfloaterimcontainer.cpp | 2 | 
4 files changed, 5 insertions, 18 deletions
diff --git a/indra/llcommon/llregistry.h b/indra/llcommon/llregistry.h index 29950c108d..fde729f8f9 100755 --- a/indra/llcommon/llregistry.h +++ b/indra/llcommon/llregistry.h @@ -269,7 +269,7 @@ public:  		~ScopedRegistrar()  		{ -			if (!singleton_t::destroyed()) +			if (singleton_t::instanceExists())  			{  				popScope();  			} diff --git a/indra/llcommon/llsingleton.h b/indra/llcommon/llsingleton.h index 6e6291a165..a4877eed1f 100755 --- a/indra/llcommon/llsingleton.h +++ b/indra/llcommon/llsingleton.h @@ -166,31 +166,19 @@ public:  		return NULL;  	} -	static DERIVED_TYPE* getIfExists() -	{ -		return sData.mInstance; -	} -  	// Reference version of getInstance()  	// Preferred over getInstance() as it disallows checking for NULL  	static DERIVED_TYPE& instance()  	{  		return *getInstance();  	} -	 -	// Has this singleton been created uet? -	// Use this to avoid accessing singletons before the can safely be constructed + +	// Has this singleton been created yet? +	// Use this to avoid accessing singletons before they can safely be constructed.  	static bool instanceExists()  	{  		return sData.mInitState == INITIALIZED;  	} -	 -	// Has this singleton already been deleted? -	// Use this to avoid accessing singletons from a static object's destructor -	static bool destroyed() -	{ -		return sData.mInitState == DELETED; -	}  private: diff --git a/indra/llcommon/tests/llsingleton_test.cpp b/indra/llcommon/tests/llsingleton_test.cpp index 385289aefe..bed436283a 100755 --- a/indra/llcommon/tests/llsingleton_test.cpp +++ b/indra/llcommon/tests/llsingleton_test.cpp @@ -65,7 +65,6 @@ namespace tut  		//Delete the instance  		LLSingletonTest::deleteSingleton(); -		ensure(LLSingletonTest::destroyed());  		ensure(!LLSingletonTest::instanceExists());  		//Construct it again. diff --git a/indra/newview/llfloaterimcontainer.cpp b/indra/newview/llfloaterimcontainer.cpp index ab57e8c170..cacd66aee9 100755 --- a/indra/newview/llfloaterimcontainer.cpp +++ b/indra/newview/llfloaterimcontainer.cpp @@ -101,7 +101,7 @@ LLFloaterIMContainer::~LLFloaterIMContainer()  	gSavedPerAccountSettings.setBOOL("ConversationsMessagePaneCollapsed", mMessagesPane->isCollapsed());  	gSavedPerAccountSettings.setBOOL("ConversationsParticipantListCollapsed", !isParticipantListExpanded()); -	if (!LLSingleton<LLIMMgr>::destroyed()) +	if (LLIMMgr::instanceExists())  	{  		LLIMMgr::getInstance()->removeSessionObserver(this);  	}  | 
