diff options
author | andreykproductengine <andreykproductengine@lindenlab.com> | 2019-04-16 21:58:22 +0300 |
---|---|---|
committer | andreykproductengine <andreykproductengine@lindenlab.com> | 2019-04-16 21:58:22 +0300 |
commit | 29f0a7808ff470bd20c76b089881c98b3b59e6fc (patch) | |
tree | 2f7e918f186106e9077dc0b92f70324274d9c04f /indra | |
parent | 68307a81bca0de46660dc2964e155666b29270b7 (diff) |
SL-10930 LLStringUtil pointlessly scan the string
Diffstat (limited to 'indra')
-rw-r--r-- | indra/llcommon/llstring.h | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/indra/llcommon/llstring.h b/indra/llcommon/llstring.h index 30bec3a6f8..b619a9e48c 100644 --- a/indra/llcommon/llstring.h +++ b/indra/llcommon/llstring.h @@ -1735,7 +1735,8 @@ bool LLStringUtilBase<T>::startsWith( const string_type& substr) { if(string.empty() || (substr.empty())) return false; - if(0 == string.find(substr)) return true; + if (substr.length() > string.length()) return false; + if (0 == string.compare(0, substr.length(), substr)) return true; return false; } @@ -1746,9 +1747,11 @@ bool LLStringUtilBase<T>::endsWith( const string_type& substr) { if(string.empty() || (substr.empty())) return false; - std::string::size_type idx = string.rfind(substr); - if(std::string::npos == idx) return false; - return (idx == (string.size() - substr.size())); + size_t sub_len = substr.length(); + size_t str_len = string.length(); + if (sub_len > str_len) return false; + if (0 == string.compare(str_len - sub_len, sub_len, substr)) return true; + return false; } // static |