EXP-1065 FIX -- Inventory has slowed to a crawl. Clicking between items has an average one second delay. Same with switching between tabs.

* Removed numerous places in the code that called findChild across the inventory panel unnecessarily.
* Conglomerated uses of inbox and outbox inventory panels to the sidepanel class so the pointers can be cached and functionality like selection handling can be done more efficiently.
* Optimized LLView::childHasKeyboardFocus() to work backwards up from the focus object rather than searching for children that may or may not turn out to have focus.

Reviewed by Richard.

1 files changed, 4 insertions, 19 deletions

diff --git a/indra/newview/llpanelmarketplaceinbox.cpp b/indra/newview/llpanelmarketplaceinbox.cpp
index c505ad85a3..141e29fcec 100644
--- a/indra/newview/llpanelmarketplaceinbox.cpp
+++ b/indra/newview/llpanelmarketplaceinbox.cpp
@@ -83,7 +83,7 @@ void LLPanelMarketplaceInbox::handleLoginComplete()
 	LLSideTray::getInstance()->setTabButtonBadgeDriver("sidebar_inventory", this);

 }

 

-void LLPanelMarketplaceInbox::setupInventoryPanel()

+LLInventoryPanel * LLPanelMarketplaceInbox::setupInventoryPanel()

 {

 	LLView * inbox_inventory_placeholder = getChild<LLView>("inbox_inventory_placeholder");

 	LLView * inbox_inventory_parent = inbox_inventory_placeholder->getParent();

@@ -106,30 +106,15 @@ void LLPanelMarketplaceInbox::setupInventoryPanel()
 	

 	// Hide the placeholder text

 	inbox_inventory_placeholder->setVisible(FALSE);

+	

+	return mInventoryPanel;

 }

 

 void LLPanelMarketplaceInbox::onFocusReceived()

 {

 	LLSidepanelInventory * sidepanel_inventory = LLSideTray::getInstance()->getPanel<LLSidepanelInventory>("sidepanel_inventory");

-

-	if (sidepanel_inventory)

-	{

-		LLInventoryPanel * inv_panel = sidepanel_inventory->getActivePanel();

-

-		if (inv_panel)

-		{

-			inv_panel->clearSelection();

-		}

 	

-		LLInventoryPanel * outbox_panel = sidepanel_inventory->findChild<LLInventoryPanel>("inventory_outbox");

-

-		if (outbox_panel)

-		{

-			outbox_panel->clearSelection();

-		}

-		

-		sidepanel_inventory->updateVerbs();

-	}

+	sidepanel_inventory->clearSelections(true, false, true);

 }

 

 BOOL LLPanelMarketplaceInbox::handleDragAndDrop(S32 x, S32 y, MASK mask, BOOL drop, EDragAndDropType cargo_type, void *cargo_data, EAcceptance *accept, std::string& tooltip_msg)