Post-merge cleanups (ported llstartup.cpp changes to where the surrounding code has been moved to in LLLoginInstance and LLAppViewer)

1 files changed, 53 insertions, 19 deletions

diff --git a/indra/newview/llappviewer.cpp b/indra/newview/llappviewer.cpp
index dd00001cd4..d67dd3adcb 100644
--- a/indra/newview/llappviewer.cpp
+++ b/indra/newview/llappviewer.cpp
@@ -4186,7 +4186,14 @@ void LLAppViewer::launchUpdater()
 		delete LLAppViewer::sUpdaterInfo;
 	}
 	LLAppViewer::sUpdaterInfo = new LLAppViewer::LLUpdaterInfo() ;
-	
+
+	// if a sim name was passed in via command line parameter (typically through a SLURL)
+	if ( LLURLSimString::sInstance.mSimString.length() )
+	{
+		// record the location to start at next time
+		gSavedSettings.setString( "NextLoginLocation", LLURLSimString::sInstance.mSimString ); 
+	};
+
 #if LL_WINDOWS
 	LLAppViewer::sUpdaterInfo->mUpdateExePath = gDirUtilp->getTempFilename();
 	if (LLAppViewer::sUpdaterInfo->mUpdateExePath.empty())
@@ -4220,13 +4227,6 @@ void LLAppViewer::launchUpdater()
 		return;
 	}
 
-	// if a sim name was passed in via command line parameter (typically through a SLURL)
-	if ( LLURLSimString::sInstance.mSimString.length() )
-	{
-		// record the location to start at next time
-		gSavedSettings.setString( "NextLoginLocation", LLURLSimString::sInstance.mSimString ); 
-	};
-
 	LLAppViewer::sUpdaterInfo->mParams << "-url \"" << update_url.asString() << "\"";
 
 	LL_DEBUGS("AppInit") << "Calling updater: " << LLAppViewer::sUpdaterInfo->mUpdateExePath << " " << LLAppViewer::sUpdaterInfo->mParams.str() << LL_ENDL;
@@ -4238,13 +4238,6 @@ void LLAppViewer::launchUpdater()
 	// see LLAppViewerWin32.cpp
 	
 #elif LL_DARWIN
-	// if a sim name was passed in via command line parameter (typically through a SLURL)
-	if ( LLURLSimString::sInstance.mSimString.length() )
-	{
-		// record the location to start at next time
-		gSavedSettings.setString( "NextLoginLocation", LLURLSimString::sInstance.mSimString ); 
-	};
-	
 	LLAppViewer::sUpdaterInfo->mUpdateExePath = "'";
 	LLAppViewer::sUpdaterInfo->mUpdateExePath += gDirUtilp->getAppRODataDir();
 	LLAppViewer::sUpdaterInfo->mUpdateExePath += "/mac-updater.app/Contents/MacOS/mac-updater' -url \"";
@@ -4258,10 +4251,51 @@ void LLAppViewer::launchUpdater()
 	// Run the auto-updater.
 	system(LLAppViewer::sUpdaterInfo->mUpdateExePath.c_str()); /* Flawfinder: ignore */
 
-#elif LL_LINUX || LL_SOLARIS
-	OSMessageBox("Automatic updating is not yet implemented for Linux.\n"
-		"Please download the latest version from www.secondlife.com.",
-		LLStringUtil::null, OSMB_OK);
+#elif (LL_LINUX || LL_SOLARIS) && LL_GTK

+	// we tell the updater where to find the xml containing string

+	// translations which it can use for its own UI

+	std::string xml_strings_file = "strings.xml";

+	std::vector<std::string> xui_path_vec = LLUI::getXUIPaths();

+	std::string xml_search_paths;

+	std::vector<std::string>::const_iterator iter;

+	// build comma-delimited list of xml paths to pass to updater

+	for (iter = xui_path_vec.begin(); iter != xui_path_vec.end(); )

+	{

+		std::string this_skin_dir = gDirUtilp->getDefaultSkinDir()

+			+ gDirUtilp->getDirDelimiter()

+			+ (*iter);

+		llinfos << "Got a XUI path: " << this_skin_dir << llendl;

+		xml_search_paths.append(this_skin_dir);

+		++iter;

+		if (iter != xui_path_vec.end())

+			xml_search_paths.append(","); // comma-delimit

+	}

+	// build the overall command-line to run the updater correctly

+	update_exe_path = 

+		gDirUtilp->getExecutableDir() + "/" + "linux-updater.bin" + 

+		" --url \"" + update_url.asString() + "\"" +

+		" --name \"" + LLAppViewer::instance()->getSecondLifeTitle() + "\"" +

+		" --dest \"" + gDirUtilp->getAppRODataDir() + "\"" +

+		" --stringsdir \"" + xml_search_paths + "\"" +

+		" --stringsfile \"" + xml_strings_file + "\"";

+

+	LL_INFOS("AppInit") << "Calling updater: " 

+			    << update_exe_path << LL_ENDL;

+

+	// *TODO: we could use the gdk equivilant to ensure the updater

+	// gets started on the same screen.

+	GError *error = NULL;

+	if (!g_spawn_command_line_async(update_exe_path.c_str(), &error))

+	{

+		llerrs << "Failed to launch updater: "

+		       << error->message

+		       << llendl;

+	}

+	if (error) {

+		g_error_free(error);
+	}
+#else
+	OSMessageBox(LLTrans::getString("MBNoAutoUpdate"), LLStringUtil::null, OSMB_OK);
 #endif
 
 	// *REMOVE:Mani - Saving for reference...