Large changes to the LLCurl::Responder API, as well as pulling in some changes to common libraries from the server codebase:

* Additional error checking in http handlers.
* Uniform log spam for http errors.
* Switch to using constants for http heads and status codes.
* Fixed bugs in incorrectly checking if parsing LLSD xml resulted in an error.
* Reduced spam regarding LLSD parsing errors in the default completedRaw http handler.  It should not longer be necessary to short-circuit completedRaw to avoid spam.
* Ported over a few bug fixes from the server code.
* Switch mode http status codes to use S32 instead of U32.
* Ported LLSD::asStringRef from server code; avoids copying strings all over the place.
* Ported server change to LLSD::asBinary; this always returns a reference now instead of copying the entire binary blob.
* Ported server pretty notation format (and pretty binary format) to llsd serialization.

* The new LLCurl::Responder API no longer has two error handlers to choose from.  Overriding the following methods have been deprecated:
** error - use httpFailure
** errorWithContent - use httpFailure
** result - use httpSuccess
** completed - use httpCompleted
** completedHeader - no longer necessary; call getResponseHeaders() from a completion method to obtain these headers.

* In order to 'catch' a completed http request, override one of these methods:
** httpSuccess - Called for any 2xx status code.
** httpFailure - Called for any non-2xx status code.
** httpComplete - Called for all status codes.  Default implementation is to call either httpSuccess or httpFailure.
* It is recommended to keep these methods protected/private in order to avoid triggering of these methods without using a 'push' method (see below).

* Uniform error handling should followed whenever possible by calling a variant of this during httpFailure:
** llwarns << dumpResponse() << llendl;
* Be sure to include LOG_CLASS(your_class_name) in your class in order for the log entry to give more context.

* In order to 'push' a result into the responder, you should no longer call error, errorWithContent, result, or completed.
* Nor should you directly call httpSuccess/Failure/Completed (unless passing a message up to a parent class).
* Instead, you can set the internal content of a responder and trigger a corresponding method using the following methods:
** successResult - Sets results and calls httpSuccess
** failureResult - Sets results and calls httpFailure
** completedResult - Sets results and calls httpCompleted

* To obtain information about a the response from a reponder method, use the following getters:
** getStatus - HTTP status code
** getReason - Reason string
** getContent - Content (Parsed body LLSD)
** getResponseHeaders - Response Headers (LLSD map)
** getHTTPMethod - HTTP method of the request
** getURL - URL of the request

* It is still possible to override completeRaw if you want to manipulate data directly out of LLPumpIO.

* See indra/llmessage/llcurl.h for more information.

1 files changed, 19 insertions, 20 deletions

diff --git a/indra/llmessage/llmime.cpp b/indra/llmessage/llmime.cpp
index 9d9c4ebd68..90653098db 100644
--- a/indra/llmessage/llmime.cpp
+++ b/indra/llmessage/llmime.cpp
@@ -27,6 +27,7 @@
  */
 
 #include "linden_common.h"
+#include "llhttpconstants.h"
 #include "llmime.h"
 
 #include <vector>
@@ -36,20 +37,6 @@
 /**
  * Useful constants.
  */
-// Headers specified in rfc-2045 will be canonicalized below.
-static const std::string CONTENT_LENGTH("Content-Length");
-static const std::string CONTENT_TYPE("Content-Type");
-static const S32 KNOWN_HEADER_COUNT = 6;
-static const std::string KNOWN_HEADER[KNOWN_HEADER_COUNT] =
-{
-	CONTENT_LENGTH,
-	CONTENT_TYPE,
-	std::string("MIME-Version"),
-	std::string("Content-Transfer-Encoding"),
-	std::string("Content-ID"),
-	std::string("Content-Description"),
-};
-
 // parser helpers
 static const std::string MULTIPART("multipart");
 static const std::string BOUNDARY("boundary");
@@ -115,7 +102,7 @@ S32 LLMimeIndex::contentLength() const
 {
 	// Find the content length in the headers.
 	S32 length = -1;
-	LLSD content_length = mImpl->mHeaders[CONTENT_LENGTH];
+	LLSD content_length = mImpl->mHeaders[HTTP_HEADER_CONTENT_LENGTH];
 	if(content_length.isDefined())
 	{
 		length = content_length.asInteger();
@@ -126,7 +113,7 @@ S32 LLMimeIndex::contentLength() const
 std::string LLMimeIndex::contentType() const
 {
 	std::string type;
-	LLSD content_type = mImpl->mHeaders[CONTENT_TYPE];
+	LLSD content_type = mImpl->mHeaders[HTTP_HEADER_CONTENT_TYPE];
 	if(content_type.isDefined())
 	{
 		type = content_type.asString();
@@ -137,7 +124,7 @@ std::string LLMimeIndex::contentType() const
 bool LLMimeIndex::isMultipart() const
 {
 	bool multipart = false;
-	LLSD content_type = mImpl->mHeaders[CONTENT_TYPE];
+	LLSD content_type = mImpl->mHeaders[HTTP_HEADER_CONTENT_TYPE];
 	if(content_type.isDefined())
 	{
 		std::string type = content_type.asString();
@@ -354,7 +341,7 @@ bool LLMimeParser::Impl::parseIndex(
 		if(index.isMultipart())
 		{
 			// Figure out the separator, scan past it, and recurse.
-			std::string ct = headers[CONTENT_TYPE].asString();
+			std::string ct = headers[HTTP_HEADER_CONTENT_TYPE].asString();
 			std::string sep = findSeparator(ct);
 			scanPastSeparator(istr, limit, sep);
 			while(continueParse() && parseIndex(istr, limit, sep, true, mime))
@@ -381,6 +368,18 @@ bool LLMimeParser::Impl::parseHeaders(
 	S32 limit,
 	LLSD& headers)
 {
+	// Headers specified in rfc-2045 will be canonicalized below.
+	static const S32 KNOWN_HEADER_COUNT = 6;
+	static const std::string KNOWN_HEADER[KNOWN_HEADER_COUNT] =
+	{
+		HTTP_HEADER_CONTENT_LENGTH,
+		HTTP_HEADER_CONTENT_TYPE,
+		HTTP_HEADER_MIME_VERSION,
+		HTTP_HEADER_CONTENT_TRANSFER_ENCODING,
+		HTTP_HEADER_CONTENT_ID,
+		HTTP_HEADER_CONTENT_DESCRIPTION,
+	};
+
 	while(continueParse())
 	{
 		// Get the next line.
@@ -531,9 +530,9 @@ void LLMimeParser::Impl::scanPastContent(
 	LLSD headers,
 	const std::string separator)
 {
-	if(headers.has(CONTENT_LENGTH))
+	if(headers.has(HTTP_HEADER_CONTENT_LENGTH))
 	{
-		S32 content_length = headers[CONTENT_LENGTH].asInteger();
+		S32 content_length = headers[HTTP_HEADER_CONTENT_LENGTH].asInteger();
 		// Subtract 2 here for the \r\n after the content.
 		S32 max_skip = llmin(content_length, limit - mScanCount - 2);
 		istr.ignore(max_skip);