DEV-49633 fixed, use Cache-Control max-age for display name expiration

We have no C++ libraries for parsing RFC 1123 dates, so parsing "Expires"
headers is risky.  max-age delta-seconds is easier to parse and equivalent
for this use.  Also added unit tests for max-age parsing.  Pair-programmed
with Huseby.

1 files changed, 9 insertions, 0 deletions

diff --git a/indra/llmessage/llavatarnamecache.h b/indra/llmessage/llavatarnamecache.h
index 26cecc5ab5..0a8b987b05 100644
--- a/indra/llmessage/llavatarnamecache.h
+++ b/indra/llmessage/llavatarnamecache.h
@@ -89,6 +89,15 @@ namespace LLAvatarNameCache
 	void fetch(const LLUUID& agent_id);
 
 	void insert(const LLUUID& agent_id, const LLAvatarName& av_name);
+
+	// Compute name expiration time from HTTP Cache-Control header,
+	// or return default value, in seconds from epoch.
+	F64 nameExpirationFromHeaders(LLSD headers);
 }
 
+// Parse a cache-control header to get the max-age delta-seconds.
+// Returns true if header has max-age param and it parses correctly.
+// Exported here to ease unit testing.
+bool max_age_from_cache_control(const std::string& cache_control, S32 *max_age);
+
 #endif