SH-3184/SH-3221 Improve cleanup, destructor, thread termination, etc. logic in library.

With this commit, the cleanup paths should be production quality.  Unit tests have been
expanded to include cases requiring thread termination and cleanup by the worker thread.
Special operation/request added to support the unit tests.  Thread interface expanded
to include a very aggressive cancel() method that does not do cleanup but prevents the
thread from accessing objects that will be destroyed.

1 files changed, 5 insertions, 1 deletions

diff --git a/indra/llcorehttp/_httprequestqueue.h b/indra/llcorehttp/_httprequestqueue.h
index 6e8f00c4da..e11fd17c90 100644
--- a/indra/llcorehttp/_httprequestqueue.h
+++ b/indra/llcorehttp/_httprequestqueue.h
@@ -73,11 +73,15 @@ public:
 public:
 	typedef std::vector<HttpOperation *> OpContainer;
 
-	/// Insert an object at the back of the reply queue.
+	/// Insert an object at the back of the request queue.
 	///
 	/// Caller must provide one refcount to the queue which takes
 	/// possession of the count.
 	///
+	/// @return			Standard status.  On failure, caller
+	///					must dispose of the operation with
+	///					an explicit release() call.
+	///
 	/// Threading:  callable by any thread.
 	HttpStatus addOp(HttpOperation * op);