SL-18330: Fix per PR review comments.

1 files changed, 5 insertions, 1 deletions

diff --git a/indra/llcommon/llsdserialize.cpp b/indra/llcommon/llsdserialize.cpp
index 0a5e3652c7..a14a6b5b1b 100644
--- a/indra/llcommon/llsdserialize.cpp
+++ b/indra/llcommon/llsdserialize.cpp
@@ -169,9 +169,13 @@ bool LLSDSerialize::deserialize(LLSD& sd, std::istream& str, llssize max_bytes)
 	/*
 	* Remove the newline chars
 	*/
-	auto lastchar = header.find_last_not_of("\r\n");
+	std::string::size_type lastchar = header.find_last_not_of("\r\n");
 	if (lastchar != std::string::npos)
 	{
+		// It's important that find_last_not_of() returns size_type, which is
+		// why lastchar explicitly declares the type above. erase(size_type)
+		// erases from that offset to the end of the string, whereas
+		// erase(iterator) erases only a single character.
 		header.erase(lastchar+1);
 	}