summaryrefslogtreecommitdiff
path: root/indra/llcommon/llpointer.h
diff options
context:
space:
mode:
authorAlexander Gavriliuk <alexandrgproductengine@lindenlab.com>2023-08-23 11:06:53 +0200
committerGuru <alexandrgproductengine@lindenlab.com>2023-08-23 18:16:43 +0200
commit85efb85acfa098998c0f1249320f7e08288efdfc (patch)
tree9f1a438b2095cd365adbc726ce5b9cdf51cd6668 /indra/llcommon/llpointer.h
parent720504595a09a94d10ff07926e8d1274dcab440c (diff)
SL-19299 Viewer crashes after change 'Pick a physics model:' dropdown
Diffstat (limited to 'indra/llcommon/llpointer.h')
-rw-r--r--indra/llcommon/llpointer.h31
1 files changed, 16 insertions, 15 deletions
diff --git a/indra/llcommon/llpointer.h b/indra/llcommon/llpointer.h
index 9a6453ea48..2401951465 100644
--- a/indra/llcommon/llpointer.h
+++ b/indra/llcommon/llpointer.h
@@ -129,16 +129,6 @@ protected:
void ref();
void unref();
#else
-
- void assign(const LLPointer<Type>& ptr)
- {
- if( mPointer != ptr.mPointer )
- {
- unref();
- mPointer = ptr.mPointer;
- ref();
- }
- }
void ref()
{
if (mPointer)
@@ -161,7 +151,18 @@ protected:
}
}
}
-#endif
+#endif // LL_LIBRARY_INCLUDE
+
+ void assign(const LLPointer<Type>& ptr)
+ {
+ if (mPointer != ptr.mPointer)
+ {
+ unref();
+ mPointer = ptr.mPointer;
+ ref();
+ }
+ }
+
protected:
Type* mPointer;
};
@@ -264,7 +265,7 @@ protected:
#ifdef LL_LIBRARY_INCLUDE
void ref();
void unref();
-#else
+#else // LL_LIBRARY_INCLUDE
void ref()
{
if (mPointer)
@@ -277,9 +278,9 @@ protected:
{
if (mPointer)
{
- const Type *tempp = mPointer;
+ const Type *temp = mPointer;
mPointer = NULL;
- tempp->unref();
+ temp->unref();
if (mPointer != NULL)
{
LL_WARNS() << "Unreference did assignment to non-NULL because of destructor" << LL_ENDL;
@@ -287,7 +288,7 @@ protected:
}
}
}
-#endif
+#endif // LL_LIBRARY_INCLUDE
protected:
const Type* mPointer;
};