diff options
| author | Aleric Inglewood <Aleric.Inglewood@gmail.com> | 2010-12-30 14:53:30 +0100 |
|---|---|---|
| committer | Aleric Inglewood <Aleric.Inglewood@gmail.com> | 2010-12-30 14:53:30 +0100 |
| commit | 953104660944345c0531b2b2f49bfaf09348d44c (patch) | |
| tree | ef5b993902a60edff931353b631466a8c3d3fe25 /doc/contributions.txt | |
| parent | e82fb8c7b90c0f5038c38a1aaf4882718433bfd6 (diff) | |
STORM-955: VWR-24312: Massively duplicated objects
Turns out that most of my SNOW-800 patch was included in Viewer 2 (albeit without crediting me).
However, not everything was used and some more cleaning up was possible.
After this patch, and when compiling with optimization, there are no duplicates left
anymore that shouldn't be there in the first place. Apart from the debug stream
iostream guard variable, there are several static variables with the same name (r, r1,
r2, etc) but that indeed actually different symbol objects. Then there are a few
constant POD arrays that are duplicated a hand full of times because they are
accessed with a variable index (so optimizing them away is not possible). I left them
like that (although defining those as extern as well would have been more consistent
and not slower; in fact it would be faster theoretically because those arrays could
share the same cache page then).
Diffstat (limited to 'doc/contributions.txt')
| -rw-r--r-- | doc/contributions.txt | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/doc/contributions.txt b/doc/contributions.txt index 8765240caa..bec60b7d30 100644 --- a/doc/contributions.txt +++ b/doc/contributions.txt @@ -66,6 +66,7 @@ Aleric Inglewood SNOW-626 SNOW-756 SNOW-764 + SNOW-800 VWR-10001 VWR-10579 VWR-10759 @@ -91,6 +92,7 @@ Aleric Inglewood SNOW-744 SNOW-766 STORM-163 + STORM-955 Ales Beaumont VWR-9352 SNOW-240 |