ACME-497 : Refactor the LLSocialCheckinPanel code a bit to make it more maintainable

2 files changed, 61 insertions, 41 deletions

diff --git a/indra/newview/llfloatersocial.cpp b/indra/newview/llfloatersocial.cpp
index 2859b19b19..c9f7283640 100644
--- a/indra/newview/llfloatersocial.cpp
+++ b/indra/newview/llfloatersocial.cpp
@@ -392,11 +392,61 @@ void LLSocialPhotoPanel::onSend()
 }
 
 
-LLSocialCheckinPanel::LLSocialCheckinPanel()
+LLSocialCheckinPanel::LLSocialCheckinPanel() :
+    mMapUrl(""),
+    mReloadingMapTexture(false)
 {
 	mCommitCallbackRegistrar.add("SocialSharing.SendCheckin", boost::bind(&LLSocialCheckinPanel::onSend, this));
 }
 
+BOOL LLSocialCheckinPanel::postBuild()
+{
+    // Keep pointers to widgets so we don't traverse the UI hierarchy too often
+    mMapLoadingIndicator = getChild<LLUICtrl>("map_loading_indicator");
+    mMapPlaceholder = getChild<LLIconCtrl>("map_placeholder");
+    mMapCheckBox = getChild<LLCheckBoxCtrl>("add_place_view_cb");
+    mMapCheckBoxValue = mMapCheckBox->get();
+    
+	return LLPanel::postBuild();
+}
+
+void LLSocialCheckinPanel::draw()
+{
+    std::string map_url = get_map_url();
+    // Did we change location?
+    if (map_url != mMapUrl)
+    {
+        mMapUrl = map_url;
+        // Load the map tile
+        mMapTexture = LLViewerTextureManager::getFetchedTextureFromUrl(mMapUrl, FTT_MAP_TILE, TRUE, LLGLTexture::BOOST_NONE, LLViewerTexture::LOD_TEXTURE);
+        mMapTexture->setBoostLevel(LLGLTexture::BOOST_MAP);
+        mReloadingMapTexture = true;
+        // In the meantime, put the "loading" indicator on, hide the tile map and disable the checkbox
+        mMapLoadingIndicator->setVisible(true);
+        mMapPlaceholder->setVisible(false);
+        mMapCheckBoxValue = mMapCheckBox->get();
+        mMapCheckBox->set(false);
+        mMapCheckBox->setEnabled(false);
+    }
+    // Are we done loading the map tile?
+    if (mReloadingMapTexture && mMapTexture->isFullyLoaded())
+    {
+        // Don't do it again next time around
+        mReloadingMapTexture = false;
+        // Convert the map texture to the appropriate image object
+        LLPointer<LLUIImage> ui_image = new LLUIImage(mMapUrl, mMapTexture);
+        // Load the map widget with the correct map tile image
+        mMapPlaceholder->setImage(ui_image);
+        // Now hide the loading indicator, bring the tile in view and reenable the checkbox with its previous value
+        mMapLoadingIndicator->setVisible(false);
+        mMapPlaceholder->setVisible(true);
+        mMapCheckBox->setEnabled(true);
+        mMapCheckBox->set(mMapCheckBoxValue);
+    }
+    
+	LLPanel::draw();
+}
+
 void LLSocialCheckinPanel::onSend()
 {
 	// Get the location SLURL
@@ -431,8 +481,6 @@ void LLSocialCheckinPanel::onSend()
 
 
 LLFloaterSocial::LLFloaterSocial(const LLSD& key) : LLFloater(key),
-    mMapUrl(""),
-    mReloadingMapTexture(false),
     mSocialPhotoPanel(NULL)
 {
 	mCommitCallbackRegistrar.add("SocialSharing.Cancel", boost::bind(&LLFloaterSocial::onCancel, this));
@@ -446,45 +494,12 @@ void LLFloaterSocial::onCancel()
 BOOL LLFloaterSocial::postBuild()
 {
 	mSocialPhotoPanel = static_cast<LLSocialPhotoPanel*>(getChild<LLUICtrl>("social_photo_tab"));
-    // Keep a pointer to the map tile placeholder texture
-    mMapPlaceholder = getChild<LLIconCtrl>("map_placeholder")->getImage();
 	return LLFloater::postBuild();
 }
 
 /*virtual*/
 void LLFloaterSocial::draw()
 {
-    std::string map_url = get_map_url();
-    // Did we change location?
-    if (map_url != mMapUrl)
-    {
-        mMapUrl = map_url;
-        // Load the map tile
-        mMapTexture = LLViewerTextureManager::getFetchedTextureFromUrl(mMapUrl, FTT_MAP_TILE, TRUE, LLGLTexture::BOOST_NONE, LLViewerTexture::LOD_TEXTURE);
-        mMapTexture->setBoostLevel(LLGLTexture::BOOST_MAP);
-        mReloadingMapTexture = true;
-        // In the meantime, put back the "loading" placeholder in the map widget
-        getChild<LLLoadingIndicator>("map_loading_indicator")->setVisible(true);
-        getChild<LLIconCtrl>("map_placeholder")->setVisible(false);
-        mMapCheckBoxValue = getChild<LLCheckBoxCtrl>("add_place_view_cb")->get();
-        getChild<LLCheckBoxCtrl>("add_place_view_cb")->set(false);
-        getChild<LLCheckBoxCtrl>("add_place_view_cb")->setEnabled(false);
-   }
-    // Are we done loading the map tile?
-    if (mReloadingMapTexture && mMapTexture->isFullyLoaded())
-    {
-        // Don't do it again next time around
-        mReloadingMapTexture = false;
-        // Convert the map texture to the appropriate image object
-        LLPointer<LLUIImage> ui_image = new LLUIImage(mMapUrl, mMapTexture);
-        // Point map widget to correct map tile
-        getChild<LLIconCtrl>("map_placeholder")->setImage(ui_image);
-        // Switch visibility
-        getChild<LLLoadingIndicator>("map_loading_indicator")->setVisible(false);
-        getChild<LLIconCtrl>("map_placeholder")->setVisible(true);
-        getChild<LLCheckBoxCtrl>("add_place_view_cb")->setEnabled(true);
-        getChild<LLCheckBoxCtrl>("add_place_view_cb")->set(mMapCheckBoxValue);
-    }
     LLFloater::draw();
 }
 
diff --git a/indra/newview/llfloatersocial.h b/indra/newview/llfloatersocial.h
index 8b51d5ca9b..b7792e10c1 100644
--- a/indra/newview/llfloatersocial.h
+++ b/indra/newview/llfloatersocial.h
@@ -81,7 +81,17 @@ class LLSocialCheckinPanel : public LLPanel
 {
 public:
     LLSocialCheckinPanel();
+	BOOL postBuild();
+	void draw();
     void onSend();
+private:
+    std::string mMapUrl;
+    LLPointer<LLViewerFetchedTexture> mMapTexture;
+    LLUICtrl* mMapLoadingIndicator;
+    LLIconCtrl* mMapPlaceholder;
+    LLCheckBoxCtrl* mMapCheckBox;
+    bool mReloadingMapTexture;
+    bool mMapCheckBoxValue;
 };
 
 class LLFloaterSocial : public LLFloater
@@ -99,11 +109,6 @@ public:
 
 private:
 	LLSocialPhotoPanel * mSocialPhotoPanel;
-    std::string mMapUrl;
-    LLPointer<LLViewerFetchedTexture> mMapTexture;
-	LLPointer<LLUIImage> mMapPlaceholder;
-    bool mReloadingMapTexture;
-    bool mMapCheckBoxValue;
 };
 
 #endif // LL_LLFLOATERSOCIAL_H