Megapahit's fork of the Second Life viewer. https://megapahit.org/viewer.git/atom?h=26.1.1 2021-04-26T17:31:32Z 2021-04-26T17:31:32Z Mnikolenko ProductEngine mnikolenko@productengine.com 2021-04-26T16:12:49Z urn:sha1:430661f1351b177355de7f2a993f6e34c835f939 2021-03-08T13:56:16Z Brad Payne (Vir Linden) vir@lindenlab.com 2021-03-08T13:56:16Z urn:sha1:c83e740ef94e16ba85574454f3138905edecb029 This reverts commit e61f485a04dc8c8ac6bcf6a24848359092884d14, reversing changes made to 00c47d079f7e958e473ed4083a7f7691fa02dcd5. 2020-09-17T12:10:03Z Mnikolenko ProductEngine mnikolenko@productengine.com 2020-09-17T12:10:03Z urn:sha1:20b50f99c89271518ae37ade0ef0866167070c80 2016-06-30T20:51:50Z Nat Goodspeed nat@lindenlab.com 2016-06-30T20:51:50Z urn:sha1:464a0df4c1d3e4073fe0bde506ac1d4aa194b02f The LLApp API used to consist of init(), mainLoop(), cleanup() methods. This makes sense -- but on Mac that structure was being subverted. The method called mainLoop() was in fact being called once per frame. There was initialization code in the method, which (on Mac) needed to be skipped with an already-initialized bool. There was a 'while' loop which (on Mac) needed to be turned into an 'if' instead so the method would return after every frame. Rename LLApp::mainLoop() to frame(). Propagate through subclasses LLAppViewer and LLCrashLogger. Document the fact that frame() returns true to mean "done." (This was always the case, but had to be inferred from the code.) Rename the Mac Objective-C function mainLoop to oneFrame. Rename the C++ free function it calls from runMainLoop() to pumpMainLoop(). Add comments to llappdelegate-objc.mm explaining (inferred) control flow. Change the Linux viewer main() and the Windows viewer WINMAIN() from a single LLAppViewer::mainLoop() call to repeatedly call frame() until it returns true. Move initialization code from the top of LLAppViewer::frame() to the init() method, where it more properly belongs. Remove corresponding mMainLoopInitialized flag (and all references) from LLAppViewer. Remove 'while (! LLApp::isExiting())' (or on Mac, 'if (! LLApp::isExiting())') from LLAppViewer::frame() -- thus unindenting the whole body of the 'while' and causing many lines of apparent change. (Apologies to reviewers.) There are four LLApp states: APP_STATUS_RUNNING, APP_STATUS_QUITTING, APP_STATUS_STOPPED and APP_STATUS_ERROR. Change LLAppViewer::frame() return value from (isExiting()) (QUITTING or ERROR) to (! isRunning()). I do not know under what circumstances the state might transition to STOPPED during a frame() call, but I'm quite sure that if it does, we don't want to call frame() again. We only want a subsequent call if the state is RUNNING. Also rename mainLoop() method in LLCrashLogger subclasses LLCrashLoggerWindows, LLCrashLoggerMac, LLCrashLoggerLinux. Of course it's completely up to the frame() method whether to yield control; none of those in fact do. Honor protocol by returning true (frame() is done), even though each one's main() caller ignores the return value. In fact LLCrashLoggerWindows::mainLoop() wasn't using the return protocol correctly anyway, returning wParam or 0 or 1 -- possibly because the return protocol was never explicitly documented. It should always return true: "I'm done, don't call me again." 2016-04-13T18:41:38Z Oz Linden oz@lindenlab.com 2016-04-13T18:41:38Z urn:sha1:57488bc3812d9d308cc9e869c2088ba8212bc851 2016-04-08T15:32:48Z Oz Linden oz@lindenlab.com 2016-04-08T15:32:48Z urn:sha1:ed38b5c9235b35cc4aa7448be2897c5fffbc684e 2016-03-07T17:41:11Z Oz Linden oz@lindenlab.com 2016-03-07T17:41:11Z urn:sha1:5822fb00b605d4f4ddd01e887b40d04b67e162a9 2015-11-10T14:48:56Z Oz Linden oz@lindenlab.com 2015-11-10T14:48:56Z urn:sha1:c8726aba303bcf1207b730a344536e25491420bc 2015-09-16T21:21:03Z Glenn Glazer coyot@lindenlab.com 2015-09-16T21:21:03Z urn:sha1:b09f0a120e53c8b27d196df6a33a42c9ac0e146c 2014-11-20T21:25:11Z Jonathan Yap jhwelch@gmail.com 2014-11-20T21:25:11Z urn:sha1:44f5d7320952de2c4c7e1062b1c02c2f521400fa