Megapahit's fork of the Second Life viewer. https://megapahit.org/viewer.git/atom?h=26.1.1 2012-01-20T23:10:40Z 2012-01-20T23:10:40Z Nat Goodspeed nat@lindenlab.com 2012-01-20T23:10:40Z urn:sha1:f0dbb878337082d3f581874c12e6df2f4659a464 LLProcessLauncher had the somewhat fuzzy mandate of (1) accumulating parameters with which to launch a child process and (2) sometimes tracking the lifespan of the ensuing child process. But a valid LLProcessLauncher object might or might not have ever been associated with an actual child process. LLProcess specifically tracks a child process. In effect, it's a fairly thin wrapper around a process HANDLE (on Windows) or pid_t (elsewhere), with lifespan management thrown in. A static LLProcess::create() method launches a new child; create() accepts an LLSD bundle with child parameters. So building up a parameter bundle is deferred to LLSD rather than conflated with the process management object. Reconcile all known LLProcessLauncher consumers in the viewer code base, notably the class unit tests. 2012-01-19T22:04:55Z Nat Goodspeed nat@lindenlab.com 2012-01-19T22:04:55Z urn:sha1:083a9e0927144a9e2f052bc8573da8a26259a257 2012-01-19T21:41:17Z Nat Goodspeed nat@lindenlab.com 2012-01-19T21:41:17Z urn:sha1:6fddfab6dd8e49dcbf4933bde23dbcdfe3e213db Despite LLProcessLauncher's list-of-argument-strings API, on Windows it must ram them all into a single command-line string anyway. This means that if arguments contain spaces (or anything else that would confuse Windows command- line parsing), the target process won't receive the intended arguments. Introduce double quotes for any arguments not already double-quoted by caller. 2012-01-18T06:09:50Z Nat Goodspeed nat@lindenlab.com 2012-01-18T06:09:50Z urn:sha1:06f9dbd8db9895f81d7bd325d8cf616f68533396 typedef LLProcessLauncher::ll_pid_t to be HANDLE on Windows, pid_t elsewhere. Then we can define getProcessID() returning ll_pid_t on all platforms, retaining getProcessHandle() for hypothetical existing consumers... of which there are none in practice. This lets us define isRunning(ll_pid_t) to encapsulate the platform-specific logic to actually check on a running child process, turning non-static isRunning() into a fairly trivial wrapper. 2012-01-17T23:55:42Z Nat Goodspeed nat@lindenlab.com 2012-01-17T23:55:42Z urn:sha1:c0731c1c05cafe508c91c5f583301234ba3b8403 On a Posix platform (vfork()/execv() implementation), if for any reason the execv() failed (e.g. executable not on PATH), the viewer would never know, nor the user: the vfork() child produced no output, and terminated with rc 0! Add logging, make child terminate with nonzero rc. Remove pointless addArgument(const char*) overload: this does nothing for you that the compiler won't do implicitly. In llupdateinstaller.cpp, remove pointless c_str() call in addArgument() arg: we were starting with a std::string, then extracting its c_str(), only to construct a whole new std::string from it! 2011-03-17T19:16:41Z Alain Linden alain@lindenlab.com 2011-03-17T19:16:41Z urn:sha1:313b77fd269665d059e64eee079d21da2a3129c1 2011-03-01T23:03:26Z Richard Linden none@none 2011-03-01T23:03:26Z urn:sha1:11a0785cebcbbcf89eab90c7f2a4c0b7c538736c made slplugin.exe start with correct working directory (llplugin) 2010-12-10T23:41:14Z Andrew A. de Laix alain@lindenlab.com 2010-12-10T23:41:14Z urn:sha1:8ab943f470552dd9469d6025bcd359a67ad5513e 2010-11-12T22:53:29Z Vadim ProductEngine vsavchuk@productengine.com 2010-11-12T22:53:29Z urn:sha1:b2fcba25c8dd04318420af30f877b0984a524055 The editor can be specified: * via "ExternalEditor" setting in settings.xml * via LL_SCRIPT_EDITOR variable Removed obsolete XUIEditor setting in favor of the new one. 2010-08-13T11:24:57Z Oz Linden oz@lindenlab.com 2010-08-13T11:24:57Z urn:sha1:06b0d72efa96b6a0ed665f7cd46f358c48929e7b