viewer.git/indra/llcommon/llpointer.h, branch cef_147Megapahit's fork of the Second Life viewer.
https://megapahit.org/viewer.git/atom?h=cef_1472026-01-05T17:34:44ZRemove unused boost::hash specialization from LLPointer and update std::hash specialization to use std::hash internally2026-01-05T17:34:44ZRyerye@alchemyviewer.org2026-01-05T16:09:43Zurn:sha1:112f9b9e226049ca1abaecfaa8a6d1b67506e140
Signed-off-by: Rye <rye@alchemyviewer.org>
Migrate ~LLPointer()'s peculiar warning case to llpointer.cpp.2026-01-05T17:34:44ZNat Goodspeednat@lindenlab.com2024-09-27T09:38:39Zurn:sha1:9d684bc9241cca4aae79d93886d0f95dcee26d65
This allows removing #include "llerror.h" from llpointer.h.
Also remove #include "llmutex.h" as a heavy way to get
<boost/functional/hash.hpp>.
That requires adding #include "llmutex.h" to llimage.h, llnotifications.h,
llwatchdog.cpp and llvolumemgr.cpp, which were inheriting it from llpointer.h.
Explain why apparently redundant LLPointer methods are necessary.2026-01-05T17:34:44ZNat Goodspeednat@lindenlab.com2024-09-25T14:15:20Zurn:sha1:bedd3da7c60c1615cd5102438822e8f186d4426a
Given templated constructors and assignment operators, it's tempting to remove
specific constructors and assignment operators with the same LLPointer<Type>
parameters. That turns out to be a mistake. Add comments to warn future
maintainers.
Use copy-and-swap idiom for LLPointer's assignment operators.2026-01-05T17:34:44ZNat Goodspeednat@lindenlab.com2024-09-25T13:43:43Zurn:sha1:3fc5b69b2a6c04db9854f0758ecbb03f6da22a13
This affords strong exception safety. Also, eliminating the conditional may
improve speed.
LLConstPointer<T> is the same as LLPointer<const T>.2026-01-05T17:34:44ZNat Goodspeednat@lindenlab.com2024-09-24T17:41:02Zurn:sha1:a3ef0fa3541b799d70b13100b8acb7f57f55313d
Instead of restating the whole class, requiring changes to be made in parallel
(which has already failed), just make a template alias.
Make `LLPointer` equality comparisons accept not-identical types.2026-01-05T17:34:44ZNat Goodspeednat@lindenlab.com2024-09-24T16:53:33Zurn:sha1:e53f50716254e63bd60f2037190741c9b21e50b3
That is, both `LLPointer::operator==()` and `operator!=()` and the free function
`operator==()` and `operator!=()` now accept pointer types other than the type
of the subject `LLPointer`, letting the compiler apply implicit pointer
conversions or diagnose an error.
Changes towards C++20 compatibility (#2520)2024-09-09T10:02:34ZAnsariel HillerAnsariel@users.noreply.github.com2024-09-09T10:02:34Zurn:sha1:d91d39fa0f7f4f204d6fb7ff66b9817e498dbd61Introduce move assignment and construction to LLPointer2024-07-08T15:14:02ZRye Muttrye@alchemyviewer.org2024-07-05T19:01:06Zurn:sha1:38fdee7673a2067733d69244de54312c3ae200db#824 Process source files in bulk: replace tabs with spaces, convert CRLF to LF, and trim trailing whitespaces as needed2024-04-29T04:56:09ZAndrey Lihatskiyalihatskiy@productengine.com2024-04-29T04:43:28Zurn:sha1:1b68f71348ecf3983b76b40d7940da8377f049b7Merge branch 'DRTVWR-588-maint-W' into marchcat/588-w-pbr-merge2023-11-30T10:28:26ZAndrey Lihatskiyalihatskiy@productengine.com2023-11-30T10:28:26Zurn:sha1:0465c761a4cd14003d57d33f5edaa185d6fd7a01
# Conflicts:
# indra/llrender/llgl.cpp
# indra/llrender/llvertexbuffer.cpp
# indra/llui/llflatlistview.cpp
# indra/newview/lldrawpoolground.cpp
# indra/newview/llspatialpartition.cpp
# indra/newview/lltexturefetch.cpp
# indra/newview/llviewergenericmessage.cpp
# indra/newview/llviewertexture.cpp
# indra/newview/llvosky.cpp
# indra/newview/skins/default/xui/en/floater_preferences_graphics_advanced.xml
# indra/newview/skins/default/xui/en/floater_stats.xml
# indra/newview/skins/default/xui/en/floater_texture_fetch_debugger.xml
# indra/newview/skins/default/xui/en/notifications.xml
# indra/newview/skins/default/xui/en/panel_performance_preferences.xml