Megapahit's fork of the Second Life viewer. https://megapahit.org/viewer.git/atom?h=26.1.1 2024-04-29T04:56:09Z 2024-04-29T04:56:09Z Andrey Lihatskiy alihatskiy@productengine.com 2024-04-29T04:43:28Z urn:sha1:1b68f71348ecf3983b76b40d7940da8377f049b7 2016-06-30T20:51:50Z Nat Goodspeed nat@lindenlab.com 2016-06-30T20:51:50Z urn:sha1:464a0df4c1d3e4073fe0bde506ac1d4aa194b02f The LLApp API used to consist of init(), mainLoop(), cleanup() methods. This makes sense -- but on Mac that structure was being subverted. The method called mainLoop() was in fact being called once per frame. There was initialization code in the method, which (on Mac) needed to be skipped with an already-initialized bool. There was a 'while' loop which (on Mac) needed to be turned into an 'if' instead so the method would return after every frame. Rename LLApp::mainLoop() to frame(). Propagate through subclasses LLAppViewer and LLCrashLogger. Document the fact that frame() returns true to mean "done." (This was always the case, but had to be inferred from the code.) Rename the Mac Objective-C function mainLoop to oneFrame. Rename the C++ free function it calls from runMainLoop() to pumpMainLoop(). Add comments to llappdelegate-objc.mm explaining (inferred) control flow. Change the Linux viewer main() and the Windows viewer WINMAIN() from a single LLAppViewer::mainLoop() call to repeatedly call frame() until it returns true. Move initialization code from the top of LLAppViewer::frame() to the init() method, where it more properly belongs. Remove corresponding mMainLoopInitialized flag (and all references) from LLAppViewer. Remove 'while (! LLApp::isExiting())' (or on Mac, 'if (! LLApp::isExiting())') from LLAppViewer::frame() -- thus unindenting the whole body of the 'while' and causing many lines of apparent change. (Apologies to reviewers.) There are four LLApp states: APP_STATUS_RUNNING, APP_STATUS_QUITTING, APP_STATUS_STOPPED and APP_STATUS_ERROR. Change LLAppViewer::frame() return value from (isExiting()) (QUITTING or ERROR) to (! isRunning()). I do not know under what circumstances the state might transition to STOPPED during a frame() call, but I'm quite sure that if it does, we don't want to call frame() again. We only want a subsequent call if the state is RUNNING. Also rename mainLoop() method in LLCrashLogger subclasses LLCrashLoggerWindows, LLCrashLoggerMac, LLCrashLoggerLinux. Of course it's completely up to the frame() method whether to yield control; none of those in fact do. Honor protocol by returning true (frame() is done), even though each one's main() caller ignores the return value. In fact LLCrashLoggerWindows::mainLoop() wasn't using the return protocol correctly anyway, returning wParam or 0 or 1 -- possibly because the return protocol was never explicitly documented. It should always return true: "I'm done, don't call me again." 2016-03-07T17:41:11Z Oz Linden oz@lindenlab.com 2016-03-07T17:41:11Z urn:sha1:5822fb00b605d4f4ddd01e887b40d04b67e162a9 2015-11-10T14:48:56Z Oz Linden oz@lindenlab.com 2015-11-10T14:48:56Z urn:sha1:c8726aba303bcf1207b730a344536e25491420bc 2014-11-20T21:25:11Z Jonathan Yap jhwelch@gmail.com 2014-11-20T21:25:11Z urn:sha1:44f5d7320952de2c4c7e1062b1c02c2f521400fa 2014-04-08T02:09:40Z Richard Linden none@none 2014-04-08T02:09:40Z urn:sha1:98aabdc176c23de9ba23f902dc2015f9c775d26e 2013-12-04T01:06:06Z Aura Linden aura@lindenlab.com 2013-12-04T01:06:06Z urn:sha1:680934812598d2c9116303f3245e7a9d60ff58bf 2013-08-15T04:58:30Z Richard Linden none@none 2013-08-15T04:58:30Z urn:sha1:d83c51a4e1923508e31f25576761f001d731ea93 2013-03-29T14:50:08Z Graham Madarasz graham@lindenlab.com 2013-03-29T14:50:08Z urn:sha1:bf6182daa8b4d7cea79310547f71d7a3155e17b0 2011-07-12T22:48:02Z Aaron Stone stone@lindenlab.com 2011-07-12T22:48:02Z urn:sha1:42daa3497b6626cbb5f32ba54162558cd025069b